From patchwork Sat Mar 9 07:47:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1053802 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MHu454cv"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44Gc6Z1Bw2z9s3q for ; Sat, 9 Mar 2019 18:52:54 +1100 (AEDT) Received: from localhost ([127.0.0.1]:55299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Wmq-0006WV-2o for incoming@patchwork.ozlabs.org; Sat, 09 Mar 2019 02:52:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Wig-0003t6-23 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2Wie-0000UL-2B for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:33 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:34878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2Wia-0000N4-8X for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:30 -0500 Received: by mail-wm1-x331.google.com with SMTP id y15so14270957wma.0 for ; Fri, 08 Mar 2019 23:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=EbLP00A4BLiP9DapEqSnouNkDQH3tjoU/b+1XsA4uo8=; b=MHu454cvDvFHlmqrEFwMU1v8aQuA/Jv7/rkKV8UpFDmAUV82CdrzaRx3WX6Eno9O8I KLhO36bUhp6DJ5akbJXxcTpS5lZ+Th+Pgm3ngLBe4Tz0vpMVGuB55Plq2oIy9eRFuOqI gqyOk/B1b64FQHB7tGWtX3lSYQw+GtQTFH5F8eMHHNgjlsPkeZH+GhYmVSbfmbuY7/ye an+mfP8mrAC6+0cobOqHL1Lx4OMxwGTV2hMKZfrZy4x20eSXUtZcwW8L0yXbROULPi7q ZXiyZ9UorON0D7DxZNWJ1wMyIiBDSK4Bi6f+WfhDPT1CXcWExS38fZYbt4pvwmT/wTLh KQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=EbLP00A4BLiP9DapEqSnouNkDQH3tjoU/b+1XsA4uo8=; b=RWPKYHymwAUuGy2bIUngyJLK1vwGd6r+ZVmw11s6c2556N5Zf7liQyAG5njetDxGK9 cDZeZr3buVs6i6XJoT4pQ+IcoCSeIYWIH7/07NXXBtJQnVskduaxzY0ki+tVsp4zWvBN SyH4h8YZrUjOH/apB9vyIZISlhfsgbxq6I737uWtC54IyDj0VEuiYiPq8WAcIJs0IPFb RjN6ISZP+XiSsQJoQjROFfU5FGcKM0fspvHfhDUrTc81xPGt6TMlHAtf0mAs6bKd2xvt tnGdm/cZLkO/np2shNB2oUcsvg3OqM16U+l+oj+tGNJAQGTdktOSZ5U17UBiMxGy4Mlr +U4Q== X-Gm-Message-State: APjAAAXjDGNXwGkR4E6VYiwIicRjs+asnk3fPmJ1wWSIuBGvn616zB6R MMFWMav4MdlxzMFxw0PES8mQzekY X-Google-Smtp-Source: APXvYqwMdq7FuLOG8G+wxSeBaXLOMyETXDPdVXRoCy2sDHw7K96n/Wi9BatHI+SXiiUDFMQ2SCgXEQ== X-Received: by 2002:a1c:8088:: with SMTP id b130mr11065964wmd.96.1552117704290; Fri, 08 Mar 2019 23:48:24 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id 11sm5252294wmg.27.2019.03.08.23.48.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 23:48:23 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 9 Mar 2019 08:47:58 +0100 Message-Id: <1552117698-12355-6-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> References: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 Subject: [Qemu-devel] [PULL 05/25] contrib/elf2dmp: add kernel start address checking X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viktor Prutyanov Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Viktor Prutyanov Before this patch, if elf2dmp failed to find NT kernel PE magic in allowed virtual address range, then it assumes NULL as NT kernel address and cause segfault. This patch fix the problem described above by checking NT kernel address before futher processing. Signed-off-by: Viktor Prutyanov Message-Id: <20190219211936.6466-1-viktor.prutyanov@phystech.edu> Signed-off-by: Paolo Bonzini --- contrib/elf2dmp/main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 1a45eaf..1bfeb89 100644 --- a/contrib/elf2dmp/main.c +++ b/contrib/elf2dmp/main.c @@ -524,6 +524,12 @@ int main(int argc, char *argv[]) } } + if (!nt_start_addr) { + eprintf("Failed to find NT kernel image\n"); + err = 1; + goto out_ps; + } + printf("KernBase = 0x%016"PRIx64", signature is \'%.2s\'\n", KernBase, (char *)nt_start_addr);