Message ID | 1544628195-37728-13-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="izM05tTo"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43FLcw1cdFz9s1c for <incoming@patchwork.ozlabs.org>; Thu, 13 Dec 2018 02:41:04 +1100 (AEDT) Received: from localhost ([::1]:45646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1gX6dB-0006Lx-Qj for incoming@patchwork.ozlabs.org; Wed, 12 Dec 2018 10:41:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1gX6Ma-0000ri-Rs for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1gX6MZ-0000HI-1v for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:52 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:54624) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1gX6MY-0008TD-C1 for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:50 -0500 Received: by mail-wm1-x329.google.com with SMTP id a62so6178136wmh.4 for <qemu-devel@nongnu.org>; Wed, 12 Dec 2018 07:23:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=9bD4vF/SlqiZQomVw94Gxcz7amk2GbQ9PdomFkHSTsc=; b=izM05tTo3TPRAbVC/bM3IC4Fv5aOoCF3lpMJROZWxfzYKvcayfad+7mUrcWx97lb9K /jRVwccJPgzdE7uZ/mNdcqxWxYlvbyp3L4mT3JOnjh8GTjwky6zNCVDVpVNyaTUt0L00 NQuWep9MQGIHMmeFMgJNv0J/Gm1HOvibiY2d83w+y+gFspdDCaMEtRRtcUygo2bk9cfH iVwBpSJwkXLNhw+BP9KoB1B35T4OohSiYdVoVTEPeMFxuJpUnkbg17ToTGSDIoS04qmp awTkgIwZmUkZuMoTA0NTWGA7SXbhuktY5dvy1t3uQFVl1s/LWMaqJaAPNnkYLYr63SHQ 1vvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=9bD4vF/SlqiZQomVw94Gxcz7amk2GbQ9PdomFkHSTsc=; b=IP5XqP9aWmwc57jQ/pba6SgOJSnpSb/UFaxl2VJWJ2YJ7o895kqwCLYo2YRtX2BA4a t66Ne5gRaCkwFHYNOY453zyel5ROluT4wCGFnAOEFdoNoxjiNTcLs8tkO+0o7GX2aUZ/ Er8yHyiI7SfI7LFTYbxlbNQZvLOO9huIXuY2HAXe34T6+4aLi5Xeed4VWuTGiOB88hD9 XgwbBrSkPy9BWGZQYvij6ibF3zcoayzNbyPZgaXBDqZCFeNAuz6u84WKTl2wzNSO+X3d ZWtKUzY7vYafVtGbY5O57ETpbjeOmPneQl7qU76GhjX0CpwXQx7AdtpImovO5lGkamzm VmZA== X-Gm-Message-State: AA+aEWZwm9UJSpNgBzGgJ+aI0pRqbDMGlqOu5H2RpUpdNliYgE3R5vRm 5dC/l6xJxwl+FgA27HVai/KQfVFa X-Google-Smtp-Source: AFSGD/WTH4zRvEEmI2635Gc4++Izqi/7Qz3VwX5prvyYCP9yfu5lPd+/rwCgp12SDhhUub3bTbfYfQ== X-Received: by 2002:a1c:d988:: with SMTP id q130mr7073051wmg.41.1544628212229; Wed, 12 Dec 2018 07:23:32 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id u10sm15878859wrr.33.2018.12.12.07.23.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 07:23:31 -0800 (PST) From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Date: Wed, 12 Dec 2018 16:22:33 +0100 Message-Id: <1544628195-37728-13-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> References: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::329 Subject: [Qemu-devel] [PULL 12/54] block/iscsi: drop unused IscsiAIOCB->buf field X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Stefan Hajnoczi <stefanha@redhat.com> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[PULL,01/54] accel: Improve selection of the default accelerator
|
expand
|
diff --git a/block/iscsi.c b/block/iscsi.c index 727dee5..a4e3730 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -117,7 +117,6 @@ typedef struct IscsiAIOCB { QEMUBH *bh; IscsiLun *iscsilun; struct scsi_task *task; - uint8_t *buf; int status; int64_t sector_num; int nb_sectors; @@ -150,9 +149,6 @@ iscsi_bh_cb(void *p) qemu_bh_delete(acb->bh); - g_free(acb->buf); - acb->buf = NULL; - acb->common.cb(acb->common.opaque, acb->status); if (acb->task != NULL) { @@ -933,9 +929,6 @@ iscsi_aio_ioctl_cb(struct iscsi_context *iscsi, int status, { IscsiAIOCB *acb = opaque; - g_free(acb->buf); - acb->buf = NULL; - acb->status = 0; if (status < 0) { error_report("Failed to ioctl(SG_IO) to iSCSI lun. %s", @@ -1010,7 +1003,6 @@ static BlockAIOCB *iscsi_aio_ioctl(BlockDriverState *bs, acb->iscsilun = iscsilun; acb->bh = NULL; acb->status = -EINPROGRESS; - acb->buf = NULL; acb->ioh = buf; if (req != SG_IO) {