| Message ID | 1536163920-2443-1-git-send-email-zhangckid@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | docs/block-replication.txt: Add more detail about replication_do_checkpoint_all | expand |
Hi All, No news update? Ping... Thanks Zhang Chen On Thu, Sep 6, 2018 at 12:12 AM Zhang Chen <zhangckid@gmail.com> wrote: > Add more detail description for COLO checkpoint use case. > Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com> > > Signed-off-by: Zhang Chen <zhangckid@gmail.com> > --- > docs/block-replication.txt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/docs/block-replication.txt b/docs/block-replication.txt > index 6bde6737fb..b6c5e94764 100644 > --- a/docs/block-replication.txt > +++ b/docs/block-replication.txt > @@ -131,9 +131,10 @@ a. replication_start_all() > thread. > b. replication_do_checkpoint_all() > This interface is called after all VM state is transferred to > - Secondary QEMU. The Disk buffer will be dropped in this interface. > - The caller must hold the I/O mutex lock if it is in > migration/checkpoint > - thread. > + secondary node, and in primary node this interface no need to > + called after synchronizing all the states. The Disk buffer will be > dropped > + in this interface. The caller must hold the I/O mutex lock if it is > + in migration/checkpoint thread. > c. replication_get_error_all() > This interface is called to check if error happened in replication. > The caller must hold the I/O mutex lock if it is in > migration/checkpoint > -- > 2.17.GIT > >
Hi All, Maybe we have forgot this patch? Ping again. Related discussion: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03352.html Thanks Zhang Chen On Fri, Sep 14, 2018 at 2:32 PM Zhang Chen <zhangckid@gmail.com> wrote: > Hi All, > > No news update? > Ping... > > Thanks > Zhang Chen > > On Thu, Sep 6, 2018 at 12:12 AM Zhang Chen <zhangckid@gmail.com> wrote: > >> Add more detail description for COLO checkpoint use case. >> Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com> >> >> Signed-off-by: Zhang Chen <zhangckid@gmail.com> >> --- >> docs/block-replication.txt | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/docs/block-replication.txt b/docs/block-replication.txt >> index 6bde6737fb..b6c5e94764 100644 >> --- a/docs/block-replication.txt >> +++ b/docs/block-replication.txt >> @@ -131,9 +131,10 @@ a. replication_start_all() >> thread. >> b. replication_do_checkpoint_all() >> This interface is called after all VM state is transferred to >> - Secondary QEMU. The Disk buffer will be dropped in this interface. >> - The caller must hold the I/O mutex lock if it is in >> migration/checkpoint >> - thread. >> + secondary node, and in primary node this interface no need to >> + called after synchronizing all the states. The Disk buffer will be >> dropped >> + in this interface. The caller must hold the I/O mutex lock if it is >> + in migration/checkpoint thread. >> c. replication_get_error_all() >> This interface is called to check if error happened in replication. >> The caller must hold the I/O mutex lock if it is in >> migration/checkpoint >> -- >> 2.17.GIT >> >>
diff --git a/docs/block-replication.txt b/docs/block-replication.txt index 6bde6737fb..b6c5e94764 100644 --- a/docs/block-replication.txt +++ b/docs/block-replication.txt @@ -131,9 +131,10 @@ a. replication_start_all() thread. b. replication_do_checkpoint_all() This interface is called after all VM state is transferred to - Secondary QEMU. The Disk buffer will be dropped in this interface. - The caller must hold the I/O mutex lock if it is in migration/checkpoint - thread. + secondary node, and in primary node this interface no need to + called after synchronizing all the states. The Disk buffer will be dropped + in this interface. The caller must hold the I/O mutex lock if it is + in migration/checkpoint thread. c. replication_get_error_all() This interface is called to check if error happened in replication. The caller must hold the I/O mutex lock if it is in migration/checkpoint
Add more detail description for COLO checkpoint use case. Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Zhang Chen <zhangckid@gmail.com> --- docs/block-replication.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)