Message ID | 1530265890-17213-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 29 June 2018 at 10:51, Paolo Bonzini <pbonzini@redhat.com> wrote: > The following changes since commit 4a83bf2f339d4b63ecd5ef48b9816c3b7ee24553: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20180627' into staging (2018-06-28 15:31:42 +0100) > > are available in the git repository at: > > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to f5a4d8d963a7f87c474a8b16d508321d4e75833c: > > tests/boot-serial: Do not delete the output file in case of errors (2018-06-29 11:47:57 +0200) > > ---------------------------------------------------------------- > * "info mtree" improvements (Alexey) > * fake VPD block limits for SCSI passthrough (Daniel Barboza) > * chardev and main loop fixes (Daniel Berrangé, Sergio, Stefan) > * help fixes (Eduardo) > * pc-dimm refactoring (David) > * tests improvements and fixes (Emilio, Thomas) > * SVM emulation fixes (Jan) > * MemoryRegionCache fix (Eric) > * WHPX improvements (Justin) > * ESP cleanup (Mark) > * -overcommit option (Michael) > * qemu-pr-helper fixes (me) > * "info pic" improvements for x86 (Peter) > * x86 TCG emulation fixes (Richard) > * KVM slot handling fix (Shannon) > * Next round of deprecation (Thomas) > * Windows dump format support (Viktor) This still fails in the same way: LINK i386-linux-user/qemu-i386 target/i386/cpu.o: In function `x86_cpu_realizefn': /home/petmay01/linaro/qemu-for-merges/target/i386/cpu.c:4815: undefined reference to `enable_cpu_pm ' collect2: error: ld returned 1 exit status thanks -- PMM
On 29/06/2018 12:30, Peter Maydell wrote: > > This still fails in the same way: > LINK i386-linux-user/qemu-i386 > target/i386/cpu.o: In function `x86_cpu_realizefn': > /home/petmay01/linaro/qemu-for-merges/target/i386/cpu.c:4815: > undefined reference to `enable_cpu_pm > ' > collect2: error: ld returned 1 exit status Uhm, it worked for me. I'll just add a stub. Paolo
On 29 June 2018 at 11:31, Paolo Bonzini <pbonzini@redhat.com> wrote: > On 29/06/2018 12:30, Peter Maydell wrote: >> >> This still fails in the same way: >> LINK i386-linux-user/qemu-i386 >> target/i386/cpu.o: In function `x86_cpu_realizefn': >> /home/petmay01/linaro/qemu-for-merges/target/i386/cpu.c:4815: >> undefined reference to `enable_cpu_pm >> ' >> collect2: error: ld returned 1 exit status > > Uhm, it worked for me. I'll just add a stub. Maybe you forgot to push something? I can't see anything in commit 6f131f13e68d648a8e4 in that merge branch which looks like it's trying to work around the undefined reference. thanks -- PMM
On 29/06/2018 13:02, Peter Maydell wrote: >>> This still fails in the same way: >>> LINK i386-linux-user/qemu-i386 >>> target/i386/cpu.o: In function `x86_cpu_realizefn': >>> /home/petmay01/linaro/qemu-for-merges/target/i386/cpu.c:4815: >>> undefined reference to `enable_cpu_pm >>> ' >>> collect2: error: ld returned 1 exit status >> Uhm, it worked for me. I'll just add a stub. > Maybe you forgot to push something? I can't see anything > in commit 6f131f13e68d648a8e4 in that merge branch which > looks like it's trying to work around the undefined reference. The problematic patch is the next one. The change was to put the new code under "if (!kvm_enabled()) goto out;" so that it becomes dead under linux-user, but it still depends on how much dead code removal the compiler is allowed to do at -O0. Paolo