Message ID | 152882288685.114328.8550617676763950480.stgit@bahia.lan |
---|---|
State | New |
Headers | show |
Series | [1/3] target/ppc: drop empty #if/#endif block | expand |
On 06/12/2018 02:01 PM, Greg Kurz wrote: > If the negotiated compat mode can't be set, but raw mode is supported, > we decide to ignore the error. An so, we should free it to prevent a > memory leak. > > Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/ppc/spapr_hcall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c > index 022f6d810182..8b9a4b577fbf 100644 > --- a/hw/ppc/spapr_hcall.c > +++ b/hw/ppc/spapr_hcall.c > @@ -1547,6 +1547,7 @@ static target_ulong h_client_architecture_support(PowerPCCPU *cpu, > error_report_err(local_err); > return H_HARDWARE; > } > + error_free(local_err); > local_err = NULL; > } > } > >
On Tue, Jun 12, 2018 at 07:01:26PM +0200, Greg Kurz wrote: > If the negotiated compat mode can't be set, but raw mode is supported, > we decide to ignore the error. An so, we should free it to prevent a > memory leak. > > Signed-off-by: Greg Kurz <groug@kaod.org> Applied to ppc-for-3.0, thanks. > --- > hw/ppc/spapr_hcall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c > index 022f6d810182..8b9a4b577fbf 100644 > --- a/hw/ppc/spapr_hcall.c > +++ b/hw/ppc/spapr_hcall.c > @@ -1547,6 +1547,7 @@ static target_ulong h_client_architecture_support(PowerPCCPU *cpu, > error_report_err(local_err); > return H_HARDWARE; > } > + error_free(local_err); > local_err = NULL; > } > } >
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index 022f6d810182..8b9a4b577fbf 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -1547,6 +1547,7 @@ static target_ulong h_client_architecture_support(PowerPCCPU *cpu, error_report_err(local_err); return H_HARDWARE; } + error_free(local_err); local_err = NULL; } }
If the negotiated compat mode can't be set, but raw mode is supported, we decide to ignore the error. An so, we should free it to prevent a memory leak. Signed-off-by: Greg Kurz <groug@kaod.org> --- hw/ppc/spapr_hcall.c | 1 + 1 file changed, 1 insertion(+)