Message ID | 1525817687-34620-30-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bN5cmdAl"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40gZ6X59lsz9s37 for <incoming@patchwork.ozlabs.org>; Wed, 9 May 2018 08:34:28 +1000 (AEST) Received: from localhost ([::1]:53611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1fGBBi-0003Dt-BE for incoming@patchwork.ozlabs.org; Tue, 08 May 2018 18:34:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1fGAtK-0003MV-Ap for qemu-devel@nongnu.org; Tue, 08 May 2018 18:15:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1fGAtJ-0001eg-38 for qemu-devel@nongnu.org; Tue, 08 May 2018 18:15:26 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:53387) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1fGAtI-0001dF-Bo for qemu-devel@nongnu.org; Tue, 08 May 2018 18:15:24 -0400 Received: by mail-wm0-x236.google.com with SMTP id a67so21144136wmf.3 for <qemu-devel@nongnu.org>; Tue, 08 May 2018 15:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=3euoiip8n+vjFBxrUp+AGab3S5EZ2w2eRpI15NWnmqs=; b=bN5cmdAl5Mz72OopsJJ0EhrWulRYNSovX8+FZX8ZNUePx/GC10T7dnnK2/AV94ejjH biPEYj53NQUl9Hvkxo2+W7jaDT1I/VoAPrfoyJQplWjczGY6/eXCg6qrR8cDRpXw13nE gzbbP1E8xaopsUR43ZP6cahu3wlq5gPvdzf21zADSNfHH8vuO5w94frQwwDPWFxmemcu yDZd5oFqC8DKesOY9GJKkJmJC5KbVm3VobLIrOGzhDa2EtzNoJfPxR+xs1/9dhMBTnyu 8DpKD1GQ+ZzNbdeDZL6ZuBSG6drgt3XjMUwDV+ofHcfm3hiyGhvqGn3/eAEPtj/q7NFH vmUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=3euoiip8n+vjFBxrUp+AGab3S5EZ2w2eRpI15NWnmqs=; b=ioODe/EsQO8Ox3q2fI1eU9ybHshM3WwwIoV7JSxBq9BQgCIAu90YerGYJJzb8Qc2xE Mg1KOXxpQW5BcGHJmB5SFvVwe3XLay0+4YTtV5ld+KI1QFIkr/aBeUQcvLctPTDND+t7 8buShpQTiHV8IIyzJ9qdLM3Wv6p28QVDAioo5t8JISlXVxqviUZEGJNyPkWjTm3xEmr2 N3rcd+Vptr1QwQMFY8lcYrrdserJZzG4GyF6YakspuLOh3Ic7xxNM86VN66fBTtV1YgO QWOnRHXiLhW1lvyhAtHaNRzcnaRx9oGmkCPZRyNyRY+IYzQe/ZKf28qD1jN4iCt15K7Y ulGQ== X-Gm-Message-State: ALQs6tA3W8JfMKuEHC9zaQPuz8WFu9jVjJcRNxySkFRXmaQMmf1HLqxY 05TAhT+HqGqiz5CrC5qF0i8bYOYn X-Google-Smtp-Source: AB8JxZrJR0yafdfd4nIC2yz7yru3wMpWYRFGMwEXE54PWp6k8Q5YNI9j5Qb3LjC6rnKOuPLGEN+NSg== X-Received: by 2002:a50:e389:: with SMTP id b9-v6mr57314823edm.4.1525817723106; Tue, 08 May 2018 15:15:23 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-189-60.clienti.tiscali.it. [78.12.189.60]) by smtp.gmail.com with ESMTPSA id c15-v6sm14020129edr.78.2018.05.08.15.15.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 15:15:22 -0700 (PDT) From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Date: Wed, 9 May 2018 00:14:46 +0200 Message-Id: <1525817687-34620-30-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1525817687-34620-1-git-send-email-pbonzini@redhat.com> References: <1525817687-34620-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::236 Subject: [Qemu-devel] [PULL 29/30] pc-dimm: fix error messages if no slots were defined X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: David Hildenbrand <david@redhat.com> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[PULL,01/30] configure: recognize more rpmbuild macros
|
expand
|
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 0119c68..12da89d 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -118,9 +118,16 @@ static int pc_dimm_slot2bitmap(Object *obj, void *opaque) int pc_dimm_get_free_slot(const int *hint, int max_slots, Error **errp) { - unsigned long *bitmap = bitmap_new(max_slots); + unsigned long *bitmap; int slot = 0; + if (max_slots <= 0) { + error_setg(errp, "no slots where allocated, please specify " + "the 'slots' option"); + return slot; + } + + bitmap = bitmap_new(max_slots); object_child_foreach(qdev_get_machine(), pc_dimm_slot2bitmap, bitmap); /* check if requested slot is not occupied */