From patchwork Tue Apr 10 23:16:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 896982 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="kpfG39je"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40LNWb31syz9s1p for ; Wed, 11 Apr 2018 09:23:07 +1000 (AEST) Received: from localhost ([::1]:54755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f62bR-0000BR-EG for incoming@patchwork.ozlabs.org; Tue, 10 Apr 2018 19:23:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f62V7-0003GR-KF for qemu-devel@nongnu.org; Tue, 10 Apr 2018 19:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f62V4-0005iy-Dz for qemu-devel@nongnu.org; Tue, 10 Apr 2018 19:16:33 -0400 Received: from mail-bn3nam01on0078.outbound.protection.outlook.com ([104.47.33.78]:48576 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f62V4-0005id-0e for qemu-devel@nongnu.org; Tue, 10 Apr 2018 19:16:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZqszMJ1gxujV5Tk9Kjw3C8SjojU+gU17BBy/dBq7PGA=; b=kpfG39jeUWGafj/2jVNVYcIZp2F4S/NyyRvFqLbGxIX17mOsG37IWiA9J0HoebezGobGl100CCRN+RQsd+dx3hB2khlt7qxgp3aA9+7D5vB7V1emstz++QQETy9I/bO7BjcCbYZkiUhyjrG9lk/9tGqbjeVIFoAk90uuUHxbQus= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-pyp0.amd.com (165.204.77.1) by CY4PR12MB1767.namprd12.prod.outlook.com (2603:10b6:903:122::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 23:16:27 +0000 From: Babu Moger To: mst@redhat.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Tue, 10 Apr 2018 19:16:07 -0400 Message-Id: <1523402169-113351-8-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1523402169-113351-1-git-send-email-babu.moger@amd.com> References: <1523402169-113351-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR2201CA0048.namprd22.prod.outlook.com (2603:10b6:301:16::22) To CY4PR12MB1767.namprd12.prod.outlook.com (2603:10b6:903:122::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:CY4PR12MB1767; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 3:Opt7rpiBt0SwvFoNlhU9VDxNeM/hERAbW908eskjLdDFyf1sODRJKQz9J4GYVKB9PLGQoOAvYeXDRe0jZhJVWfr9kaPi4PAHXByZ9ANZC51cfHXnDu/dWXS6CTXdwLVEm4+YWyljJkxCn8Qh9lhMs2Ufxfennw587GL98vJ1fSY+Sp8DzT8Mah0nGwXl+7DsnZfaFLvug7asM8ZT1qrESw14gK0DOV5yomZUx2uh3KDAwqgQ2Wfk+F028qi41hw5; 25:vY8MIe3i7GBdbSaDKYb7aKeMKiH/02UvN+n5/rxxBZ6cXed5DP+neU40QYqk/TJazfyKxohu8Lpkv3y8PPHR4xnvvRjy99s4iWKM3XaA7TXKK9zW9F7e8BJCdKi6366hKo3eg0uANd5BIgMWpruLI9qpQZ4Sf1eY3WwHJwGueRjlWkntQUic0b5mp1vce7uC90UZfTJV08M4aq0QixBa9iVQ96M21d9CU9IXy6PtCEQwMiGJ/1YD+JXvA/aUlJSbJD56Urp7trYyPXBuCTdDpnCCLTB5WKiRkkKuqqhMgRmdf/8SrhPTONGj+K591/DPraXRR6It4hQgIrr6YV/5Rg==; 31:yOa2ap8lLO7VwKnSdJV/6vHZVpMKSg6BnmkWayGwSoyvdDfEji8wgvPycnvw/nULHT3lzY+MbMCLrqCrgywZ9Nuv7Bd3ex2wldaJenUZW1rMgdvpC3PxikXVhR5Tnd4jbPIgZRI0jRjN3XUTKMTauqK67NibcrdZtv1V1PcwSSC5PAbBTXwMLTeB1k0SndphNg/7kN4pagPSyfpCdvIfagqfkLYscmKsRFc95ojMkbY= X-MS-TrafficTypeDiagnostic: CY4PR12MB1767: X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 20:afMNutwdNvhDnQh2cJo/CmWwxneTrFE4CLRXnP1ucR9j7K1weFe9e+ZYesEEIsCq6bSLXS2ProGtLmzCrFtDkjusbRZ9mx2l86QSTbjc5KivGkUw0qokMooLqM0bTJ4sSJVEDxt/HPqzfkMNTkrxkApeXnUKcwkvP6bVxlY967tHSdlZyz9D80Y/3oeU83nz3TDz1BAnA2imENIhW9U52KPgo0aJiFwJ/0weHqKmVtFzBWxpgyR/NW+1tmlgbmvzzg90JuV6QonbT/4ev9pbL1e564o5foY4dJyJxeFHSg6+L5Cb8kUzt60qJRJv2jI9+K5y2TjYhu/BUjAtROnXE2QqWpR2xfyJ+54TbaETUQIXEfpn15QbanugkistLx1p7LinenH4RuLxg+fCRLWNtxrkSf9YYjD3RcvRquuzRlmTfssSjoEBn1q/dkhHXWpCiEv3w3qa0kqEyRys6e4XFs9OnrVknzvmv6S5on1biC2qdfOj/H55AOF0tcCts7Pa; 4:jvlpyvWwxb1JQwL/lSWoOQFAnc07F0LdVIHhy+Oe98KBOFyl+fZXGtfePgf8QII5pwioXODE27X0lhb3vftrpOkK772xWZgAuJ07ACEP2/8P65TOS0cETCxNQ4ygkqKCTJ/XXAbPVLDD4Ye6Xu77C+tJGKIqVMk35zQUmmevXk5VRDgTpWcmvaDkMv0xCbvZLO6WJEzq9YMmOYpqCft97mYleFlZmg0QfwqJT3d2IVSLmdqMqx6gY06NuS4MFn3sbgVtTw6SYeS5wZjByj2ZbKYW/gIRvn+STQ6xT2gOA4TYzoX8kui6CHku4cYuhSy2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR12MB1767; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1767; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39860400002)(39380400002)(396003)(199004)(189003)(476003)(2906002)(52116002)(26005)(86362001)(50466002)(50226002)(305945005)(5660300001)(186003)(48376002)(7736002)(16526019)(6666003)(25786009)(6116002)(446003)(11346002)(105586002)(4720700003)(2616005)(6486002)(4326008)(956004)(3846002)(66066001)(53416004)(8936002)(386003)(72206003)(478600001)(316002)(16586007)(8676002)(81156014)(81166006)(97736004)(36756003)(47776003)(76176011)(106356001)(7416002)(7696005)(51416003)(68736007)(53936002)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1767; H:linux-pyp0.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR12MB1767; 23:vPhoGLGA1H/Hi27alJGADnnSxhJoCUzrPNmWJ0ylp?= XT7Q00u9SDOVvl9E4tP5D376pJPrUqUqhmntyAxRlW5443rB+EvauIlIp3fi40n4lQErd9gShwjG864GyS4WF27Avt7gtmTdaPQX0dPHNMsbYKQXfVwHfyRzP6ZpsTjdKa5vqV3K8v/snJyse+Xog6O6Z+kEUo2l/wGNkZYnShrDk9FiCcoHigz4fYl77SjKitT4HsvCgHrad3Nieh19fUqxIrji4Ze4Z6F5KJOc2MWFEEo2L1ysQ2JuhA6+p29cTh8+1u8VjOQ9AZLfBdEC132Oc/5B78AZ6wDuddK+IWkh/c6aPJ/yQYkamXFGJ6Jbve9FcOr7LzrNSkOyiWcar5qwkC6b7Um3BrSCWzM6Bq/QilsZ2zp0n7SLzKSzeOXIGG2f8ncgrat33fuSDFllDP/YJVmOXHGsCOe3V3+8P/VtUCsJSq8Hkh1Y2VR7xdttelr5wZTjRNocK+K+tAP6oZ3m9tfkTuL2GQpopzokEvGQNfGAMEIGsdTOdLBxOfIC84nr4FfXqXxBD0K8JIA6JOct7moevtfoRJRgenfq3BcHMLgJFeO40edqAoN/O+tBv4/SBfPpHyfQNcXxhaQ/ya+ICj5F8/l1pFMwML4vrJ3FggWAG4F75rusENm2VYcUOkAH7/pkzG/NPV8/As9e7C/0/q3npU33xLPd+ewuYzIRthirGBCoVp/yREpaXBtGp54HFQBk+7uw5GeqYGaCQeQZPgjFI2QRuRNkSTmVshwgo1S6uwubHYqMgom6WlbcVpp8WTy4Wnym6Qd3mBuvV1OGtIdF14vacrcOF0SVAATR2I41ew86NXAVoVUrzBvZo+LqKqXBWhkHXDSnOYHpCqVDK+RkQMOSMO1Fqvh/+q9ikD9hYspKUDFaHwMEcVNBF/k4q90MRDKGCtiW4TB4zfp+mbrMhXcKHFN86boB5goA6WJbQJd0l8QlRzgPg5Y1rpcaPptil3Xj0HB+yZnrIzTRMggbFzmKbXonyKCRYBeSW64houuIGmWrYjnAS77F3deyAQKCbZzUHR0mVm/rc0xuGPwABQ4mg02zs9DY+/q81C+iDYkmRoPkgn+3eizs/+BQgllxHON5Y54AMKUpKnMJgD7FbiyxuhUpkZyyLxwIIuIVq5/0OmB8DTCd9mCXcbwpDTrdl+oU+vHfaU2LGL6RHt9SR+t4RTr5wSOOUd8hw== X-Microsoft-Antispam-Message-Info: mkWcZglQWk4MXPKv/bcHVXShXev8QMTyoPCeJtGOaXnx3YZsnlhgcuRqi5tfRMGiqFm2ml4/vZcRcbksUM+Sd2YhTBpFIDK8aXkvEv98PhALOEvE6hPcX9pZT20frHS3kBJ1Hgd27Ykba0if4JBdZcUKiibB53864KTbrmdzbo/vGwJK0JaxVbmJ+8YvSL6C X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 6:3xmWyRsuEygai+H6eYTKGtaJV4YLJm2b4D4nmQZQPUSoSAJpdZbcl7xwLouypX9FZGNdra7pIxgyYYSZOdiqqKZTx4uXSw2PTv0RnW5h20hyO5AIQCtMrKW64tDXitX5Y/iNVxRTMIhj7B7a6CYhV1lRI/NdJd1lO4P34TIcB7imeJ4UbScrfhI8G2xfTMZY76WMa++uFC8fmwScWg3Dvv5wNt8Q4IMvN/EePkSn+AwZo1ZL3o5Sl1hRTupNwtg2QdGsGOgn0QVFvJpRdBqqY68vDjtRg9LLkDcF5CzhCIdF4xAdtrQwDIK/RAkV279hBm7jp6lMyJQKc4EzEXxtlIvO6WHjVSYhbmu/oCx68F58AnrXRThMSy5INMzXrYomFptiWfoWlcaBsBYwAmDsDVK+7HA5Lti/g6qxCDvsnb2Je+6SC66r45NIg6Qi+dPUPQrE9lUMHUJbFdn5AdGqzw==; 5:dmTYnXulg3v+jm6Io0R3lYz9VRgrOQdPFsxT2g96fdQm06fcdEyvij//Ms13zJopNB1A43Um/5flesOqkKzKASzBLSJ6qHHJBEcMM2nhsPzfcavlwaDI/n0OIKO1MHHrWCOzRFfpfa4nSoJv86Vga2nT1bLkVpFwxI00nvpXtE0=; 24:lU1CwesrehT7QHqO8tIcu1h80y43mCEZVLFH2w5GttJ0OavZoeX6p36QqHjPNEjtTGF09BuMoNEi3jtApxxPAdH7zHmG9zC3VFT8X9lz0i0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 7:rJYiZ8GKLplln4fVJmmvr6WGSMDObwymsza/+imP1UBmpyGcb6VWkrwF/Sqbl0Fv1VJSXLR68vnP2kzy8L/is34VcvvbisjzB30hFVcezBJ8PPRKwRkH6OLdzRahhJdGRzHrKHkMFLMPncV4a/F3nZIfr/r6MxmoC3+x72UP/+P440u3O+jqlBiPlVuF1UN/LR14MLkSUeGo8hgPmq9AApW4a/LFNysehThLEngV6JuJWj+A7kmXPYpwi+VOyARg; 20:5zly1JrnOaGCXr7IDaM9Dc/nua3gOFxVv7L4AvSMaFWuOCYpjOl9ewbBPdGQbWKrcySLHwhN8cG+2o4FJVljcguB896AZRUR+d/RO8qPAbmrG85nzzQN+oa4pPDOAT5hIZVUc5srou2p2nsUqLrVvMvvsAFShe12686uWHfccfMa0EIJzSYm3A2noshxXsruEbnui/Pw9BgB95pDJPOnAeSJagNefMGhPx/1tmv2iO1IL7+rWIZmvEkxdZU9IQyh X-MS-Office365-Filtering-Correlation-Id: ec5853f1-bf36-4fba-831b-08d59f3916b3 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 23:16:27.5296 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec5853f1-bf36-4fba-831b-08d59f3916b3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1767 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.78 Subject: [Qemu-devel] [PATCH v6 7/9] i386: Add support for CPUID_8000_001E for AMD X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Populate threads/core_id/apic_ids/socket_id when CPUID_EXT3_TOPOEXT feature is supported. This is required to support hyperthreading feature on AMD CPUs. This is supported via CPUID_8000_001E extended functions. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae --- target/i386/cpu.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 63f2d31..24b39c6 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -315,6 +315,12 @@ static uint32_t encode_cache_cpuid80000005(CPUCacheInfo *cache) (((CORES_IN_CMPLX - 1) * 2) + 1) : \ (CORES_IN_CMPLX - 1)) +/* Definitions used on CPUID Leaf 0x8000001E */ +#define EXTENDED_APIC_ID(threads, socket_id, core_id, thread_id) \ + ((threads) ? \ + ((socket_id << 6) | (core_id << 1) | thread_id) : \ + ((socket_id << 6) | core_id)) + /* * Encode cache info for CPUID[0x80000006].ECX and CPUID[0x80000006].EDX * @l3 can be NULL. @@ -4098,6 +4104,14 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, break; } break; + case 0x8000001E: + assert(cpu->core_id <= 255); + *eax = EXTENDED_APIC_ID((cs->nr_threads - 1), + cpu->socket_id, cpu->core_id, cpu->thread_id); + *ebx = (cs->nr_threads - 1) << 8 | cpu->core_id; + *ecx = cpu->socket_id; + *edx = 0; + break; case 0xC0000000: *eax = env->cpuid_xlevel2; *ebx = 0;