From patchwork Tue Mar 27 05:33:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emilio Cota X-Patchwork-Id: 891386 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=braap.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=braap.org header.i=@braap.org header.b="DnwshU8F"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="QRSyzoef"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 409KXw4tybz9ry1 for ; Tue, 27 Mar 2018 16:37:52 +1100 (AEDT) Received: from localhost ([::1]:60494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0hIs-0001OV-4b for incoming@patchwork.ozlabs.org; Tue, 27 Mar 2018 01:37:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0hFI-0007P6-7b for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0hFE-0005OA-H7 for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:08 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:34275) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0hFE-0005NC-DC for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:04 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 084D52166F; Tue, 27 Mar 2018 01:34:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 27 Mar 2018 01:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=5YcU/d4ABpcpIq ueag+FhEJ/Qjg9/KEbwNMPmZhBqQ4=; b=DnwshU8FymTMjJ6vHw65YIFuJGzUG1 iAN239Icj8yQddC2wfjrHcX+2xXRkgsv+OAHtf8wDTAT0+YhGbG1sffVfdhG4PA7 rwH3gryrrjvAY3vZkzFne+pnIaVsnyFE/82itsZnQB7csZ6e59tyXYIZbsdFKX1L qXPoNDxhMIvj4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=5YcU/d4ABpcpIqueag+FhEJ/Qjg9/KEbwNMPmZhBqQ4=; b=QRSyzoef cC/IY+7k0B4nyRjjXNBOKmVuZo4DRYq0pXFch0tgX6ZuQUvZ/7hPZJQ35GPkM7yM PtTlGIO66zZ7BiWZuSBxuT+m5oNT+giZ1tMrbTVRRRSThtkjat3oeqA6mGdREW1w 62RlKlncHKRZUZQR5uk2jPs4Kr0zmXVSYDDIgb+VInl1WYIZ1aQwCquuxV7+qKHR uQMOrrzJIn4f4d/bGBvJhIeCDB21gbS4jY47VPvD+AqNX00BRNt6kiZOXyCjJFSO dYxZXAVMPmn7VF9A2z5xNdz1dM8MfkzjYHKe1OFFRgGQ6c4lL2LGAoeKfsts2C8a ajsEOHNmiy2rCg== X-ME-Sender: Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id C3214E43DF; Tue, 27 Mar 2018 01:34:03 -0400 (EDT) From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 27 Mar 2018 01:33:58 -0400 Message-Id: <1522128840-498-13-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522128840-498-1-git-send-email-cota@braap.org> References: <1522128840-498-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [PATCH v2 12/14] hardfloat: support float32/64 square root X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Mark Cave-Ayland , Richard Henderson , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Performance results for fp-bench run under aarch64-linux-user on an Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz host: - before: sqrt-single: 26.61 MFlops sqrt-double: 17.14 MFlops - after: sqrt-single: 95.06 MFlops sqrt-double: 89.05 MFlops Note that here we have a single implementation for both f32/f64. I tried the same trick we used before, but the results aren't as good: - w/ each using float32/64_is_normal or fpclassify etc.: sqrt-single: 95.50 MFlops sqrt-double: 84.55 MFlops - w/ both using fpclassify etc.: sqrt-single: 91.04 MFlops sqrt-double: 85.55 MFlops Signed-off-by: Emilio G. Cota --- fpu/softfloat.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 2dedb13..ba7289b 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -2436,20 +2436,42 @@ float16 __attribute__((flatten)) float16_sqrt(float16 a, float_status *status) return float16_round_pack_canonical(pr, status); } -float32 __attribute__((flatten)) float32_sqrt(float32 a, float_status *status) +static float32 __attribute__((flatten, noinline)) +soft_float32_sqrt(float32 a, float_status *status) { FloatParts pa = float32_unpack_canonical(a, status); FloatParts pr = sqrt_float(pa, status, &float32_params); return float32_round_pack_canonical(pr, status); } -float64 __attribute__((flatten)) float64_sqrt(float64 a, float_status *status) +static float64 __attribute__((flatten, noinline)) +soft_float64_sqrt(float64 a, float_status *status) { FloatParts pa = float64_unpack_canonical(a, status); FloatParts pr = sqrt_float(pa, status, &float64_params); return float64_round_pack_canonical(pr, status); } +#define GEN_FPU_SQRT(name, soft_t, host_t, host_sqrt_func) \ + soft_t name(soft_t a, float_status *s) \ + { \ + soft_t ## _input_flush1(&a, s); \ + if (likely((soft_t ## _is_normal(a) || soft_t ## _is_zero(a)) && \ + !soft_t ## _is_neg(a) && \ + s->float_exception_flags & float_flag_inexact && \ + s->float_rounding_mode == float_round_nearest_even)) { \ + host_t ha = soft_t ## _to_ ## host_t(a); \ + host_t hr = host_sqrt_func(ha); \ + \ + return host_t ## _to_ ## soft_t(hr); \ + } \ + return soft_ ## soft_t ## _sqrt(a, s); \ + } + +GEN_FPU_SQRT(float32_sqrt, float32, float, sqrtf) +GEN_FPU_SQRT(float64_sqrt, float64, double, sqrt) +#undef GEN_FPU_SQRT + /*---------------------------------------------------------------------------- | Takes a 64-bit fixed-point value `absZ' with binary point between bits 6