diff mbox series

[PULL,v2,21/50] Makefile: add target to print generated files

Message ID 1521515720-612046-22-git-send-email-mst@redhat.com
State New
Headers show
Series [PULL,v2,01/50] scripts/update-linux-headers: add ethtool.h and update to 4.16.0-rc4 | expand

Commit Message

Michael S. Tsirkin March 20, 2018, 3:17 a.m. UTC
This is helpful for automatic code analysis.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

Comments

Markus Armbruster April 13, 2018, 7:21 a.m. UTC | #1
"Michael S. Tsirkin" <mst@redhat.com> writes:

> This is helpful for automatic code analysis.

Out of curiosity: how?

> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 677a54b..f799390 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1045,6 +1045,9 @@ endif
>  include $(SRC_PATH)/tests/docker/Makefile.include
>  include $(SRC_PATH)/tests/vm/Makefile.include
>  
> +printgen:
> +	@echo $(GENERATED_FILES)
> +
>  .PHONY: help
>  help:
>  	@echo  'Generic targets:'

I tried to answer my question myself by looking up the thread where this
patch was posted for review.  I can't find any.  Am I blind?
Marc-André Lureau April 13, 2018, 10:04 a.m. UTC | #2
Hi

On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster <armbru@redhat.com> wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
>> This is helpful for automatic code analysis.
>
> Out of curiosity: how?
>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>  Makefile | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 677a54b..f799390 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1045,6 +1045,9 @@ endif
>>  include $(SRC_PATH)/tests/docker/Makefile.include
>>  include $(SRC_PATH)/tests/vm/Makefile.include
>>
>> +printgen:
>> +     @echo $(GENERATED_FILES)
>> +
>>  .PHONY: help
>>  help:
>>       @echo  'Generic targets:'
>
> I tried to answer my question myself by looking up the thread where this
> patch was posted for review.  I can't find any.  Am I blind?

And you could also "make print-GENERATED_FILES" already
Michael S. Tsirkin April 13, 2018, 12:51 p.m. UTC | #3
On Fri, Apr 13, 2018 at 12:04:20PM +0200, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster <armbru@redhat.com> wrote:
> > "Michael S. Tsirkin" <mst@redhat.com> writes:
> >
> >> This is helpful for automatic code analysis.
> >
> > Out of curiosity: how?
> >
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >> ---
> >>  Makefile | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index 677a54b..f799390 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -1045,6 +1045,9 @@ endif
> >>  include $(SRC_PATH)/tests/docker/Makefile.include
> >>  include $(SRC_PATH)/tests/vm/Makefile.include
> >>
> >> +printgen:
> >> +     @echo $(GENERATED_FILES)
> >> +
> >>  .PHONY: help
> >>  help:
> >>       @echo  'Generic targets:'
> >
> > I tried to answer my question myself by looking up the thread where this
> > patch was posted for review.  I can't find any.  Am I blind?

That was a development patch that sneaked in. Sorry. I'll revert.

> 
> And you could also "make print-GENERATED_FILES" already

Nice tip, thanks for that.
Markus Armbruster May 4, 2018, 5:44 a.m. UTC | #4
"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Fri, Apr 13, 2018 at 12:04:20PM +0200, Marc-André Lureau wrote:
>> Hi
>> 
>> On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster <armbru@redhat.com> wrote:
>> > "Michael S. Tsirkin" <mst@redhat.com> writes:
>> >
>> >> This is helpful for automatic code analysis.
>> >
>> > Out of curiosity: how?
>> >
>> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> >> ---
>> >>  Makefile | 3 +++
>> >>  1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/Makefile b/Makefile
>> >> index 677a54b..f799390 100644
>> >> --- a/Makefile
>> >> +++ b/Makefile
>> >> @@ -1045,6 +1045,9 @@ endif
>> >>  include $(SRC_PATH)/tests/docker/Makefile.include
>> >>  include $(SRC_PATH)/tests/vm/Makefile.include
>> >>
>> >> +printgen:
>> >> +     @echo $(GENERATED_FILES)
>> >> +
>> >>  .PHONY: help
>> >>  help:
>> >>       @echo  'Generic targets:'
>> >
>> > I tried to answer my question myself by looking up the thread where this
>> > patch was posted for review.  I can't find any.  Am I blind?
>
> That was a development patch that sneaked in. Sorry. I'll revert.

Since you haven't, I took the liberty to post the revert myself.

>> And you could also "make print-GENERATED_FILES" already
>
> Nice tip, thanks for that.
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 677a54b..f799390 100644
--- a/Makefile
+++ b/Makefile
@@ -1045,6 +1045,9 @@  endif
 include $(SRC_PATH)/tests/docker/Makefile.include
 include $(SRC_PATH)/tests/vm/Makefile.include
 
+printgen:
+	@echo $(GENERATED_FILES)
+
 .PHONY: help
 help:
 	@echo  'Generic targets:'