From patchwork Tue Mar 6 20:56:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Clark X-Patchwork-Id: 882277 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="WqlDNAOe"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zwqry1b38z9sWj for ; Wed, 7 Mar 2018 08:38:26 +1100 (AEDT) Received: from localhost ([::1]:58394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etKHw-0002pf-9L for incoming@patchwork.ozlabs.org; Tue, 06 Mar 2018 16:38:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etJfE-0000cy-M8 for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:58:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etJfD-0002rY-Ui for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:58:24 -0500 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]:34595) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etJfD-0002rU-Oi for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:58:23 -0500 Received: by mail-pl0-x244.google.com with SMTP id u13-v6so15557plq.1 for ; Tue, 06 Mar 2018 12:58:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z+L42yDG8RKhwSmiSbpuiCsehanEf+avlrfl/8UVfAM=; b=WqlDNAOe2fDx4L2yvbSPXJL4YDq9LItGWbrWfk4B5gdIWcutaY+Xyi4U071EPYIaWV BZ05vhoBjKAQqUIUGfRyRofDSYxA4nD9cdfNL3jCCNV4gqkXaK1pehECzioMVRj+Gz+q gGimLhr+hgbrWMVfpGGkWu+1ZlpwI9kr49tEbN80ymzjzVA5KK5HapTfLyv3K1q54iFT XDZ59sQ1dOw4myy26LleK94WOmEnAwct5BF8IzhfH0YOyo5sN3Ed2ndUkGvLs9C+saju N/mUuE8jcaL+RmVGPx+RCgVbEJ0dC5NHHDprkuMTWvNRsIyKAfW41IJZW46iZQ4Tw2XT JSuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z+L42yDG8RKhwSmiSbpuiCsehanEf+avlrfl/8UVfAM=; b=uMj1MPgeo9QBPz/yHoeT5TC7wp2u9EwijAP6UqwgjxEFmTxV3tcZPrgn24QNUfjwDR o6TdV61NhTVuZvCC+4KQHr8rJEMfOO/DZp4yL033Z+R8qh2JYC2FymW0oOfhx8GVzAid LB3yl1nKo8D4ZPG5zkY1q/ZU3zMKxYdQcRBjlGQjKb7kKdtVNqFDwkIzKfUqWsZ+IKWD U5J51O/4a6z6j/9VtSX91K3md5pzbgYl2wznmfIxI+T77NN/IwpsSlTK6w/d34nsaOm9 Gr2cQ7/U3D9boEEn5LqP7wrDsIU7dkTDqgch/HVNcIGuZgwqjecgo6QYtvQDM7Ko1NYw lEew== X-Gm-Message-State: APf1xPA2i9g3jISGsfybpyXWW+Em5TR4vlk5O0rbi9cUJPhNaMKrpyg+ 0krQkvtp+YpSVNthRsdXn7uAg+f2oF4= X-Google-Smtp-Source: AG47ELvCk5AjqnxymM+P+SuRGZ1s8LvDd7nX1PWCoc8hD06elCBv2hN5Hg0v5D1xfrq7DVFTZ7w2bQ== X-Received: by 2002:a17:902:ab84:: with SMTP id f4-v6mr18241940plr.239.1520369902737; Tue, 06 Mar 2018 12:58:22 -0800 (PST) Received: from localhost.localdomain (125-237-39-90-fibre.bb.spark.co.nz. [125.237.39.90]) by smtp.gmail.com with ESMTPSA id l129sm27074346pfl.82.2018.03.06.12.58.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Mar 2018 12:58:22 -0800 (PST) From: Michael Clark To: qemu-devel@nongnu.org Date: Wed, 7 Mar 2018 09:56:23 +1300 Message-Id: <1520369790-38306-14-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1520369790-38306-1-git-send-email-mjc@sifive.com> References: <1520369790-38306-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::244 Subject: [Qemu-devel] [PATCH v1 15/22] RISC-V: Use memory_region_is_ram in pte update X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Michael Clark , Palmer Dabbelt , Sagar Karandikar , RISC-V Patches Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" After reading cpu_physical_memory_write and friends, it seems that memory_region_is_ram is a more appropriate interface, and matches the intent of the code that is calling it. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/helper.c b/target/riscv/helper.c index 2165ecb..88551be 100644 --- a/target/riscv/helper.c +++ b/target/riscv/helper.c @@ -235,7 +235,7 @@ restart: rcu_read_lock(); mr = address_space_translate(cs->as, pte_addr, &addr1, &l, false); - if (memory_access_is_direct(mr, true)) { + if (memory_region_is_ram(mr)) { target_ulong *pte_pa = qemu_map_ram_ptr(mr->ram_block, addr1); #if TCG_OVERSIZED_GUEST