| Message ID | 1513877118-3149-3-git-send-email-jack.schwartz@oracle.com |
|---|---|
| State | New |
| Headers | show |
| Series | [QEMU,v1,1/4] multiboot: bss_end_addr can be zero | expand |
+-- On Thu, 21 Dec 2017, Jack Schwartz wrote --+
| Remove unused variables: mh_mode_type, mh_width, mh_height, mh_depth
|
| Signed-off-by: Jack Schwartz <jack.schwartz@oracle.com>
| Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
| ---
| hw/i386/multiboot.c | 6 ------
| 1 file changed, 6 deletions(-)
|
| diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
| index ff2733d..964feaf 100644
| --- a/hw/i386/multiboot.c
| +++ b/hw/i386/multiboot.c
| @@ -255,12 +255,6 @@ int load_multiboot(FWCfgState *fw_cfg,
| mb_kernel_size = mb_load_size;
| }
|
| - /* Valid if mh_flags sets MULTIBOOT_HEADER_HAS_VBE.
| - uint32_t mh_mode_type = ldl_p(header+i+32);
| - uint32_t mh_width = ldl_p(header+i+36);
| - uint32_t mh_height = ldl_p(header+i+40);
| - uint32_t mh_depth = ldl_p(header+i+44); */
| -
+1 They are anyway comments.
Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index ff2733d..964feaf 100644 --- a/hw/i386/multiboot.c +++ b/hw/i386/multiboot.c @@ -255,12 +255,6 @@ int load_multiboot(FWCfgState *fw_cfg, mb_kernel_size = mb_load_size; } - /* Valid if mh_flags sets MULTIBOOT_HEADER_HAS_VBE. - uint32_t mh_mode_type = ldl_p(header+i+32); - uint32_t mh_width = ldl_p(header+i+36); - uint32_t mh_height = ldl_p(header+i+40); - uint32_t mh_depth = ldl_p(header+i+44); */ - mb_debug("multiboot: mh_header_addr = %#x\n", mh_header_addr); mb_debug("multiboot: mh_load_addr = %#x\n", mh_load_addr); mb_debug("multiboot: mh_load_end_addr = %#x\n", mh_load_end_addr);