From patchwork Wed Oct 18 16:12:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 827727 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Zqehz8v5"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yHHTT3QZNz9sBd for ; Thu, 19 Oct 2017 03:25:01 +1100 (AEDT) Received: from localhost ([::1]:45498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4r9P-00049Y-7o for incoming@patchwork.ozlabs.org; Wed, 18 Oct 2017 12:24:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4qyG-0003gq-31 for qemu-devel@nongnu.org; Wed, 18 Oct 2017 12:13:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4qyC-0002Hf-5o for qemu-devel@nongnu.org; Wed, 18 Oct 2017 12:13:28 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:48423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4qyB-0002H0-Ut for qemu-devel@nongnu.org; Wed, 18 Oct 2017 12:13:24 -0400 Received: by mail-wm0-x243.google.com with SMTP id i124so10878405wmf.3 for ; Wed, 18 Oct 2017 09:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=lEeh+L3dg10p3y+9Itnphsu+fDCIsvCXUyVlDEImqa4=; b=Zqehz8v5DRoEzY6OOQhCBQWw9AY+JjOVmUbBMht2fxOhq9ecroUe38fgvqD2IaR+k1 mbV09BHWHVBPk82lj7cZYyezvtrh050f1dFW+xSOF/wbpYqAojsZZR1DiUDoW28F8ats AhKP9/OGLUgTSaYsPkeCiQ86571F5yIFMiStTr8WzmHBg3ghmL1hkUeFNBFq68jQgkKN BjH6JezoVsaoGGIazf6s2EF/hvCR3DpaaRZCxm4ZGBYnk8tEnJpOElA7BXN+bqMQhTmc nnu/ZS7KLp7amMvr7arqTNDjV4GYqObl1/y6UmfN7RjC6h9DO87J62JnsbBgFieMOJrW VqGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=lEeh+L3dg10p3y+9Itnphsu+fDCIsvCXUyVlDEImqa4=; b=AvdBxdNdh8xqbk/AmkvSGNqfKTYPn/wGHxllZ5JR6KS5PGLvY4KzZ2D9SDq3qqby2a +5AYgBXnO6IIANyKTWlj1ZmAwdULfSXLcohgK2rk8cJSjYCOjOR8hSdiaFtXoueUN7Br 2mbOvDYvhKdWc+bGk6TTi75D+cBVpGup3OpFd/R+aNQ/ODmpOpvFewl13cw817dNMFOS RnTZtAcYODil7RCXJVE2ZZiXPvNcBMImv/D2ay9xNL/juxA8So40BAPN10bQfLPzgFZ6 Wg6NOVQF3fk5b7Bny2av/zxhzgoLvHjsJZPgOxIC2beFfCLeN7fR3mdUhZWKA6pJEKkb 6gng== X-Gm-Message-State: AMCzsaXa4vFljUkLBLEbmk7Iy+Wo88s5a5Dv+L7JwTtrBXen4H2uW8/x GR130tHsfoBMw+FGJlVF8Gd6f27x X-Google-Smtp-Source: ABhQp+TjEL+hzvBPWVUQVr4/hIApr+nNlSN9UAkavMJ56y+gbge5YTM+Fs09VU1N45YEtWBykqXY2A== X-Received: by 10.28.97.194 with SMTP id v185mr7315194wmb.117.1508343202712; Wed, 18 Oct 2017 09:13:22 -0700 (PDT) Received: from 640k.lan (94-39-155-245.adsl-ull.clienti.tiscali.it. [94.39.155.245]) by smtp.gmail.com with ESMTPSA id 69sm13436794wmm.2.2017.10.18.09.13.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2017 09:13:22 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 18 Oct 2017 18:12:12 +0200 Message-Id: <1508343141-31835-21-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1508343141-31835-1-git-send-email-pbonzini@redhat.com> References: <1508343141-31835-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 20/29] kvm: region_add and region_del is not called on updates X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: David Hildenbrand Attributes are not updated via region_add()/region_del(). Attribute changes lead to a delete first, followed by a new add. If this would ever not be the case, we would get an error when trying to register the new slot. Signed-off-by: David Hildenbrand Message-Id: <20171016144302.24284-6-david@redhat.com> Tested-by: Joe Clifford Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 559c544..2835bb3 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -721,8 +721,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml, ram = memory_region_get_ram_ptr(mr) + section->offset_within_region + (start_addr - section->offset_within_address_space); - mem = kvm_lookup_matching_slot(kml, start_addr, size); if (!add) { + mem = kvm_lookup_matching_slot(kml, start_addr, size); if (!mem) { return; } @@ -741,12 +741,6 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml, return; } - if (mem) { - /* update the slot */ - kvm_slot_update_flags(kml, mem, mr); - return; - } - /* register the new slot */ mem = kvm_alloc_slot(kml); mem->memory_size = size;