From patchwork Wed Oct 18 16:12:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 827736 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YTxOrsTK"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yHHZ06GKpz9t5q for ; Thu, 19 Oct 2017 03:28:56 +1100 (AEDT) Received: from localhost ([::1]:45524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4rDC-0001ob-VH for incoming@patchwork.ozlabs.org; Wed, 18 Oct 2017 12:28:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4qyA-0003aw-Rp for qemu-devel@nongnu.org; Wed, 18 Oct 2017 12:13:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4qy9-0002Fd-QE for qemu-devel@nongnu.org; Wed, 18 Oct 2017 12:13:22 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:45112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4qy9-0002F5-KF for qemu-devel@nongnu.org; Wed, 18 Oct 2017 12:13:21 -0400 Received: by mail-wr0-x241.google.com with SMTP id k7so5596060wre.2 for ; Wed, 18 Oct 2017 09:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=7Zij4P9FSMz57ob2a+YZ+pioRBJdgcj+btZWJa04WOM=; b=YTxOrsTK4Kzy8yfK8CW+gx/ckPBu54SD+QUmq7tYfriKw1aakJG7TmeGt8LOsZeIZY MY4EwyFaNS4RW64BCTwAKY5XL/ya/9aTriS5TWKlRy0dIHMjEh7xuuocLY6BAhQ+NmaB p9cKABAg8x0+tW19b+OjgPA9VDksN85uXJCwCkQGS7JaH+Rq49ZYEwoRNOT7j+ewqeC0 ph7zKYFL/SEpwJPNusjJ+FPVyUnEinJxQK+q+4UaX/JhNAJpY+Jp+emenCRy8Aai3/H7 oeCGP2hUVpxqf6AGSrW5kJD2AJatZMrBw0OJzC2oDVZ8zAcbXr7+8V/LQZhQr6Rbj/ib tcEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=7Zij4P9FSMz57ob2a+YZ+pioRBJdgcj+btZWJa04WOM=; b=ivwGrTyxx/OxgFdZTxwWLtCRS7j0wJrpwCNDcV/fitGxMI3HX/DgOi8kUAx+h+QpxH FezxdWsmU6Bn8RkCbsO4IyO4gEbDxILLyv4rOxZNsYxwcAmtDoaKbr9OQbb7bjxgei2r cQx6j2fW5bhcK6NZnmsYRDm91WQScyVV4ri+tymTDa43dC2YLgHHorP04caBZGLWy6Z8 CHqraMP7dvf5ddIZY64b0MtgrcjZZdb+KwuOGtafOmDxzge8OMOJ1Nm8NIpkM7WAvzXA p48Y2QAr6a7DHXikSaGl6NUdla6SUyCM2oK7ZpSgemMaMESvohbZtBgPYqmY/IzDbOrP MNOQ== X-Gm-Message-State: AMCzsaXSEQA1/6hjypZuJakg2FpMCLiSj7OdX10+dbyhqeVPRQqPE8zw pWutstn0+rDQPfnUdjqHv7eOGB7X X-Google-Smtp-Source: ABhQp+QcSln339LbbxEmrVzEmRvyxbpDcKPwI2vKUYJY1RP9zUWTcIhJj+qrr8vpzBgCc4DJTE2uIg== X-Received: by 10.223.135.143 with SMTP id b15mr8093489wrb.24.1508343200447; Wed, 18 Oct 2017 09:13:20 -0700 (PDT) Received: from 640k.lan (94-39-155-245.adsl-ull.clienti.tiscali.it. [94.39.155.245]) by smtp.gmail.com with ESMTPSA id 69sm13436794wmm.2.2017.10.18.09.13.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2017 09:13:19 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 18 Oct 2017 18:12:10 +0200 Message-Id: <1508343141-31835-19-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1508343141-31835-1-git-send-email-pbonzini@redhat.com> References: <1508343141-31835-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 18/29] kvm: tolerate non-existing slot for log_start/log_stop/log_sync X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: David Hildenbrand If we want to trap every access to a section, we might not have a slot. So let's just tolerate if we don't have one. Signed-off-by: David Hildenbrand Message-Id: <20171016144302.24284-4-david@redhat.com> Tested-by: Joe Clifford Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index fae1eca..f5fa3e2 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -394,8 +394,8 @@ static int kvm_section_update_flags(KVMMemoryListener *kml, mem = kvm_lookup_matching_slot(kml, start_addr, size); if (!mem) { - fprintf(stderr, "%s: error finding slot\n", __func__); - abort(); + /* We don't have a slot if we want to trap every access. */ + return 0; } return kvm_slot_update_flags(kml, mem, section->mr); @@ -470,8 +470,8 @@ static int kvm_physical_sync_dirty_bitmap(KVMMemoryListener *kml, if (size) { mem = kvm_lookup_matching_slot(kml, start_addr, size); if (!mem) { - fprintf(stderr, "%s: error finding slot\n", __func__); - abort(); + /* We don't have a slot if we want to trap every access. */ + return 0; } /* XXX bad kernel interface alert