diff mbox

[v3,04/13] block: support BDRV_REQ_ALLOCATE in passthrough drivers

Message ID 1501518125-29851-5-git-send-email-anton.nefedov@virtuozzo.com
State New
Headers show

Commit Message

Anton Nefedov July 31, 2017, 4:21 p.m. UTC 
Support the flag if the underlying BDS supports it

Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
---
 block/blkdebug.c   | 3 ++-
 block/raw-format.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Eric Blake July 31, 2017, 7:11 p.m. UTC | #1 
On 07/31/2017 11:21 AM, Anton Nefedov wrote:
> Support the flag if the underlying BDS supports it
> 
> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
> ---
>  block/blkdebug.c   | 3 ++-
>  block/raw-format.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)

What about blkverify, commit, and mirror?  Should they also pass through
various flags?
Anton Nefedov Aug. 1, 2017, 12:58 p.m. UTC | #2 
On 07/31/2017 10:11 PM, Eric Blake wrote:
> On 07/31/2017 11:21 AM, Anton Nefedov wrote:
>> Support the flag if the underlying BDS supports it
>>
>> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
>> ---
>>   block/blkdebug.c   | 3 ++-
>>   block/raw-format.c | 3 ++-
>>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> What about blkverify, commit, and mirror?  Should they also pass through
> various flags?
> 

looks like commit is read-only, but blkverify and mirror probably
should, will try to fix that

/Anton
diff mbox

Patch

diff --git a/block/blkdebug.c b/block/blkdebug.c
index c19ab28..ef2d764 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -414,7 +414,8 @@  static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,
 
     bs->supported_write_flags = BDRV_REQ_FUA &
         bs->file->bs->supported_write_flags;
-    bs->supported_zero_flags = (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) &
+    bs->supported_zero_flags =
+        (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_ALLOCATE) &
         bs->file->bs->supported_zero_flags;
     ret = -EINVAL;
 
diff --git a/block/raw-format.c b/block/raw-format.c
index 142649e..fc97a7d 100644
--- a/block/raw-format.c
+++ b/block/raw-format.c
@@ -421,7 +421,8 @@  static int raw_open(BlockDriverState *bs, QDict *options, int flags,
     bs->sg = bs->file->bs->sg;
     bs->supported_write_flags = BDRV_REQ_FUA &
         bs->file->bs->supported_write_flags;
-    bs->supported_zero_flags = (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) &
+    bs->supported_zero_flags =
+        (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_ALLOCATE) &
         bs->file->bs->supported_zero_flags;
 
     if (bs->probed && !bdrv_is_read_only(bs)) {