From patchwork Thu Jun 29 15:10:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pradeep Jagadeesh X-Patchwork-Id: 782325 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wz36f0MP4z9s65 for ; Fri, 30 Jun 2017 01:12:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Bj8W1sHB"; dkim-atps=neutral Received: from localhost ([::1]:39908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQb71-0008Up-JB for incoming@patchwork.ozlabs.org; Thu, 29 Jun 2017 11:12:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQb6U-0008UJ-61 for qemu-devel@nongnu.org; Thu, 29 Jun 2017 11:11:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQb6T-00031m-Bs for qemu-devel@nongnu.org; Thu, 29 Jun 2017 11:11:34 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:35217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQb6T-00031J-5H for qemu-devel@nongnu.org; Thu, 29 Jun 2017 11:11:33 -0400 Received: by mail-wr0-x243.google.com with SMTP id z45so37152609wrb.2 for ; Thu, 29 Jun 2017 08:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=b0j2aqACV0F/bDUZFvl4Iwm6udA7ciTOVx6nuwB52+M=; b=Bj8W1sHBXGdA7bf9bQKFUGQmuJ0qFSB3Ftic66EjsTXyzZajo4gbk9so4/YnFDMMN8 tslfms+FkCkNDaQs/l49BFOJl+NWMWAc3u17ZgLKcScMOgnxb0h+rnB0qm5RRcH2xtup 1C/W+6J7Yjcn4Nq/ZHs4Y0lPsE4ILk3SD4yB/zGqhluD8LaQq0CzJdEycYkPxGvxL959 pYCvSRQ9jRaGogLv0Tqjwy40kH2DCqQ91iQQtXGFPETnl9Hy4d2T1jzcGouPggFV7AYq Z+oHM30k+ElWWwDbr1SnPZ/ERMrnQSdUnbjaQs5i/GA02tO9kYY9i7oGEQOB/9C75pAS 2cPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=b0j2aqACV0F/bDUZFvl4Iwm6udA7ciTOVx6nuwB52+M=; b=s9U0osDndV6OnCNkJqyOTNowEVD3Fnf4Pbss6+Y0DITsbo1lfiyzPgwahXmdmubwb2 EB4msA/zdLk9zBZPqrfzwvknuokbRsrqytP8zkkwn9DrS0rE8ItVGIIbyYm7PazRKyG6 Cb1+k2SoyWTGngticjBq7HWg0Ld5lJEUgeg50Ve94FEzfm3orrGFJgHQEkkDVwrXOccX rk0KQmWNxGhE3mbvl+VqZzndh/vXZPaoDm+ysE93KEyZ1fMPJclEoq/yX8PFzvAiadf8 5/3XxXQk064OtucfBs0c09YYqvUkvDWqnvjCHBLt+OHZZATkWsCw37bZPChXs9a82WGt GXQQ== X-Gm-Message-State: AKS2vOym7hHeGFnlS/jhJBj4lcDqjA+FC0/MGqRlTMYGKnOghgpzaiJU MHPUoR3Dd3k9Zg== X-Received: by 10.223.168.48 with SMTP id l45mr23841522wrc.94.1498749092269; Thu, 29 Jun 2017 08:11:32 -0700 (PDT) Received: from localhost.localdomain.localdomain ([217.110.131.66]) by smtp.gmail.com with ESMTPSA id r142sm1679641wmg.24.2017.06.29.08.11.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jun 2017 08:11:31 -0700 (PDT) From: Pradeep Jagadeesh X-Google-Original-From: Pradeep Jagadeesh To: "eric blake" , "greg kurz" Date: Thu, 29 Jun 2017 11:10:54 -0400 Message-Id: <1498749056-38565-5-git-send-email-pradeep.jagadeesh@huawei.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1498749056-38565-1-git-send-email-pradeep.jagadeesh@huawei.com> References: <1498749056-38565-1-git-send-email-pradeep.jagadeesh@huawei.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PATCH v6 4/6] hmp: create a throttle initialization function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, jani kokkonen , alberto garcia , Pradeep Jagadeesh , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh Acked-by: Dr. David Alan Gilbert --- hmp.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/hmp.c b/hmp.c index 8c72c58..220d301 100644 --- a/hmp.c +++ b/hmp.c @@ -1749,20 +1749,29 @@ void hmp_change(Monitor *mon, const QDict *qdict) hmp_handle_error(mon, &err); } +static void hmp_initialize_io_throttle(IOThrottle *iot, const QDict *qdict) +{ + iot->has_id = true; + iot->id = (char *) qdict_get_str(qdict, "id"); + iot->bps = qdict_get_int(qdict, "bps"); + iot->bps_rd = qdict_get_int(qdict, "bps_rd"); + iot->bps_wr = qdict_get_int(qdict, "bps_wr"); + iot->iops = qdict_get_int(qdict, "iops"); + iot->iops_rd = qdict_get_int(qdict, "iops_rd"); + iot->iops_wr = qdict_get_int(qdict, "iops_wr"); +} + void hmp_block_set_io_throttle(Monitor *mon, const QDict *qdict) { Error *err = NULL; + IOThrottle *iothrottle; BlockIOThrottle throttle = { .has_device = true, .device = (char *) qdict_get_str(qdict, "device"), - .bps = qdict_get_int(qdict, "bps"), - .bps_rd = qdict_get_int(qdict, "bps_rd"), - .bps_wr = qdict_get_int(qdict, "bps_wr"), - .iops = qdict_get_int(qdict, "iops"), - .iops_rd = qdict_get_int(qdict, "iops_rd"), - .iops_wr = qdict_get_int(qdict, "iops_wr"), }; + iothrottle = qapi_BlockIOThrottle_base(&throttle); + hmp_initialize_io_throttle(iothrottle, qdict); qmp_block_set_io_throttle(&throttle, &err); hmp_handle_error(mon, &err); }