From patchwork Fri Jun 9 02:25:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Emilio Cota X-Patchwork-Id: 773591 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wkRCM15Wbz9s5L for ; Fri, 9 Jun 2017 12:32:31 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=braap.org header.i=@braap.org header.b="xPVRXdB9"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="cWnRf48x"; dkim-atps=neutral Received: from localhost ([::1]:52322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ9iu-0005UL-Rd for incoming@patchwork.ozlabs.org; Thu, 08 Jun 2017 22:32:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ9cC-0000Y2-4B for qemu-devel@nongnu.org; Thu, 08 Jun 2017 22:25:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJ9c8-000695-T9 for qemu-devel@nongnu.org; Thu, 08 Jun 2017 22:25:32 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59673) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dJ9c8-00068K-DL for qemu-devel@nongnu.org; Thu, 08 Jun 2017 22:25:28 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2E54A209CE; Thu, 8 Jun 2017 22:25:26 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Thu, 08 Jun 2017 22:25:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=IlpZopltHkbwra9 zEZjlzFOsy2QlB/n5x/BVUr9S8UU=; b=xPVRXdB9HGoDKCOn/5h64hltQwtYZ9P xhwd1XgnbG9z4ZUGZ4LTnxq7fk+zTpSLYlsrir+J/LaiWMvBQBA9NtBEv1Tw4OAu xs5pGK/YG6aeqmTVt29PJm2ZzyfGIyL2V+UHIxlUNsTwvqfGe2JFaPKpSh0/BZzx D1/xdyIGbaVw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=IlpZopltHkbwra9zEZjlzFOsy2QlB/n5x/BVUr9S8UU=; b=cWnRf48x PUmgyJWxUYqO+o53vQRp9NvhqvN2EtCyy+kVdHBGiGCMZw0oTmQI5kQK5jnz83e5 /AjoO7/6pOgal6DQIpSHKf6ZlpMTFCYghdOxxONiIuExZhyJn4RQ60vG73NYjWFv o+a2epqyJhlQh8aceEpM/hA0fjVyVr/WTbtJ/33KBWNA2XTiqmlIh6dnEYlE1K2u f90Ta2Be9nFeU6UCEf331BJ7Wb2de4DzJZmrEYSwHD/v5iyBhSOJdYMAe8vXrdXp EgGZEKuV6DJfk9tOPLBevO76rzhoO+Q9RS/Y6uDSkQCmmOodi7TUdmSSMUcY0+FH sGTNJB9+YGmXaA== X-ME-Sender: X-Sasl-enc: l8YOhf/7YX1Hyz/DhA/uNXYzNnMwbrCB/N6QSk7/fYRU 1496975126 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id F40C17E7EE; Thu, 8 Jun 2017 22:25:25 -0400 (EDT) From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Thu, 8 Jun 2017 22:25:16 -0400 Message-Id: <1496975122-16999-2-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1496975122-16999-1-git-send-email-cota@braap.org> References: <1496975122-16999-1-git-send-email-cota@braap.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 Subject: [Qemu-devel] [PATCH v8 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Llu=C3=ADs=20Vilanova?= , Stefan Hajnoczi , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Lluís Vilanova The function is reused in later patches. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- cputlb.c | 2 +- include/exec/exec-all.h | 6 ++++++ translate-all.c | 15 ++++++++++----- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/cputlb.c b/cputlb.c index 743776a..6a2b762 100644 --- a/cputlb.c +++ b/cputlb.c @@ -118,7 +118,7 @@ static void tlb_flush_nocheck(CPUState *cpu) memset(env->tlb_table, -1, sizeof(env->tlb_table)); memset(env->tlb_v_table, -1, sizeof(env->tlb_v_table)); - memset(cpu->tb_jmp_cache, 0, sizeof(cpu->tb_jmp_cache)); + tb_flush_jmp_cache_all(cpu); env->vtlb_index = 0; env->tlb_flush_addr = -1; diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 724ec73..b0281b0 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -366,6 +366,12 @@ struct TranslationBlock { }; void tb_free(TranslationBlock *tb); +/** + * tb_flush_jmp_cache_all: + * + * Flush the virtual translation block cache. + */ +void tb_flush_jmp_cache_all(CPUState *env); void tb_flush(CPUState *cpu); void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr); TranslationBlock *tb_htable_lookup(CPUState *cpu, target_ulong pc, diff --git a/translate-all.c b/translate-all.c index 966747a..8a5dc19 100644 --- a/translate-all.c +++ b/translate-all.c @@ -931,11 +931,7 @@ static void do_tb_flush(CPUState *cpu, run_on_cpu_data tb_flush_count) } CPU_FOREACH(cpu) { - int i; - - for (i = 0; i < TB_JMP_CACHE_SIZE; ++i) { - atomic_set(&cpu->tb_jmp_cache[i], NULL); - } + tb_flush_jmp_cache_all(cpu); } tcg_ctx.tb_ctx.nb_tbs = 0; @@ -1733,6 +1729,15 @@ void tb_check_watchpoint(CPUState *cpu) } } +void tb_flush_jmp_cache_all(CPUState *cpu) +{ + int i; + + for (i = 0; i < TB_JMP_CACHE_SIZE; ++i) { + atomic_set(&cpu->tb_jmp_cache[i], NULL); + } +} + #ifndef CONFIG_USER_ONLY /* in deterministic execution mode, instructions doing device I/Os * must be at the end of the TB.