From patchwork Mon May 15 08:50:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 762319 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wRDrQ327nz9s0m for ; Mon, 15 May 2017 18:53:26 +1000 (AEST) Received: from localhost ([::1]:35458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dABkq-0005CL-2Q for incoming@patchwork.ozlabs.org; Mon, 15 May 2017 04:53:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dABio-0003pI-Tl for qemu-devel@nongnu.org; Mon, 15 May 2017 04:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dABio-0005Yx-3e for qemu-devel@nongnu.org; Mon, 15 May 2017 04:51:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33748) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dABin-0005Yg-V8 for qemu-devel@nongnu.org; Mon, 15 May 2017 04:51:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0A00C0467CB; Mon, 15 May 2017 08:51:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F0A00C0467CB Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=peterx@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F0A00C0467CB Received: from pxdev.xzpeter.org.com (vpn1-5-116.pek2.redhat.com [10.72.5.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC7985C888; Mon, 15 May 2017 08:51:13 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 15 May 2017 16:50:58 +0800 Message-Id: <1494838260-30439-3-git-send-email-peterx@redhat.com> In-Reply-To: <1494838260-30439-1-git-send-email-peterx@redhat.com> References: <1494838260-30439-1-git-send-email-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 15 May 2017 08:51:17 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Jason Wang , "Michael S . Tsirkin" , peterx@redhat.com, David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" It is not easy for people to know "what this parameter does" before knowing "what is subpage". Let's use "is_mmio" to make it easier to understand. Signed-off-by: Peter Xu --- exec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index 1d76c63..0adae94 100644 --- a/exec.c +++ b/exec.c @@ -403,7 +403,7 @@ bool memory_region_is_unassigned(MemoryRegion *mr) /* Called from RCU critical section */ static MemoryRegionSection *address_space_lookup_region(AddressSpaceDispatch *d, hwaddr addr, - bool resolve_subpage) + bool is_mmio) { MemoryRegionSection *section = atomic_read(&d->mru_section); subpage_t *subpage; @@ -416,7 +416,7 @@ static MemoryRegionSection *address_space_lookup_region(AddressSpaceDispatch *d, section = phys_page_find(d, addr); update = true; } - if (resolve_subpage && section->mr->subpage) { + if (is_mmio && section->mr->subpage) { subpage = container_of(section->mr, subpage_t, iomem); section = &d->map.sections[subpage->sub_section[SUBPAGE_IDX(addr)]]; } @@ -429,13 +429,13 @@ static MemoryRegionSection *address_space_lookup_region(AddressSpaceDispatch *d, /* Called from RCU critical section */ static MemoryRegionSection * address_space_translate_internal(AddressSpaceDispatch *d, hwaddr addr, hwaddr *xlat, - hwaddr *plen, bool resolve_subpage) + hwaddr *plen, bool is_mmio) { MemoryRegionSection *section; MemoryRegion *mr; Int128 diff; - section = address_space_lookup_region(d, addr, resolve_subpage); + section = address_space_lookup_region(d, addr, is_mmio); /* Compute offset within MemoryRegionSection */ addr -= section->offset_within_address_space;