diff mbox

Add 'none' as type for drive's if option

Message ID 1489765795-32398-1-git-send-email-craig@rancher.com
State New
Headers show

Commit Message

Craig Jellick March 17, 2017, 3:49 p.m. UTC
Signed-off-by: Craig Jellick <craig@rancher.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Hajnoczi March 20, 2017, 2:23 p.m. UTC | #1
On Fri, Mar 17, 2017 at 08:49:55AM -0700, Craig Jellick wrote:
> Signed-off-by: Craig Jellick <craig@rancher.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Markus Armbruster April 11, 2017, 1:17 p.m. UTC | #2
Perhaps this can go via qemu-trivial.

Craig Jellick <craig@rancher.com> writes:

> Signed-off-by: Craig Jellick <craig@rancher.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 99af8ed..8291e64 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -591,7 +591,7 @@ Special files such as iSCSI devices can be specified using protocol
>  specific URLs. See the section for "Device URL Syntax" for more information.
>  @item if=@var{interface}
>  This option defines on which type on interface the drive is connected.
> -Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio.
> +Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio, none.
>  @item bus=@var{bus},unit=@var{unit}
>  These options define where is connected the drive by defining the bus number and
>  the unit id.
Craig Jellick April 12, 2017, 4:02 p.m. UTC | #3
Is there an action I need to take for that?
Markus Armbruster April 13, 2017, 7:11 a.m. UTC | #4
Craig Jellick <craig@rancher.com> writes:

> Is there an action I need to take for that?

Fair question.

Expect e-mail from a qemu-trivial maintainer that your patch has been
merged.  If you don't get one within a reasonable time frame, we failed
you.  Send a reminder as a reply to this message then.

I figure one week after 2.10 opens would be reasonable.  It's expected
to open in a week.

Thanks!
Michael Tokarev April 22, 2017, 6:01 p.m. UTC | #5
17.03.2017 18:49, Craig Jellick wrote:
>  qemu-options.hx | 2 +-

Applied to -trivial, thank you!

/mjt
diff mbox

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index 99af8ed..8291e64 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -591,7 +591,7 @@  Special files such as iSCSI devices can be specified using protocol
 specific URLs. See the section for "Device URL Syntax" for more information.
 @item if=@var{interface}
 This option defines on which type on interface the drive is connected.
-Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio.
+Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio, none.
 @item bus=@var{bus},unit=@var{unit}
 These options define where is connected the drive by defining the bus number and
 the unit id.