From patchwork Wed Mar 8 20:51:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brijesh Singh X-Patchwork-Id: 736719 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vdmlv6Sn1z9sCX for ; Thu, 9 Mar 2017 08:25:47 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="uTURmsOx"; dkim-atps=neutral Received: from localhost ([::1]:58515 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clj5d-0005GZ-My for incoming@patchwork.ozlabs.org; Wed, 08 Mar 2017 16:25:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clj4y-0005Dg-7R for qemu-devel@nongnu.org; Wed, 08 Mar 2017 16:25:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clj4u-0005G5-Tl for qemu-devel@nongnu.org; Wed, 08 Mar 2017 16:25:04 -0500 Received: from mail-sn1nam02on0080.outbound.protection.outlook.com ([104.47.36.80]:16320 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clj4u-0005Fm-ID for qemu-devel@nongnu.org; Wed, 08 Mar 2017 16:25:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+yq3WFOqQZRV+usvOQ/JjAsF+kGm69BdjFzhqZ9ceKk=; b=uTURmsOx5ucLwBOeylvl0BKirRkgAbNprL3/BUV0y3mwbfjpgzfhiMtUXILMJeC9myGwN4nvPgxnztHg3O1AZg5K6aB10lGU6xRxRMdWSxBSwgV/ansBAqOMBY5vZd0EA5cxe5f6XzgYo/xbLxZqqFst/OJGB8MgUyRzPPNRJf4= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from [127.0.1.1] (165.204.77.1) by DM5PR12MB1612.namprd12.prod.outlook.com (10.172.40.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Wed, 8 Mar 2017 20:52:02 +0000 From: Brijesh Singh To: , , , , , , , , Date: Wed, 8 Mar 2017 15:51:59 -0500 Message-ID: <148900631908.27090.16339695025371616457.stgit@brijesh-build-machine> In-Reply-To: <148900626714.27090.1616990932333159904.stgit@brijesh-build-machine> References: <148900626714.27090.1616990932333159904.stgit@brijesh-build-machine> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR21CA0006.namprd21.prod.outlook.com (10.173.47.16) To DM5PR12MB1612.namprd12.prod.outlook.com (10.172.40.18) X-MS-Office365-Filtering-Correlation-Id: f62625be-92b1-4c55-578b-08d46664fa05 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:DM5PR12MB1612; X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1612; 3:x1OXUHDwRsK3XvFUmN93AvFcc3fzdhJRYxfvDZ071FvjP1fJIyrFnrcLo/QYuu/dwveJYAfbRISbq3UN27yp9yKsvi7DvcffgrNjYW5rouTb8fV5m7oK/ooLEPwcna0kQArHu8wtj124AvmXvN9eKU4DzPdoDd2IveayYY/VD1Gnzd/6IHrMa2aA5/GDuC5FiSnvZ7DeZ/3W2kLRiYwXrjALvCkvTsmM0/ZzJhWYlg57hiyYYzTK9CBVnkbdztNniw+3BdZZsRFIC2kfC/TyVJldHmkFtXyoTGt9wohwT20=; 25:i9V2F7Qi3ODULb0SMbr+UVLc3AKHeGWFJDJDDa1fML+72Gvx2DliiDsqgGzH2v0yr/6cpwgY9pxoMDWKVfw0zEf5UWpswSRZA0jL06sjLbDVnCyR1/WxUUbx6hfwc4MayA0T1tsfnlcKALkpKlg6+ajbes2NNrVjrOR6DNsM7cokRcE9ZI/F5SiuSyGGQK9Cs4n2obqn4kUUSPPEM49H55aMfqC0IlrNFrAzq8Yzeyi7t6UHWDhEThQWncXMTe3hB74IiZT2FOPODQmqKlRbCf0xC/oW0oIJs5etbAv7zYpOLuV3NP8EZBwUQCCZpHTt3MuKtNkk32ikSvXqZ4Xd2hQ3Rri11YRCFg7QG8xxtyyeN8/P2sjlQbX5LIGPmUIsv8gcTlg31alYL7z9IcOYX8qmSIQEZIdFFFYYKIS9E15Ha/Hz3O6CqlcjHA/U/bMt1/YK4yV6bwjhkLeDIAGnlw== X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1612; 31:eiZfd9SwB+pgCrWQy8YCCpdXlANegSQpVaRUPt7L5oTxctUuiFuium8OgjwVAGH23RxMnWjgra6X04ZBEf+bF7SkcAnmrrhP4snGwHwhNLVdZh6SBFtRADBnZoDThwiMz3t8OOgWmogtpbjNLj1iyK5Bg6VzjrUCLsyeOrcCFmbYXgXSOcV6oE4mV8gXzN0LbW/JxmiZs1jExKl6t0EjnWAjm0nDmfWWnzuSxu3Joco=; 20:oZIN4jWQpF7O13D3bOasfl9hlESclv8npP5eBy4qHG8lx3k6c65gnNKR7DRYoxrKUlC11uTcH8PS3ubi+WOfT7+hgGBw8+PrSyaTL9fWzp3SKT0lAx3OfA3XgCKfhjOgJv/lR93reH+JKC+ZkjzWHN52oswr/oUxBGi0jCLebPim6s5nZbz5rz5wJ6jhw4q0rWW/kkx6v8WNAVZnt69sgR8MRvCnoWl2oD+Ue728Kuc3f5V/fzxvX4C7aJ/yeiTaejziRJb3IcKuPt45Iduk1911q0sxOlVjJgS8EM9vAMs0vY8Lfe7Asf3Lvqv02vCL0MQf3pU80BPny/+q3RhIGpPKU8Pjw66bncWOlBbU97uFEuebotM71LBZMR5wTMZvHjqwDMoR0QujMpKT9ZrnBeQ4X6l9vKzI0Cn4Qk3hu3Sip3QU/g2uNIgo9LqZlrdR1Hei86yL1UnBFIYDsgzoTJAtaoCsYkG0UuM0MZyVtOFk8mdO/8SdACyuTXkf563S X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123558025)(20161123564025)(6072148); SRVR:DM5PR12MB1612; BCL:0; PCL:0; RULEID:; SRVR:DM5PR12MB1612; X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1612; 4:mbspOXgdzTLHJvxgCY244mpKkBrv6PkCM8LMtXNHfd0plMSfI5A514ePW8+OBMFT/7WrlkZ0MAJ8C/exVakhzNhIgRcYhubTO4gDB1nnNKxu9nnCSxNbmsHdpDJfv+Zuw7YXyw6BE2CtHXNuKLxJCLt663WffyUoF3DzDGocOFX69Gg4C3HM6rRlCf6FzGa025XyZMJygj5UnYY4oU8cZWKE03tDofK4ZIUl2yZRxhl3P6kegGfanVoGL9bm7mNiNJO6KJX1YEbJpdVNuPkzWju1elyN+RzxU2N+L8SfDNgSA94W+/j4CAQLVcyli+3tanpFkEuFK6vbVjpsk9/lFd50N9k4KWsYBM+D+/Ap5NwulgUX6w4KKC7fsbXi0/Ia3J5mF8kjHBnOO7cob7DSPRW64XV6i6F3aIZfg3f2rAKKaCoqJo7h8binrK+dtJo1FBkUSmXKqULlPAUSTtZlA8UOJlnIwgKoxc0WawHdTwXhXRmczsqWzXCc3x4o1RocSpfL5Un5iaZrRh9659FIuvvd9uMXcig2dvjkGLljdtpkr1tbIOyScXIDGNKy0PMu6aKDTNrTPcP8fFCvxPS6z+AhqmTwTmhI78rmiH7ur84/6O58npflUKF4jWmQFBpJqnOj/3cCcZnhVzay/ruxMVDA/eYDrJ/JUQB8MhSqi3Q= X-Forefront-PRVS: 02408926C4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39850400002)(39860400002)(39840400002)(39450400003)(39410400002)(50986999)(76176999)(81166006)(3846002)(6116002)(23676002)(7736002)(8676002)(189998001)(305945005)(86362001)(66066001)(2201001)(83506001)(47776003)(230700001)(33716001)(33646002)(9686003)(54906002)(42186005)(6666003)(103116003)(54356999)(2950100002)(77096006)(6486002)(50466002)(38730400002)(90366009)(2906002)(53936002)(5660300001)(4326008)(25786008)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1612; H:[127.0.1.1]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNjEyOzIzOjdWN0VRT1hqaU52TVUrMHVnNTQ1TEhvYWtL?= =?utf-8?B?WStqcG5VUEEvVzRGaW50YnAweHRsTWZJeU1qYk92dm1GVUJFL2Z2WmREVStD?= =?utf-8?B?N2ZabkQ3WXUwQjNRZ0thNW5wZUR4L1R4ampXUXBiZXNyeVJUWiszWHR5a3Bm?= =?utf-8?B?a3NUZ3BBT1pFbVRsM25MOEtXaDhTWXFaUVlFQmhOd3ZtZmdxSVRDOW0vaXhN?= =?utf-8?B?cjhjTCsvMDl1WDdRUzdQZjkybndNN2YzVXhab0twb1Y5SHZkU3Bic0hDQzlt?= =?utf-8?B?ZWhSdFNOL2k3bnVSVFlrMTdKUmcreEt0a1FoN0xOVXFRWWJIQXdLd2JBemtv?= =?utf-8?B?YW5wcE9qRmlzaFlxSStXOFk1TXBscFRhd0htZ3JueWs1NkhvQzU5K2pVUWRJ?= =?utf-8?B?MmJOYy9DWmhZamJObzNZRDdFMEVHWUduc0E2MWxSZHY2OXpBUk1rN1UxYmVl?= =?utf-8?B?bWFWQ284QWVXNXE0SGl6K3JMOU9HMkNHZVVuRUxpWnE4MkZ5b1hCTC81SVNB?= =?utf-8?B?VVdzdVNPV21hbnZzY3ZYSWJjVjBTMUxlK0hoeFJpMHNmekk0MEJsVmJLYStu?= =?utf-8?B?UmZNekoxdFlMeHZza0FHUjR6L2NXSXlkNFFaL0k5TmRQNlh3eVE1TnFGN0Zy?= =?utf-8?B?QTdKZ2NJWERzVUxGVEoyeGQ5bkhKb0dnNWh5U0h3SEY3cG9aK0dlTnFOQnVv?= =?utf-8?B?emg0NDQ0bTNhcGV1NHdxUkdJTldEdVArREp2T3VWOWordVZUU2RVZXUvL25j?= =?utf-8?B?TmdiMGhDNkpyeStQL1BTU1J5T296NjdqRTdmaFlSbUluQmVKdTl3dkNGU2t5?= =?utf-8?B?aU5TcUw1MVhtc3JhcW9YR2tFd1dNMjRnU2hrZHZJRWZqQi8yQVVLSWlGeFZz?= =?utf-8?B?dE91RGNUWVEwckV5K0lRTG9nbFgvcXVOVEhZbVkvd0tHbDhGTEM5bDVqbGZQ?= =?utf-8?B?SnpseG5SL0lwd0ZTbmdBbS9HY2x2bnVhaVhHdkdUVVlGVVNPd1VVTnpoV2VW?= =?utf-8?B?ZmR3SzFMTmd4M0FVbjFYRGtlZUx4NFBmY2dLZ3hSTGdqRTdmV3g2MjBYbDdQ?= =?utf-8?B?QUJDRUE5WjZIR3B3ZkN2eXRCdUtpVGFjZXVHekoyWENESWJtalFlWmdDQnFD?= =?utf-8?B?b1lmU2ZwdUtMK3pGQlpreGZDeWtpZzRWZlgzTHlJbGo3ZkZCeUZZaS8xdm1Y?= =?utf-8?B?RklYNG1YRGZCYkpUdWZBN3Z1RFcrTUNZMERDNGYzT1F2TmF5dWlwNjBqekYr?= =?utf-8?B?TEU0bGZNT1paM2RYay9VVGdIMG5hOThyQUtqSWFOVEhWelRTaUpsRkhnYXFk?= =?utf-8?B?bVh5MVNIditNUzRBQlk4K1dzbEZFb3pLTE9pNFRYd3FGNXl1NVVSODBHYThD?= =?utf-8?B?alNtZWxuV2R2Y2NlWGtXeVhIUTVJaVBDNERnU1lqcTRRNTRwMTMrb2VaRHEr?= =?utf-8?B?UFJjUlJlSEdmakhlaWdickJpK1VFOEM3VWZXZE0rOVRJZlVsVnIzb0NGcS9r?= =?utf-8?B?NER2dz09?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1612; 6:nXuKOtq4AydEFVz/GhOnt5uzHXzVxMFbFvdj1V4VyfQ9I205YAJ3/jIN1YB1lN9hnI0iuLmzj/FBZhrHSVFDTQ9XuGTAId7pA6IlT5CPOT//TtrRTQQk7f/MNitaZofRhEevvcWfJpzFpBPYSm6r8ozHd3cSA3l5l1luPUxbPySwjxE9jknE0krlhgCIl4B3djKBvAOHLSsjhs0S2wfE4rS/ObhcuIvGImpuyBPjNY25Qums1eu+r4n0riL3j/tmipXFP8cUdc4AL+TH7/O3PurhfWGWNo5UnmTfOVKs1Ms4UXztK0dPRfusDnuc/1RKfKamcLY8162L+P0mt2ZU08kOTayHXXxF1SVjXBgZv/zVKz2HYEC4J9UzreaXXFbY5iQ4Ke8O+x1sx3CotytQonEH7l1vxhbqaRy3QtgMNKI=; 5:7WWByAX7fhqQ+eGcbNhXZyP2FxeC8dKippCj60IuTIpLsQRoCHynxy8Ip3waP3jpFzl8R3L7Z/O5+xTz5S8xkvcQh/whVY6jUlFhGWVy4C7/np/yrNPps2WRaW7CbviuXdyeNxWhukA6ub/NNzkazw9TUxDx4g4EQbhfsvEZs0Q=; 24:Vy7nIAOmAWIb1qJWzgbjMVkWoIyZNNyMUJWttrZjfMxk2TBtZRMEVkbvqhD/jSsBFON12+0yoHpxqhLo1RwjGpwFSxCtjsAuyJ/Nf3tSpzg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR12MB1612; 7:qADK97ufu5vqftNU20zrLJm/UqLyzIMxAXQx4GA6JC8b3s+R/yn8rABR4cap7+XPdE6OYyATidmwPM8vklUzHiiAqVZgK596IEQD0/IQ2roI2s0e/ZYytqGHrX+bP5WudlPmfrql9G9zLbIBYCyFl7RVNARNfY0ES7mDuGZqv1mDm2yKiAGUQznLutSb27vPb4rXHBocZZgO2An9v4bTByG6JAmOFnSqrAIPB2vlp+c26aNb78HuEoRWz31DCh8EvLWB6+fF6NCyp5+k/rLcPPuGpfZJnMBeUMAbLRt45/aGnJDAAlFe+8DmAJ8uzOcGX4+NkCZBy01K73Rqzj8z9w==; 20:M/1EP2PU+vwwVrJIOA2a08D7xhvqNFD7yeVOt3WM1kOKex1QODDWeiErPRBCwB6xvo+U76klU7fLAm5Plfz9EFE2LofSRjRCpF2y0nqVdVyOvCvjedBJ1A2N6BCXGOkiVA2oqQxW7L6QnPXjbPF6muqpUghFWm1zMH9y/dqWIslEoH3qtxdIo+JAfYMjXXSCWB3P4sZccsmcSyabZVJXdDRZe8WL9QS+k5LShnanIsNumFQmPbMdTteF668ntQRx X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2017 20:52:02.7874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1612 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.80 Subject: [Qemu-devel] [RFC PATCH v4 05/20] monitor/i386: use debug apis when accessing guest memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas.Lendacky@amd.com, brijesh.singh@amd.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" updates hmp monitor to use debug version of memory access apis when reading the guest memory. Signed-off-by: Brijesh Singh --- cpus.c | 2 - disas.c | 2 - monitor.c | 2 - target/i386/helper.c | 16 +++---- target/i386/monitor.c | 114 +++++++++++++++++++++++++++++-------------------- 5 files changed, 79 insertions(+), 57 deletions(-) diff --git a/cpus.c b/cpus.c index c857ad2..5c3b596 100644 --- a/cpus.c +++ b/cpus.c @@ -1906,7 +1906,7 @@ void qmp_pmemsave(int64_t addr, int64_t size, const char *filename, l = sizeof(buf); if (l > size) l = size; - cpu_physical_memory_read(addr, buf, l); + cpu_physical_memory_read_debug(addr, buf, l); if (fwrite(buf, 1, l, f) != l) { error_setg(errp, QERR_IO_ERROR); goto exit; diff --git a/disas.c b/disas.c index d335c55..6d67de5 100644 --- a/disas.c +++ b/disas.c @@ -357,7 +357,7 @@ monitor_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length, CPUDebug *s = container_of(info, CPUDebug, info); if (monitor_disas_is_physical) { - cpu_physical_memory_read(memaddr, myaddr, length); + cpu_physical_memory_read_debug(memaddr, myaddr, length); } else { cpu_memory_rw_debug(s->cpu, memaddr, myaddr, length, 0); } diff --git a/monitor.c b/monitor.c index ec7623e..4a1c772 100644 --- a/monitor.c +++ b/monitor.c @@ -1350,7 +1350,7 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, if (l > line_size) l = line_size; if (is_physical) { - cpu_physical_memory_read(addr, buf, l); + cpu_physical_memory_read_debug(addr, buf, l); } else { if (cpu_memory_rw_debug(cs, addr, buf, l, 0) < 0) { monitor_printf(mon, " Cannot access memory\n"); diff --git a/target/i386/helper.c b/target/i386/helper.c index e2af340..05395d7 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -1061,7 +1061,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) if (la57) { pml5e_addr = ((env->cr[3] & ~0xfff) + (((addr >> 48) & 0x1ff) << 3)) & env->a20_mask; - pml5e = x86_ldq_phys(cs, pml5e_addr); + pml5e = ldq_phys_debug(cs, pml5e_addr); if (!(pml5e & PG_PRESENT_MASK)) { return -1; } @@ -1071,13 +1071,13 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) pml4e_addr = ((pml5e & PG_ADDRESS_MASK) + (((addr >> 39) & 0x1ff) << 3)) & env->a20_mask; - pml4e = x86_ldq_phys(cs, pml4e_addr); + pml4e = ldq_phys_debug(cs, pml4e_addr); if (!(pml4e & PG_PRESENT_MASK)) { return -1; } pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) << 3)) & env->a20_mask; - pdpe = x86_ldq_phys(cs, pdpe_addr); + pdpe = ldq_phys_debug(cs, pdpe_addr); if (!(pdpe & PG_PRESENT_MASK)) { return -1; } @@ -1092,14 +1092,14 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) { pdpe_addr = ((env->cr[3] & ~0x1f) + ((addr >> 27) & 0x18)) & env->a20_mask; - pdpe = x86_ldq_phys(cs, pdpe_addr); + pdpe = ldq_phys_debug(cs, pdpe_addr); if (!(pdpe & PG_PRESENT_MASK)) return -1; } pde_addr = ((pdpe & PG_ADDRESS_MASK) + (((addr >> 21) & 0x1ff) << 3)) & env->a20_mask; - pde = x86_ldq_phys(cs, pde_addr); + pde = ldq_phys_debug(cs, pde_addr); if (!(pde & PG_PRESENT_MASK)) { return -1; } @@ -1112,7 +1112,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) pte_addr = ((pde & PG_ADDRESS_MASK) + (((addr >> 12) & 0x1ff) << 3)) & env->a20_mask; page_size = 4096; - pte = x86_ldq_phys(cs, pte_addr); + pte = ldq_phys_debug(cs, pte_addr); } if (!(pte & PG_PRESENT_MASK)) { return -1; @@ -1122,7 +1122,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) /* page directory entry */ pde_addr = ((env->cr[3] & ~0xfff) + ((addr >> 20) & 0xffc)) & env->a20_mask; - pde = x86_ldl_phys(cs, pde_addr); + pde = ldl_phys_debug(cs, pde_addr); if (!(pde & PG_PRESENT_MASK)) return -1; if ((pde & PG_PSE_MASK) && (env->cr[4] & CR4_PSE_MASK)) { @@ -1131,7 +1131,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) } else { /* page directory entry */ pte_addr = ((pde & ~0xfff) + ((addr >> 10) & 0xffc)) & env->a20_mask; - pte = x86_ldl_phys(cs, pte_addr); + pte = ldl_phys_debug(cs, pte_addr); if (!(pte & PG_PRESENT_MASK)) { return -1; } diff --git a/target/i386/monitor.c b/target/i386/monitor.c index 77ead60..7c39e05 100644 --- a/target/i386/monitor.c +++ b/target/i386/monitor.c @@ -59,14 +59,16 @@ static void print_pte(Monitor *mon, CPUArchState *env, hwaddr addr, pte & PG_RW_MASK ? 'W' : '-'); } -static void tlb_info_32(Monitor *mon, CPUArchState *env) +static void tlb_info_32(Monitor *mon, CPUState *cs) { unsigned int l1, l2; uint32_t pgd, pde, pte; + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; pgd = env->cr[3] & ~0xfff; for(l1 = 0; l1 < 1024; l1++) { - cpu_physical_memory_read(pgd + l1 * 4, &pde, 4); + pde = ldl_phys_debug(cs, pgd + l1 * 4); pde = le32_to_cpu(pde); if (pde & PG_PRESENT_MASK) { if ((pde & PG_PSE_MASK) && (env->cr[4] & CR4_PSE_MASK)) { @@ -74,7 +76,7 @@ static void tlb_info_32(Monitor *mon, CPUArchState *env) print_pte(mon, env, (l1 << 22), pde, ~((1 << 21) - 1)); } else { for(l2 = 0; l2 < 1024; l2++) { - cpu_physical_memory_read((pde & ~0xfff) + l2 * 4, &pte, 4); + pte = ldl_phys_debug(cs, (pde & ~0xfff) + l2 * 4); pte = le32_to_cpu(pte); if (pte & PG_PRESENT_MASK) { print_pte(mon, env, (l1 << 22) + (l2 << 12), @@ -87,20 +89,22 @@ static void tlb_info_32(Monitor *mon, CPUArchState *env) } } -static void tlb_info_pae32(Monitor *mon, CPUArchState *env) +static void tlb_info_pae32(Monitor *mon, CPUState *cs) { unsigned int l1, l2, l3; uint64_t pdpe, pde, pte; uint64_t pdp_addr, pd_addr, pt_addr; + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; pdp_addr = env->cr[3] & ~0x1f; for (l1 = 0; l1 < 4; l1++) { - cpu_physical_memory_read(pdp_addr + l1 * 8, &pdpe, 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l1 * 8); pdpe = le64_to_cpu(pdpe); if (pdpe & PG_PRESENT_MASK) { pd_addr = pdpe & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - cpu_physical_memory_read(pd_addr + l2 * 8, &pde, 8); + pde = ldq_phys_debug(cs, pd_addr + l2 * 8); pde = le64_to_cpu(pde); if (pde & PG_PRESENT_MASK) { if (pde & PG_PSE_MASK) { @@ -110,7 +114,7 @@ static void tlb_info_pae32(Monitor *mon, CPUArchState *env) } else { pt_addr = pde & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - cpu_physical_memory_read(pt_addr + l3 * 8, &pte, 8); + pte = ldq_phys_debug(cs, pt_addr + l3 * 8); pte = le64_to_cpu(pte); if (pte & PG_PRESENT_MASK) { print_pte(mon, env, (l1 << 30) + (l2 << 21) @@ -127,15 +131,17 @@ static void tlb_info_pae32(Monitor *mon, CPUArchState *env) } #ifdef TARGET_X86_64 -static void tlb_info_la48(Monitor *mon, CPUArchState *env, +static void tlb_info_la48(Monitor *mon, CPUState *cs, uint64_t l0, uint64_t pml4_addr) { + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; uint64_t l1, l2, l3, l4; uint64_t pml4e, pdpe, pde, pte; uint64_t pdp_addr, pd_addr, pt_addr; for (l1 = 0; l1 < 512; l1++) { - cpu_physical_memory_read(pml4_addr + l1 * 8, &pml4e, 8); + pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8); pml4e = le64_to_cpu(pml4e); if (!(pml4e & PG_PRESENT_MASK)) { continue; @@ -143,7 +149,7 @@ static void tlb_info_la48(Monitor *mon, CPUArchState *env, pdp_addr = pml4e & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - cpu_physical_memory_read(pdp_addr + l2 * 8, &pdpe, 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8); pdpe = le64_to_cpu(pdpe); if (!(pdpe & PG_PRESENT_MASK)) { continue; @@ -158,7 +164,7 @@ static void tlb_info_la48(Monitor *mon, CPUArchState *env, pd_addr = pdpe & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - cpu_physical_memory_read(pd_addr + l3 * 8, &pde, 8); + pde = ldq_phys_debug(cs, pd_addr + l3 * 8); pde = le64_to_cpu(pde); if (!(pde & PG_PRESENT_MASK)) { continue; @@ -173,9 +179,7 @@ static void tlb_info_la48(Monitor *mon, CPUArchState *env, pt_addr = pde & 0x3fffffffff000ULL; for (l4 = 0; l4 < 512; l4++) { - cpu_physical_memory_read(pt_addr - + l4 * 8, - &pte, 8); + pte = ldq_phys_debug(cs, pt_addr + l4 * 8); pte = le64_to_cpu(pte); if (pte & PG_PRESENT_MASK) { print_pte(mon, env, (l0 << 48) + (l1 << 39) + @@ -188,18 +192,20 @@ static void tlb_info_la48(Monitor *mon, CPUArchState *env, } } -static void tlb_info_la57(Monitor *mon, CPUArchState *env) +static void tlb_info_la57(Monitor *mon, CPUState *cs) { uint64_t l0; uint64_t pml5e; uint64_t pml5_addr; + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; pml5_addr = env->cr[3] & 0x3fffffffff000ULL; for (l0 = 0; l0 < 512; l0++) { - cpu_physical_memory_read(pml5_addr + l0 * 8, &pml5e, 8); + pml5e = ldq_phys_debug(cs, pml5_addr + l0 * 8); pml5e = le64_to_cpu(pml5e); if (pml5e & PG_PRESENT_MASK) { - tlb_info_la48(mon, env, l0, pml5e & 0x3fffffffff000ULL); + tlb_info_la48(mon, cs, l0, pml5e & 0x3fffffffff000ULL); } } } @@ -207,9 +213,13 @@ static void tlb_info_la57(Monitor *mon, CPUArchState *env) void hmp_info_tlb(Monitor *mon, const QDict *qdict) { + X86CPU *cpu; + CPUState *cs; CPUArchState *env; - env = mon_get_cpu_env(); + cs = mon_get_cpu(); + cpu = X86_CPU(cs); + env = &cpu->env; if (!env) { monitor_printf(mon, "No CPU available\n"); return; @@ -223,17 +233,17 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict) #ifdef TARGET_X86_64 if (env->hflags & HF_LMA_MASK) { if (env->cr[4] & CR4_LA57_MASK) { - tlb_info_la57(mon, env); + tlb_info_la57(mon, cs); } else { - tlb_info_la48(mon, env, 0, env->cr[3] & 0x3fffffffff000ULL); + tlb_info_la48(mon, cs, 0, env->cr[3] & 0x3fffffffff000ULL); } } else #endif { - tlb_info_pae32(mon, env); + tlb_info_pae32(mon, cs); } } else { - tlb_info_32(mon, env); + tlb_info_32(mon, cs); } } @@ -260,18 +270,20 @@ static void mem_print(Monitor *mon, hwaddr *pstart, } } -static void mem_info_32(Monitor *mon, CPUArchState *env) +static void mem_info_32(Monitor *mon, CPUState *cs) { unsigned int l1, l2; int prot, last_prot; uint32_t pgd, pde, pte; hwaddr start, end; + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; pgd = env->cr[3] & ~0xfff; last_prot = 0; start = -1; for(l1 = 0; l1 < 1024; l1++) { - cpu_physical_memory_read(pgd + l1 * 4, &pde, 4); + pde = ldl_phys_debug(cs, pgd + l1 * 4); pde = le32_to_cpu(pde); end = l1 << 22; if (pde & PG_PRESENT_MASK) { @@ -280,7 +292,7 @@ static void mem_info_32(Monitor *mon, CPUArchState *env) mem_print(mon, &start, &last_prot, end, prot); } else { for(l2 = 0; l2 < 1024; l2++) { - cpu_physical_memory_read((pde & ~0xfff) + l2 * 4, &pte, 4); + pte = ldl_phys_debug(cs, (pde & ~0xfff) + l2 * 4); pte = le32_to_cpu(pte); end = (l1 << 22) + (l2 << 12); if (pte & PG_PRESENT_MASK) { @@ -301,25 +313,27 @@ static void mem_info_32(Monitor *mon, CPUArchState *env) mem_print(mon, &start, &last_prot, (hwaddr)1 << 32, 0); } -static void mem_info_pae32(Monitor *mon, CPUArchState *env) +static void mem_info_pae32(Monitor *mon, CPUState *cs) { unsigned int l1, l2, l3; int prot, last_prot; uint64_t pdpe, pde, pte; uint64_t pdp_addr, pd_addr, pt_addr; hwaddr start, end; + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; pdp_addr = env->cr[3] & ~0x1f; last_prot = 0; start = -1; for (l1 = 0; l1 < 4; l1++) { - cpu_physical_memory_read(pdp_addr + l1 * 8, &pdpe, 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l1 * 8); pdpe = le64_to_cpu(pdpe); end = l1 << 30; if (pdpe & PG_PRESENT_MASK) { pd_addr = pdpe & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - cpu_physical_memory_read(pd_addr + l2 * 8, &pde, 8); + pde = ldq_phys_debug(cs, pd_addr + l2 * 8); pde = le64_to_cpu(pde); end = (l1 << 30) + (l2 << 21); if (pde & PG_PRESENT_MASK) { @@ -330,7 +344,7 @@ static void mem_info_pae32(Monitor *mon, CPUArchState *env) } else { pt_addr = pde & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - cpu_physical_memory_read(pt_addr + l3 * 8, &pte, 8); + pte = ldq_phys_debug(cs, pt_addr + l3 * 8); pte = le64_to_cpu(pte); end = (l1 << 30) + (l2 << 21) + (l3 << 12); if (pte & PG_PRESENT_MASK) { @@ -358,10 +372,12 @@ static void mem_info_pae32(Monitor *mon, CPUArchState *env) #ifdef TARGET_X86_64 -static void mem_info_la48(Monitor *mon, CPUArchState *env) +static void mem_info_la48(Monitor *mon, CPUState *cs) { int prot, last_prot; uint64_t l1, l2, l3, l4; + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; uint64_t pml4e, pdpe, pde, pte; uint64_t pml4_addr, pdp_addr, pd_addr, pt_addr, start, end; @@ -369,13 +385,13 @@ static void mem_info_la48(Monitor *mon, CPUArchState *env) last_prot = 0; start = -1; for (l1 = 0; l1 < 512; l1++) { - cpu_physical_memory_read(pml4_addr + l1 * 8, &pml4e, 8); + pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8); pml4e = le64_to_cpu(pml4e); end = l1 << 39; if (pml4e & PG_PRESENT_MASK) { pdp_addr = pml4e & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - cpu_physical_memory_read(pdp_addr + l2 * 8, &pdpe, 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8); pdpe = le64_to_cpu(pdpe); end = (l1 << 39) + (l2 << 30); if (pdpe & PG_PRESENT_MASK) { @@ -387,7 +403,7 @@ static void mem_info_la48(Monitor *mon, CPUArchState *env) } else { pd_addr = pdpe & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - cpu_physical_memory_read(pd_addr + l3 * 8, &pde, 8); + pde = ldq_phys_debug(cs, pd_addr + l3 * 8); pde = le64_to_cpu(pde); end = (l1 << 39) + (l2 << 30) + (l3 << 21); if (pde & PG_PRESENT_MASK) { @@ -399,9 +415,8 @@ static void mem_info_la48(Monitor *mon, CPUArchState *env) } else { pt_addr = pde & 0x3fffffffff000ULL; for (l4 = 0; l4 < 512; l4++) { - cpu_physical_memory_read(pt_addr - + l4 * 8, - &pte, 8); + pte = ldq_phys_debug(cs, + pt_addr + l4 * 8); pte = le64_to_cpu(pte); end = (l1 << 39) + (l2 << 30) + (l3 << 21) + (l4 << 12); @@ -435,10 +450,12 @@ static void mem_info_la48(Monitor *mon, CPUArchState *env) mem_print(mon, &start, &last_prot, (hwaddr)1 << 48, 0); } -static void mem_info_la57(Monitor *mon, CPUArchState *env) +static void mem_info_la57(Monitor *mon, CPUState *cs) { int prot, last_prot; uint64_t l0, l1, l2, l3, l4; + X86CPU *cpu = X86_CPU(cs); + CPUArchState *env = &cpu->env; uint64_t pml5e, pml4e, pdpe, pde, pte; uint64_t pml5_addr, pml4_addr, pdp_addr, pd_addr, pt_addr, start, end; @@ -446,7 +463,7 @@ static void mem_info_la57(Monitor *mon, CPUArchState *env) last_prot = 0; start = -1; for (l0 = 0; l0 < 512; l0++) { - cpu_physical_memory_read(pml5_addr + l0 * 8, &pml5e, 8); + pml5e = ldq_phys_debug(cs, pml5_addr + l0 * 8); pml4e = le64_to_cpu(pml5e); end = l0 << 48; if (!(pml5e & PG_PRESENT_MASK)) { @@ -457,7 +474,7 @@ static void mem_info_la57(Monitor *mon, CPUArchState *env) pml4_addr = pml5e & 0x3fffffffff000ULL; for (l1 = 0; l1 < 512; l1++) { - cpu_physical_memory_read(pml4_addr + l1 * 8, &pml4e, 8); + pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8); pml4e = le64_to_cpu(pml4e); end = (l0 << 48) + (l1 << 39); if (!(pml4e & PG_PRESENT_MASK)) { @@ -468,7 +485,7 @@ static void mem_info_la57(Monitor *mon, CPUArchState *env) pdp_addr = pml4e & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - cpu_physical_memory_read(pdp_addr + l2 * 8, &pdpe, 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8); pdpe = le64_to_cpu(pdpe); end = (l0 << 48) + (l1 << 39) + (l2 << 30); if (pdpe & PG_PRESENT_MASK) { @@ -487,7 +504,7 @@ static void mem_info_la57(Monitor *mon, CPUArchState *env) pd_addr = pdpe & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - cpu_physical_memory_read(pd_addr + l3 * 8, &pde, 8); + pde = ldq_phys_debug(cs, pd_addr + l3 * 8); pde = le64_to_cpu(pde); end = (l0 << 48) + (l1 << 39) + (l2 << 30) + (l3 << 21); if (pde & PG_PRESENT_MASK) { @@ -506,7 +523,7 @@ static void mem_info_la57(Monitor *mon, CPUArchState *env) pt_addr = pde & 0x3fffffffff000ULL; for (l4 = 0; l4 < 512; l4++) { - cpu_physical_memory_read(pt_addr + l4 * 8, &pte, 8); + pte = ldq_phys_debug(cs, pt_addr + l4 * 8); pte = le64_to_cpu(pte); end = (l0 << 48) + (l1 << 39) + (l2 << 30) + (l3 << 21) + (l4 << 12); @@ -530,8 +547,13 @@ static void mem_info_la57(Monitor *mon, CPUArchState *env) void hmp_info_mem(Monitor *mon, const QDict *qdict) { + X86CPU *cpu; + CPUState *cs; CPUArchState *env; + cs = mon_get_cpu(); + cpu = X86_CPU(cs); + env = &cpu->env; env = mon_get_cpu_env(); if (!env) { monitor_printf(mon, "No CPU available\n"); @@ -546,17 +568,17 @@ void hmp_info_mem(Monitor *mon, const QDict *qdict) #ifdef TARGET_X86_64 if (env->hflags & HF_LMA_MASK) { if (env->cr[4] & CR4_LA57_MASK) { - mem_info_la57(mon, env); + mem_info_la57(mon, cs); } else { - mem_info_la48(mon, env); + mem_info_la48(mon, cs); } } else #endif { - mem_info_pae32(mon, env); + mem_info_pae32(mon, cs); } } else { - mem_info_32(mon, env); + mem_info_32(mon, cs); } }