From patchwork Fri Feb 24 17:40:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 732214 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vVJgs5gskz9s7C for ; Sat, 25 Feb 2017 04:56:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="i5VXzZ4Q"; dkim-atps=neutral Received: from localhost ([::1]:38971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chK6R-0000fV-7s for incoming@patchwork.ozlabs.org; Fri, 24 Feb 2017 12:56:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chJrE-0007rC-8d for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:40:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chJrC-0002FD-KE for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:40:40 -0500 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:35391) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1chJrC-0002Ez-Dg for qemu-devel@nongnu.org; Fri, 24 Feb 2017 12:40:38 -0500 Received: by mail-wr0-x241.google.com with SMTP id q39so3111564wrb.2 for ; Fri, 24 Feb 2017 09:40:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=/HPgU1GyH+MEWDlVyc/zm1uzXwwWoZY5rnAvc88YdzQ=; b=i5VXzZ4QJ4zTkvSDd0+nE29zAYWgHNsvOOHugwk16ZSstsyeyZGkoMihwrFXv+Cbhx aP4PFLXZzO8GUE3oxY5J8EYa6Frs0wc70Ctx4r4JsTrFw7KNFc7hry6xG6WFHLVFuqM7 B/hiI3Oj9xmxfb63hoiTPmiUDRBRAzl/dDazc9rB6iLIyp9tahmgXxgIV88lrFKbhwWd eNF1m5FHMpK0oYE1GX0eeCQ5xMENqPPIthPr6HEcFffRABDe3sSdbrqArAa5YIZeXSa9 i2HVkQDMfVflGIVts7r/Suc70gY4dF/V2myX875/7nOimjccMCTKqidIapTO9sZjZCTb 6IGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=/HPgU1GyH+MEWDlVyc/zm1uzXwwWoZY5rnAvc88YdzQ=; b=Q+2Wx4lDrhUgk6fiviC2BfdvFeKHc07q1vy8nMW5m+O6uiNVrEM+R7fec3ZH5OfRva SJEUMGVrTa3u2ZzD/oEcGyP3EJj6jTU8oPwEFDdzg7+M0ZloPZ7MKMIa800TgdP4iChu qffkf9Eh83iN4knYnfAGF+yTqAnczwo/iRCZEVtuIAsrisZDLpT0aZv0ND9HJiprbhOW gAA+lIwuYX+q0htzQb0WXBEYmtGlWRJDHOdwxzVeyNmTb37tiM74KFV/vgdfhIGrihUk QfgNM76N1RnDUgmM+hWlMNj8kzD+CV/gsQ4o9BFS3LIwOfRVMfnEYo2ZuIWmcoKAXTkh EPqQ== X-Gm-Message-State: AMke39mjAKzF9yIr9X2e+9cGX60FIHGvyNsyWO7RhTl+ptuqgKaI8gqStgkpnR7CqygeFw== X-Received: by 10.223.131.103 with SMTP id 94mr3587476wrd.115.1487958037210; Fri, 24 Feb 2017 09:40:37 -0800 (PST) Received: from 640k.lan (94-39-187-56.adsl-ull.clienti.tiscali.it. [94.39.187.56]) by smtp.gmail.com with ESMTPSA id s26sm8814533wra.66.2017.02.24.09.40.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Feb 2017 09:40:36 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 24 Feb 2017 18:40:16 +0100 Message-Id: <1487958030-51417-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1487958030-51417-1-git-send-email-pbonzini@redhat.com> References: <1487958030-51417-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 03/17] cpu-exec: remove unnecessary check of cpu->exit_request X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The cpu->exit_request check in cpu_loop_exec_tb is unnecessary, because cpu->tcg_exit_req is always set after cpu->exit_request. So let the TB exit and we will pick up the exit request later in cpu_handle_interrupt. Signed-off-by: Paolo Bonzini --- cpu-exec.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 7ddf66c..7db959c 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -535,10 +535,6 @@ static inline void cpu_loop_exec_tb(CPUState *cpu, TranslationBlock *tb, uintptr_t ret; int32_t insns_left; - if (unlikely(atomic_read(&cpu->exit_request))) { - return; - } - trace_exec_tb(tb, tb->pc); ret = cpu_tb_exec(cpu, tb); tb = (TranslationBlock *)(ret & ~TB_EXIT_MASK);