| Message ID | 1487363905-9480-6-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 02/17/2017 02:38 PM, Markus Armbruster wrote: > Use qobject_to_qdict() instead of a type cast. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > tests/libqtest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Happens to be the same (because of our struct layout), but agree that the conversion function is safer if we ever change struct layout. Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/tests/libqtest.c b/tests/libqtest.c index d8fba66..e54354d 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -379,9 +379,9 @@ static void qmp_response(JSONMessageParser *parser, GQueue *tokens) exit(1); } - g_assert(qobject_type(obj) == QTYPE_QDICT); g_assert(!qmp->response); - qmp->response = (QDict *)obj; + qmp->response = qobject_to_qdict(obj); + g_assert(qmp->response); } QDict *qmp_fd_receive(int fd)
Use qobject_to_qdict() instead of a type cast. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- tests/libqtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)