| Message ID | 1486456099-7345-10-git-send-email-peterx@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Feb 07, 2017 at 04:28:11PM +0800, Peter Xu wrote: > This helps in debugging incorrect level passed in. > > Reviewed-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > --- > hw/i386/intel_iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index ad304f6..22d8226 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -168,6 +168,7 @@ static gboolean vtd_hash_remove_by_domain(gpointer key, gpointer value, > /* The shift of an addr for a certain level of paging structure */ > static inline uint32_t vtd_slpt_level_shift(uint32_t level) > { > + assert(level != 0); > return VTD_PAGE_SHIFT_4K + (level - 1) * VTD_SL_LEVEL_BITS; > } >
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index ad304f6..22d8226 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -168,6 +168,7 @@ static gboolean vtd_hash_remove_by_domain(gpointer key, gpointer value, /* The shift of an addr for a certain level of paging structure */ static inline uint32_t vtd_slpt_level_shift(uint32_t level) { + assert(level != 0); return VTD_PAGE_SHIFT_4K + (level - 1) * VTD_SL_LEVEL_BITS; }