| Message ID | 1486110164-13797-17-git-send-email-peterx@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 2017年02月03日 16:22, Peter Xu wrote: > Before this one we only invalidate context cache when we receive context > entry invalidations. However it's possible that the invalidation also > contains a domain switch (only if cache-mode is enabled for vIOMMU). In > that case we need to notify all the registered components about the new > mapping. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > hw/i386/intel_iommu.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 0a42c01..363227d 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -1115,6 +1115,16 @@ static void vtd_context_device_invalidate(IntelIOMMUState *s, > trace_vtd_inv_desc_cc_device(bus_n, VTD_PCI_SLOT(devfn_it), > VTD_PCI_FUNC(devfn_it)); > vtd_as->context_cache_entry.context_cache_gen = 0; > + /* > + * So a device is moving out of (or moving into) a > + * domain, a replay() suites here to notify all the > + * IOMMU_NOTIFIER_MAP registers about this change. > + * This won't bring bad even if we have no such > + * notifier registered - the IOMMU notification > + * framework will skip MAP notifications if that > + * happened. > + */ > + memory_region_iommu_replay_all(&vtd_as->iommu); > } > } > } Reviewed-by: Jason Wang <jasowang@redhat.com> We may consider to squash this into patch 18. Thanks
On Tue, Feb 07, 2017 at 02:16:15PM +0800, Jason Wang wrote: > > > On 2017年02月03日 16:22, Peter Xu wrote: > >Before this one we only invalidate context cache when we receive context > >entry invalidations. However it's possible that the invalidation also > >contains a domain switch (only if cache-mode is enabled for vIOMMU). In > >that case we need to notify all the registered components about the new > >mapping. > > > >Signed-off-by: Peter Xu <peterx@redhat.com> > >--- > > hw/i386/intel_iommu.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > >diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > >index 0a42c01..363227d 100644 > >--- a/hw/i386/intel_iommu.c > >+++ b/hw/i386/intel_iommu.c > >@@ -1115,6 +1115,16 @@ static void vtd_context_device_invalidate(IntelIOMMUState *s, > > trace_vtd_inv_desc_cc_device(bus_n, VTD_PCI_SLOT(devfn_it), > > VTD_PCI_FUNC(devfn_it)); > > vtd_as->context_cache_entry.context_cache_gen = 0; > >+ /* > >+ * So a device is moving out of (or moving into) a > >+ * domain, a replay() suites here to notify all the > >+ * IOMMU_NOTIFIER_MAP registers about this change. > >+ * This won't bring bad even if we have no such > >+ * notifier registered - the IOMMU notification > >+ * framework will skip MAP notifications if that > >+ * happened. > >+ */ > >+ memory_region_iommu_replay_all(&vtd_as->iommu); > > } > > } > > } > > Reviewed-by: Jason Wang <jasowang@redhat.com> > > We may consider to squash this into patch 18. I can do it. Thanks, -- peterx
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 0a42c01..363227d 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1115,6 +1115,16 @@ static void vtd_context_device_invalidate(IntelIOMMUState *s, trace_vtd_inv_desc_cc_device(bus_n, VTD_PCI_SLOT(devfn_it), VTD_PCI_FUNC(devfn_it)); vtd_as->context_cache_entry.context_cache_gen = 0; + /* + * So a device is moving out of (or moving into) a + * domain, a replay() suites here to notify all the + * IOMMU_NOTIFIER_MAP registers about this change. + * This won't bring bad even if we have no such + * notifier registered - the IOMMU notification + * framework will skip MAP notifications if that + * happened. + */ + memory_region_iommu_replay_all(&vtd_as->iommu); } } }
Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a domain switch (only if cache-mode is enabled for vIOMMU). In that case we need to notify all the registered components about the new mapping. Signed-off-by: Peter Xu <peterx@redhat.com> --- hw/i386/intel_iommu.c | 10 ++++++++++ 1 file changed, 10 insertions(+)