diff mbox

hw/ppc/spapr: Allow POWER9 as hot-pluggable CPU for pseries

Message ID 1483966644-14049-1-git-send-email-thuth@redhat.com
State New
Headers show

Commit Message

Thomas Huth Jan. 9, 2017, 12:57 p.m. UTC
Running "qemu-system-ppc64 -M pseries -cpu POWER9" currently does not work
yet and results in this error message:

 qemu-system-ppc64: Unable to find sPAPR CPU Core definition

Since we want to support the pseries machine with POWER9 in the future,
allow using POWER9 as hot-pluggable CPU there, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/ppc/spapr_cpu_core.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

David Gibson Jan. 10, 2017, 12:39 a.m. UTC | #1
On Mon, Jan 09, 2017 at 01:57:24PM +0100, Thomas Huth wrote:
> Running "qemu-system-ppc64 -M pseries -cpu POWER9" currently does not work
> yet and results in this error message:
> 
>  qemu-system-ppc64: Unable to find sPAPR CPU Core definition
> 
> Since we want to support the pseries machine with POWER9 in the future,
> allow using POWER9 as hot-pluggable CPU there, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

I'm not sure it makes sense to apply this until we have at least the
basics of the POWER9 PAPR pieces implemented in qemu.

> ---
>  hw/ppc/spapr_cpu_core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> index 9dddaeb..71253f9 100644
> --- a/hw/ppc/spapr_cpu_core.c
> +++ b/hw/ppc/spapr_cpu_core.c
> @@ -360,6 +360,9 @@ static const char *spapr_core_models[] = {
>  
>      /* POWER8NVL */
>      "POWER8NVL_v1.0",
> +
> +    /* POWER9 */
> +    "POWER9_v1.0",
>  };
>  
>  void spapr_cpu_core_class_init(ObjectClass *oc, void *data)
Thomas Huth Jan. 10, 2017, 7:46 a.m. UTC | #2
On 10.01.2017 01:39, David Gibson wrote:
> On Mon, Jan 09, 2017 at 01:57:24PM +0100, Thomas Huth wrote:
>> Running "qemu-system-ppc64 -M pseries -cpu POWER9" currently does not work
>> yet and results in this error message:
>>
>>  qemu-system-ppc64: Unable to find sPAPR CPU Core definition
>>
>> Since we want to support the pseries machine with POWER9 in the future,
>> allow using POWER9 as hot-pluggable CPU there, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> I'm not sure it makes sense to apply this until we have at least the
> basics of the POWER9 PAPR pieces implemented in qemu.

OK, then I'll keep it in my private branch for my experiments...

 Thomas
diff mbox

Patch

diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
index 9dddaeb..71253f9 100644
--- a/hw/ppc/spapr_cpu_core.c
+++ b/hw/ppc/spapr_cpu_core.c
@@ -360,6 +360,9 @@  static const char *spapr_core_models[] = {
 
     /* POWER8NVL */
     "POWER8NVL_v1.0",
+
+    /* POWER9 */
+    "POWER9_v1.0",
 };
 
 void spapr_cpu_core_class_init(ObjectClass *oc, void *data)