From patchwork Fri Dec 2 11:28:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasad Pandit X-Patchwork-Id: 701934 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tVX3b21Kbz9t0t for ; Fri, 2 Dec 2016 22:28:58 +1100 (AEDT) Received: from localhost ([::1]:33900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCm1Q-0003vz-7Y for incoming@patchwork.ozlabs.org; Fri, 02 Dec 2016 06:28:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCm0q-0003eV-7b for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:28:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCm0m-0001oG-8x for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:28:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58692) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cCm0m-0001o5-2o for qemu-devel@nongnu.org; Fri, 02 Dec 2016 06:28:16 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBC2166CB3; Fri, 2 Dec 2016 11:28:14 +0000 (UTC) Received: from javelin.localdomain (vpn1-7-67.sin2.redhat.com [10.67.7.67]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB2BSA5Z018446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 2 Dec 2016 06:28:12 -0500 From: P J P To: Qemu Developers Date: Fri, 2 Dec 2016 16:58:08 +0530 Message-Id: <1480678088-21464-1-git-send-email-ppandit@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 02 Dec 2016 11:28:14 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] net: virtio-net: initialise local 'netcfg' variable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Azureyang , Jason Wang , Prasad J Pandit Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Prasad J Pandit Local 'netcfg' variable in 'virtio_net_get_config' routine was not initialised. It could leak uninitialised 'netcfg.mtu' field memory. Initialise 'netcfg' to avoid it. Reported-by: Azureyang Signed-off-by: Prasad J Pandit --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 01f1351..cb5b3dc 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -72,7 +72,7 @@ static int vq2q(int queue_index) static void virtio_net_get_config(VirtIODevice *vdev, uint8_t *config) { VirtIONet *n = VIRTIO_NET(vdev); - struct virtio_net_config netcfg; + struct virtio_net_config netcfg = {}; virtio_stw_p(vdev, &netcfg.status, n->status); virtio_stw_p(vdev, &netcfg.max_virtqueue_pairs, n->max_queues);