From patchwork Wed Nov 23 13:01:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 698254 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tP33h6f7Rz9t0v for ; Thu, 24 Nov 2016 00:25:04 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="xnVH4Mq1"; dkim-atps=neutral Received: from localhost ([::1]:33757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9XXq-0000NM-N7 for incoming@patchwork.ozlabs.org; Wed, 23 Nov 2016 08:25:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9XCg-0007OH-NC for qemu-devel@nongnu.org; Wed, 23 Nov 2016 08:03:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9XCf-0004Y9-OW for qemu-devel@nongnu.org; Wed, 23 Nov 2016 08:03:10 -0500 Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:33390) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9XCf-0004Y3-KB for qemu-devel@nongnu.org; Wed, 23 Nov 2016 08:03:09 -0500 Received: by mail-oi0-x244.google.com with SMTP id f201so920179oib.0 for ; Wed, 23 Nov 2016 05:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=P4C9rxy6WYJRPWKeZlQOCbFn6SuLkM1fCyZsz4EcKJI=; b=xnVH4Mq1Ca6INMAdEIRaANmYdx6DXubduFVBvgMd5Q0pB4T/vJkjERiG4FujACpLUD LVEngu0nWo/9FTG4AGPN87EIHCquQKxvvo5KVtCoQnD3DaBiQWJ1Lsmyqg3irXPsMi4p 7VSNXkzH6AEkwN8p72Hs5Nz7WFxg0Jmty2pyKZZyE9RiRDo2yXSgTN214kkd5NbwKoiP ije5ij05laQigVS1WjfVs3fS6UhXT21TYMnqwuKKYbOskmE2180lW2m05Hhb08VS0u8a KkV+UvCyDbX78qv5MqfSnAE3c/R0qbjL7WoPfbtnth42iw0b6Ys6ZRjpVlDZYA03GTY0 qOqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=P4C9rxy6WYJRPWKeZlQOCbFn6SuLkM1fCyZsz4EcKJI=; b=SSvnoTyeU6ABaqtPeHZw3V1tGG8VKUvO942SSzQVyJ+axcar/Z39fJieGmbvJho/HY GxNeC3e+7XylFMZgIu5H2CqiSb0sha4CgtL3hHOwg2a8+XOdn6+h03uC0IS0DuUS8mT+ qUnGFLuZWZ6MTrGtkxaVA59gEquVvF35WJHWGZ8ZlxpulLLfTEk4vtYlIXFwYGgeaaId jnv/nfw4wPk6fmhUDy1nxyktUK3cX/fKsxjeg7XMCgvW1mKnCS89W4Sfcv+309fmb9lR VB/LESmmtQ+D6yS4IZwhFztnClJLpX+4SOtZsL//L9zY3zGXQJRF7KWZi//keb9JL3P3 OwQA== X-Gm-Message-State: AKaTC00QHURcRnmDobVF7+6GUOgyRINoJ/JGn1Gmo79qe7fnokjtdCKcU6M/f5DNgYOdeQ== X-Received: by 10.157.40.79 with SMTP id h15mr1789682otd.39.1479906188987; Wed, 23 Nov 2016 05:03:08 -0800 (PST) Received: from bigtime.twiddle.net.twiddle.net ([172.56.6.66]) by smtp.gmail.com with ESMTPSA id t184sm10260000oie.21.2016.11.23.05.03.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 05:03:08 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 23 Nov 2016 14:01:13 +0100 Message-Id: <1479906121-12211-17-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1479906121-12211-1-git-send-email-rth@twiddle.net> References: <1479906121-12211-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::244 Subject: [Qemu-devel] [PATCH v4 16/64] target-mips: Use the new extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Use extract for EXT and DEXT. Reviewed-by: Yongbok Kim Signed-off-by: Richard Henderson --- target-mips/translate.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index d8dde7a..cf79aa4 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -4484,11 +4484,12 @@ static void gen_bitops (DisasContext *ctx, uint32_t opc, int rt, if (lsb + msb > 31) { goto fail; } - tcg_gen_shri_tl(t0, t1, lsb); if (msb != 31) { - tcg_gen_andi_tl(t0, t0, (1U << (msb + 1)) - 1); + tcg_gen_extract_tl(t0, t1, lsb, msb + 1); } else { - tcg_gen_ext32s_tl(t0, t0); + /* The two checks together imply that lsb == 0, + so this is a simple sign-extension. */ + tcg_gen_ext32s_tl(t0, t1); } break; #if defined(TARGET_MIPS64) @@ -4503,10 +4504,7 @@ static void gen_bitops (DisasContext *ctx, uint32_t opc, int rt, if (lsb + msb > 63) { goto fail; } - tcg_gen_shri_tl(t0, t1, lsb); - if (msb != 63) { - tcg_gen_andi_tl(t0, t0, (1ULL << (msb + 1)) - 1); - } + tcg_gen_extract_tl(t0, t1, lsb, msb + 1); break; #endif case OPC_INS: