| Message ID | 1477499426-9550-3-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Wed, 26 Oct 2016 14:30:20 -0200 Eduardo Habkost <ehabkost@redhat.com> wrote: > Use &error_abort so we don't ignore any errors on the property > registration calls. a similar patch for other *property_add* calls in that file would be nice addition on top, so *property_add* calls would be treated consistently. > > Reviewed-by: Andreas Färber <afaerber@suse.de> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > tests/check-qom-proplist.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > index 693dc4c..a92acc9 100644 > --- a/tests/check-qom-proplist.c > +++ b/tests/check-qom-proplist.c > @@ -123,7 +123,7 @@ static void dummy_init(Object *obj) > object_property_add_bool(obj, "bv", > dummy_get_bv, > dummy_set_bv, > - NULL); > + &error_abort); > } > > > @@ -132,13 +132,13 @@ static void dummy_class_init(ObjectClass *cls, void *data) > object_class_property_add_str(cls, "sv", > dummy_get_sv, > dummy_set_sv, > - NULL); > + &error_abort); > object_class_property_add_enum(cls, "av", > "DummyAnimal", > dummy_animal_map, > dummy_get_av, > dummy_set_av, > - NULL); > + &error_abort); > } > >
diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c index 693dc4c..a92acc9 100644 --- a/tests/check-qom-proplist.c +++ b/tests/check-qom-proplist.c @@ -123,7 +123,7 @@ static void dummy_init(Object *obj) object_property_add_bool(obj, "bv", dummy_get_bv, dummy_set_bv, - NULL); + &error_abort); } @@ -132,13 +132,13 @@ static void dummy_class_init(ObjectClass *cls, void *data) object_class_property_add_str(cls, "sv", dummy_get_sv, dummy_set_sv, - NULL); + &error_abort); object_class_property_add_enum(cls, "av", "DummyAnimal", dummy_animal_map, dummy_get_av, dummy_set_av, - NULL); + &error_abort); }