From patchwork Wed Oct 26 16:15:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 687222 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3t3wrB1cSDz9sQw for ; Thu, 27 Oct 2016 03:45:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=kREHy7Zn; dkim-atps=neutral Received: from localhost ([::1]:36050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzRKh-00021b-Ge for incoming@patchwork.ozlabs.org; Wed, 26 Oct 2016 12:45:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzQt2-0002zo-23 for qemu-devel@nongnu.org; Wed, 26 Oct 2016 12:17:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzQt1-0002Vf-6x for qemu-devel@nongnu.org; Wed, 26 Oct 2016 12:17:08 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:37938) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzQt1-0002VE-2Q for qemu-devel@nongnu.org; Wed, 26 Oct 2016 12:17:07 -0400 Received: by mail-qk0-x241.google.com with SMTP id w69so562499qka.5 for ; Wed, 26 Oct 2016 09:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=5y3akpd9ts8dgSqRIwg/lbD69NA36NTYG80NtyxUhzU=; b=kREHy7Znhhkr3i6fBiLdJ13ghZ4TgZ7xBuiiYC8tzClOB85hDn+4i3mIdeJc+Q4xSm TV1YEXxHOAivHpBukOeGQmfCxsCL6RUMWiatjBIrQNmFE/RPdbVC50H6Y3FQdNSKOdhI jc2TKYDIpVPs8MRjo0kUFQZOWctvI0ZVWa41KykmkNJ3+qzkd7uzCmqalWe6+26FDcVn s2AwFgAf5AYCujJjv//LMkeoh3h1hMm7rC1Afoa83MuX0Uz4s5eOp274NTgvlvxZQVvd YRBqqRGQNKNCjxUSh5jnHAewkDs5kykdZdqvjnWO7ijmUcNy6mYvX+6a+NbFais2020c at9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=5y3akpd9ts8dgSqRIwg/lbD69NA36NTYG80NtyxUhzU=; b=m6ZZ3O9WkiXV3EaWMX+lK0uvOgu/DNpCc+melJfkSzfYkVa2OmxJigNkMGYbHFal1h FFWWi6wuvogtqbH1/zgojMNPEk6m1Q/roBQ9NuNRL4UsOZG5Ms8iF/xIrZgL/4AadOGy K7WlemadVgBLRXzjF++YjfHc34RbGvk00W4diLIQYSsCssKHz03OZoLxhT1huo6LkFFe rbv5O3O24h6hzFQ1bEMqxo7gi8JQBEFsVyNYMLYTmh0qOz0LLOM09ZmNWxy30MeHUbYH wkPqG+wdTeLfwuslag4jPdFfxXGDlSEZ4s6mOeUQYa6YEifDSGYMtm/X12w+BS9zVczp htCw== X-Gm-Message-State: ABUngvdQTzdkdJBNYv6rf6uuWm8SkTZSQNgIkHDMN5AUWmv2L5j2nR8t4OL7y6WolwP5JQ== X-Received: by 10.55.41.159 with SMTP id p31mr2344008qkp.212.1477498626612; Wed, 26 Oct 2016 09:17:06 -0700 (PDT) Received: from bigtime.com (174-24-157-40.tukw.qwest.net. [174.24.157.40]) by smtp.gmail.com with ESMTPSA id e185sm1337941qkd.13.2016.10.26.09.17.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Oct 2016 09:17:05 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 26 Oct 2016 09:15:52 -0700 Message-Id: <1477498563-29091-27-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477498563-29091-1-git-send-email-rth@twiddle.net> References: <1477498563-29091-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PULL v2 26/37] target-i386: emulate XCHG using atomic helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, "Emilio G. Cota" Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-19-git-send-email-cota@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index b3cb4c5..cfa3956 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -5564,12 +5564,8 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, gen_lea_modrm(env, s, modrm); gen_op_mov_v_reg(ot, cpu_T0, reg); /* for xchg, lock is implicit */ - if (!(prefixes & PREFIX_LOCK)) - gen_helper_lock(); - gen_op_ld_v(s, ot, cpu_T1, cpu_A0); - gen_op_st_v(s, ot, cpu_T0, cpu_A0); - if (!(prefixes & PREFIX_LOCK)) - gen_helper_unlock(); + tcg_gen_atomic_xchg_tl(cpu_T1, cpu_A0, cpu_T0, + s->mem_index, ot | MO_LE); gen_op_mov_reg_v(ot, reg, cpu_T1); } break;