From patchwork Fri Sep 9 19:14:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashijeet Acharya X-Patchwork-Id: 668199 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sW6Pc6cBkz9ryk for ; Sat, 10 Sep 2016 05:16:18 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=rl6Vwrmt; dkim-atps=neutral Received: from localhost ([::1]:59833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biRHZ-0004Ig-Aj for incoming@patchwork.ozlabs.org; Fri, 09 Sep 2016 15:16:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biRGv-00041A-5i for qemu-devel@nongnu.org; Fri, 09 Sep 2016 15:15:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biRGo-0004LR-Tf for qemu-devel@nongnu.org; Fri, 09 Sep 2016 15:15:31 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:33103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biRGo-0004LE-Mt for qemu-devel@nongnu.org; Fri, 09 Sep 2016 15:15:26 -0400 Received: by mail-pf0-x241.google.com with SMTP id 128so4390703pfb.0 for ; Fri, 09 Sep 2016 12:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=nbGhtNUE6dWEIxpkuk2NtmucofmqeCXVqLnJ8cR6yy4=; b=rl6VwrmtLar/Yr8UY7ztutdlgl2knpfKclEZzpY2PHoI/PNX2/B6G5W3R5PcPKRALm FQ5wl2I2b4/LaUNFmxdAVJ6wS32iNj+1cjn7+8DSLN4WjLMxfKYbOhOoFZYuu1LXVJTp p7HoVUpPGguAY9g72XPi/QQSV49gYvNBazfbnW6aF+FUkbszgMUGeot7T8lAqcQX5bs4 WvY+Uu+OxNhRmwUmNXN9jurd5iTkoh/xDUzNwHuw1r7J/1lrYDtXsQARNM+gxXkpsD6w seLztC6zu98ymmOmy0AZeftY5/0V0q43MTtJnrBsyNT6f0rMW8mAlxaD3Yilc2f6zlTO jvyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nbGhtNUE6dWEIxpkuk2NtmucofmqeCXVqLnJ8cR6yy4=; b=g88JCDer5TdAyzGqY2bKiVSV9gylXqPB4dyBZNv3zcDgRcIANn1v2OZux398B1sgCk tM5/AOYcakbBebcpU+GPPwmCKsK2imty6aVEOc/KJ84tyZ/SqJEco4hNOdYV4AVpiwOL 1RQTP4Gqo4kZEN5b47yDY6dL4J1XHmfdZoPP7KrqpHlh+KKoF+ZN2M1YNdzOz7WiFfw4 z6rlZLxTY2F8F2Y56VouJka5GzQQ8EYC1OqLtEi2t2JIY0tzs1AinFAauzaq1eDasA3a xT+so96JxybhfUk/BSiGNAtdTdIRe7T3XrhyuPle3/AvAjuGtx1SMwerZlfWJWP3mjBN mpvg== X-Gm-Message-State: AE9vXwPv2rvXpcgbfDcvr5nvi/tO37gkJbCKb4zPulJwF8fFsRlOlcarYHSz1n9RtYcF3Q== X-Received: by 10.98.100.73 with SMTP id y70mr9388409pfb.84.1473448526017; Fri, 09 Sep 2016 12:15:26 -0700 (PDT) Received: from linux.local ([106.208.12.73]) by smtp.gmail.com with ESMTPSA id i135sm6439103pfe.17.2016.09.09.12.15.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Sep 2016 12:15:25 -0700 (PDT) From: Ashijeet Acharya To: quintela@redhat.com Date: Sat, 10 Sep 2016 00:44:02 +0530 Message-Id: <1473448442-29510-1-git-send-email-ashijeetacharya@gmail.com> X-Mailer: git-send-email 2.6.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH] migrate: Fix bounds check for migration parameters in migration.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.shah@redhat.com, dgilbert@redhat.com, Ashijeet Acharya , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This patch fixes the out-of-bounds check migration parameters in qmp_migrate_set_parameters() for cpu-throttle-initial and cpu-throttle-increment by adding a return statement for both. Due to the missing return statements, parmaters were getting set to out-of-bounds values despite the error. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake Reviewed-by: Amit Shah --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 9b4aa55..cd8334c 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -805,6 +805,7 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp) error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu_throttle_initial", "an integer in the range of 1 to 99"); + return; } if (params->has_cpu_throttle_increment && (params->cpu_throttle_increment < 1 || @@ -812,6 +813,7 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp) error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu_throttle_increment", "an integer in the range of 1 to 99"); + return; } if (params->has_max_bandwidth && (params->max_bandwidth < 0 || params->max_bandwidth > SIZE_MAX)) {