From patchwork Fri Aug 26 03:18:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhangshuai X-Patchwork-Id: 662986 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sL5rn142gz9s4x for ; Fri, 26 Aug 2016 13:20:08 +1000 (AEST) Received: from localhost ([::1]:58904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bd7gb-00033W-9X for incoming@patchwork.ozlabs.org; Thu, 25 Aug 2016 23:20:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bd7ft-0002lm-OX for qemu-devel@nongnu.org; Thu, 25 Aug 2016 23:19:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bd7fp-0005py-IS for qemu-devel@nongnu.org; Thu, 25 Aug 2016 23:19:20 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:47176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bd7fo-0005pP-T7 for qemu-devel@nongnu.org; Thu, 25 Aug 2016 23:19:17 -0400 Received: from 172.24.1.36 (EHLO szxeml430-hub.china.huawei.com) ([172.24.1.36]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DME39773; Fri, 26 Aug 2016 11:18:56 +0800 (CST) Received: from localhost (10.177.22.203) by szxeml430-hub.china.huawei.com (10.82.67.185) with Microsoft SMTP Server id 14.3.235.1; Fri, 26 Aug 2016 11:18:47 +0800 From: zhangshuai To: Date: Fri, 26 Aug 2016 11:18:22 +0800 Message-ID: <1472181502-6588-1-git-send-email-zhangshuai13@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.0 MIME-Version: 1.0 X-Originating-IP: [10.177.22.203] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.57BFB523.0001, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 26d30f08d45ed835196b798a14f2eb80 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.65 Subject: [Qemu-devel] [PATCH] libqos: fix bugs in qvirtqueue_kick() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lina.lulina@huawei.com, zhangshuai13@huawei.com, subo7@huawei.com, kathy.wangting@huawei.com, eric.fangyi@huawei.com, qemu-devel@nongnu.org, wu.wubin@huawei.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Zhang Shuai The idx and ring[] of vring_avail is 16-bit, but the writel is 32-bit, the second writel will cover the ring[free_head] with 0. So use writew to replace writel to fix the bug. Signed-off-by: zhangshuai --- tests/libqos/virtio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c index d8c2970..801690f 100644 --- a/tests/libqos/virtio.c +++ b/tests/libqos/virtio.c @@ -264,9 +264,9 @@ void qvirtqueue_kick(const QVirtioBus *bus, QVirtioDevice *d, QVirtQueue *vq, uint16_t avail_event; /* vq->avail->ring[idx % vq->size] */ - writel(vq->avail + 4 + (2 * (idx % vq->size)), free_head); + writew(vq->avail + 4 + (2 * (idx % vq->size)), free_head); /* vq->avail->idx */ - writel(vq->avail + 2, idx + 1); + writew(vq->avail + 2, idx + 1); /* Must read after idx is updated */ flags = readw(vq->avail);