Message ID | 1470166775-3671-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 2 August 2016 at 20:39, Paolo Bonzini <pbonzini@redhat.com> wrote: > The following changes since commit cc0100f464c94bf80ad36cd432f4a1ed58126b60: > > MAINTAINERS: Update the Xilinx maintainers (2016-08-01 15:31:32 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 3531bd22792beae5eba181bf88337d2ff1444817: > > util: Fix assertion in iov_copy() upon zero 'bytes' and non-zero 'offset' (2016-08-02 15:00:26 +0200) > > ---------------------------------------------------------------- > * xsetbv fix (x86 targets TCG) > * remove unused functions > * qht segfault and memory leak fixes > * NBD fixes > * Fix for non-power-of-2 discard granularity > * Memory hotplug fixes > * Migration regressions > * IOAPIC fixes and (disabled by default) EOI register support > * Various other small fixes > > ---------------------------------------------------------------- Hi. I'm afraid this doesn't build with our minimum glib version: /Users/pm215/src/qemu-for-merges/util/qdist.c:67:25: warning: implicit declaration of function 'g_realloc_n' is invalid in C99 [-Wimplicit-function-declaration] dist->entries = g_realloc_n(dist->entries, dist->size, ^ g_realloc_n() only appeared in glib 2.24, and our minimum is 2.22. thanks -- PMM
On 03/08/2016 12:52, Peter Maydell wrote: > On 2 August 2016 at 20:39, Paolo Bonzini <pbonzini@redhat.com> wrote: >> The following changes since commit cc0100f464c94bf80ad36cd432f4a1ed58126b60: >> >> MAINTAINERS: Update the Xilinx maintainers (2016-08-01 15:31:32 +0100) >> >> are available in the git repository at: >> >> git://github.com/bonzini/qemu.git tags/for-upstream >> >> for you to fetch changes up to 3531bd22792beae5eba181bf88337d2ff1444817: >> >> util: Fix assertion in iov_copy() upon zero 'bytes' and non-zero 'offset' (2016-08-02 15:00:26 +0200) >> >> ---------------------------------------------------------------- >> * xsetbv fix (x86 targets TCG) >> * remove unused functions >> * qht segfault and memory leak fixes >> * NBD fixes >> * Fix for non-power-of-2 discard granularity >> * Memory hotplug fixes >> * Migration regressions >> * IOAPIC fixes and (disabled by default) EOI register support >> * Various other small fixes >> >> ---------------------------------------------------------------- > > Hi. I'm afraid this doesn't build with our minimum glib version: > > /Users/pm215/src/qemu-for-merges/util/qdist.c:67:25: warning: implicit > declaration of function 'g_realloc_n' is invalid in C99 > [-Wimplicit-function-declaration] > dist->entries = g_realloc_n(dist->entries, dist->size, > ^ > > g_realloc_n() only appeared in glib 2.24, and our minimum > is 2.22. Oops, it should use g_new and g_renew instead. Paolo