From patchwork Tue Aug 2 15:57:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 654964 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3s3gqQ15l8z9tmm for ; Wed, 3 Aug 2016 01:58:57 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=wrkLo74s; dkim-atps=neutral Received: from localhost ([::1]:57384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUc5n-00017U-9O for incoming@patchwork.ozlabs.org; Tue, 02 Aug 2016 11:58:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUc5A-0000dL-3n for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:58:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUc56-0006Jt-1L for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:58:16 -0400 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]:34069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUc55-0006Jg-S7 for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:58:11 -0400 Received: by mail-oi0-x243.google.com with SMTP id c199so17271200oig.1 for ; Tue, 02 Aug 2016 08:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=41Yy8Hb+uJmg6krPPqZ2d3oQps0AVHDFdJ4M/zamT7o=; b=wrkLo74sNXa1/WmSRXDCAow+SLvCdT46aq1tUET46lGsNchxXNzpSmFal72bJDjLAi Dbx0jTgC1AqV8Wy/JWbT+c1dVkJrEPTfJ1ELfTI86EApWyG0ZkVlUi7HXucf6JmDUmeq uzB6QhumlpvpmiimbOjk2gnnJYvvd2XgNNJRnxJwz4gpxefHD2AE16pgxAfP8PYR/Gp9 WKSR4/w+waNECdm9s9eEKTKK0whYDWGenuEyr6Yoms8nLf7EdT7Z/FHm/UkXJyh/l3t6 DSZyKWU9phy+xleKgUaFQR9JrS2dmESRTDwwKQOfN27Z4Lgpt2BObl5QbPMg0NRBflJ+ SbEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=41Yy8Hb+uJmg6krPPqZ2d3oQps0AVHDFdJ4M/zamT7o=; b=Fmjthz1/J7YEEd+wgvKrFENQTqwuKMBqhxfFXa/yJvsNk7dK57P3oR6NesJxyFLeAG fJbw1yPRbosWNJQWWg4Iquxr3bjPNxiY8W/aePirR2G2+sVbeEJjFCtXWpLK5nbIPMJ6 BCUQ4ZuFGLEx8ldr15TXg+Go38z4IO3741W/8SxrWs+hIGbmoePHwE2Hwe/TNfTGclqK BtYb+/Wz0OjpYUCffhIN85CWUPm+3UVzMnG3+7ZZQF5Ug3eiwtN8N6wQFc381pNjoRir MVYH7ZUBkrSxdTm0mBj7aN6ItJgyr9+Iiiwe4pDPqY+NdTKTmZ9nVxuQtazkrne+P92a HqTw== X-Gm-Message-State: AEkooutQJB5gvhNd66eTf9p+DV86lIqymQ4CdXsIoxXON6V704d9tgwcgIxUZ1ddXBWBjA== X-Received: by 10.202.205.151 with SMTP id d145mr35102996oig.127.1470153490888; Tue, 02 Aug 2016 08:58:10 -0700 (PDT) Received: from serve.minyard.net ([173.64.235.97]) by smtp.gmail.com with ESMTPSA id y85sm1513679oie.4.2016.08.02.08.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Aug 2016 08:58:09 -0700 (PDT) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id D26826D3; Tue, 2 Aug 2016 10:58:08 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 4947930053D; Tue, 2 Aug 2016 10:58:08 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org, minyard@acm.org Date: Tue, 2 Aug 2016 10:57:59 -0500 Message-Id: <1470153479-6507-1-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::243 Subject: [Qemu-devel] [PATCH v2] ipmi: Remove hotplug from IPMI BMCs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard No hotplug support, make sure it doesn't happen. Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_extern.c | 1 + hw/ipmi/ipmi_bmc_sim.c | 1 + 2 files changed, 2 insertions(+) I think this is ready to go, can we get it in? diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 157879e..ebd0d8d 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -499,6 +499,7 @@ static void ipmi_bmc_extern_class_init(ObjectClass *oc, void *data) bk->handle_command = ipmi_bmc_extern_handle_command; bk->handle_reset = ipmi_bmc_extern_handle_reset; + dc->hotpluggable = false; dc->realize = ipmi_bmc_extern_realize; dc->props = ipmi_bmc_extern_properties; } diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index dc9c14c..190e169 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -1791,6 +1791,7 @@ static void ipmi_sim_class_init(ObjectClass *oc, void *data) DeviceClass *dc = DEVICE_CLASS(oc); IPMIBmcClass *bk = IPMI_BMC_CLASS(oc); + dc->hotpluggable = false; dc->realize = ipmi_sim_realize; bk->handle_command = ipmi_sim_handle_command; }