From patchwork Thu Jul 28 22:33:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 653894 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3s0mrR2Ddvz9t0j for ; Fri, 29 Jul 2016 08:34:46 +1000 (AEST) Received: from localhost ([::1]:56058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bStt6-0002aE-0c for incoming@patchwork.ozlabs.org; Thu, 28 Jul 2016 18:34:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bStsN-00022p-IY for qemu-devel@nongnu.org; Thu, 28 Jul 2016 18:34:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bStsJ-0001VF-Du for qemu-devel@nongnu.org; Thu, 28 Jul 2016 18:33:58 -0400 Received: from gate.crashing.org ([63.228.1.57]:51563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bStsJ-0001VB-3g; Thu, 28 Jul 2016 18:33:55 -0400 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id u6SMXjlK018598; Thu, 28 Jul 2016 17:33:47 -0500 Message-ID: <1469745225.5978.236.camel@kernel.crashing.org> From: Benjamin Herrenschmidt To: qemu-ppc@nongnu.org Date: Fri, 29 Jul 2016 08:33:45 +1000 X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 63.228.1.57 Subject: [Qemu-devel] [PATCH] ppc: Some FPU helper functions must be inline X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-devel@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" float_invalid_op_excp() and float_check_status() must be inline due to their use of GETPC(). Use __attribute__((__always_inline__)) to enforce it Signed-off-by: Benjamin Herrenschmidt --- target-ppc/fpu_helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c index 65dc170..b0760f0 100644 --- a/target-ppc/fpu_helper.c +++ b/target-ppc/fpu_helper.c @@ -117,8 +117,8 @@ void helper_compute_fprf(CPUPPCState *env, uint64_t arg) } /* Floating-point invalid operations exception */ -static inline uint64_t float_invalid_op_excp(CPUPPCState *env, int op, - int set_fpcc) +static inline __attribute__((__always_inline__)) +uint64_t float_invalid_op_excp(CPUPPCState *env, int op, int set_fpcc) { CPUState *cs = CPU(ppc_env_get_cpu(env)); uint64_t ret = 0; @@ -519,7 +519,8 @@ static void do_float_check_status(CPUPPCState *env, uintptr_t raddr) } } -static inline void float_check_status(CPUPPCState *env) +static inline __attribute__((__always_inline__)) +void float_check_status(CPUPPCState *env) { /* GETPC() works here because this is inline */ do_float_check_status(env, GETPC());