From patchwork Wed Jul 27 15:21:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 653401 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rzzK009Pcz9t1w for ; Thu, 28 Jul 2016 01:23:16 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=L36A0RPp; dkim-atps=neutral Received: from localhost ([::1]:47082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSQfx-0005gN-PQ for incoming@patchwork.ozlabs.org; Wed, 27 Jul 2016 11:23:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSQf2-00054d-3x for qemu-devel@nongnu.org; Wed, 27 Jul 2016 11:22:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSQf0-0002J2-6a for qemu-devel@nongnu.org; Wed, 27 Jul 2016 11:22:15 -0400 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:35735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSQf0-0002In-26 for qemu-devel@nongnu.org; Wed, 27 Jul 2016 11:22:14 -0400 Received: by mail-oi0-x242.google.com with SMTP id w143so1614273oiw.2 for ; Wed, 27 Jul 2016 08:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=yn1H+S+4g/toh6peDuHP88xFLPTzB6VL8fuqJ2lMMBU=; b=L36A0RPpZUbWYpKsRZuzHMDkYDpJFR4dZhBLjT+9WKSznEd/14Q3sgSFIaUS2k83kc mdFEs0iZmqHKOiPB3eotjsCrRnaavgbx6553prMtWT4Zi1ivL1CCf1iH8N0wArTjRJ3u 4mmXXkvDG07btk7SKunD8Uw7370qlV60+5y7i/b6BvXJXMM3pX88yXf3aJgRLmjTZiai 9YKm4p7bO2j3obC1xja5EQxcWwk27h8cUXcXNGhAhdbVu4fgeaBl9k5BDQyQ48ydhB9W uBRUdczOKSMvo2rPou+nALR9+DoNjn0d0LNas97vuGxWOX9Sp33f0ahn8dwJnie4EEG0 cQRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=yn1H+S+4g/toh6peDuHP88xFLPTzB6VL8fuqJ2lMMBU=; b=kIyptB02Mayg4sCVi2flJ6vgu0OTp+dylsx8wiWsJxZBCspvjjXvRyfT15knAPzez6 s5Dl3OF1v6vEDP1U7bEQtci0o5cWYmC88HyUIt7vQBe84qbWMPfhA06sE/J2EVLlTt9P GXvU2HTBjCKNY2UIPfXHLIk2Jz2w97fZCPP6aE8GUx5kYKx2uwUZt01t+UalMOkzGFAl rN775ezOXSLDoGEqGxX6SEkGd3TA7m8vdkohTzAu+OaTr5apjgzvMYsdPmu1EgNtRcwX JTtt4S66DsXHw7Y14sC6GuKYo+/hZBUghNBxMrUJmAd5rnVSlbN3UgPbHCdiCk0JQPrj zbTA== X-Gm-Message-State: AEkooushtSsyBTFAPdniA31fQApTujjgYiY6slKz7AEwo9GegvFZzKh3NyUnUJxEX24oxQ== X-Received: by 10.157.51.86 with SMTP id u22mr18177399otd.74.1469632933201; Wed, 27 Jul 2016 08:22:13 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id e8sm374758otd.7.2016.07.27.08.22.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jul 2016 08:22:12 -0700 (PDT) Received: from t430.minyard.net (unknown [IPv6:2001:470:b8f6:1b:5c:90a8:bcd5:f017]) by serve.minyard.net (Postfix) with ESMTPA id 4DDC19D; Wed, 27 Jul 2016 10:22:11 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 8532230053D; Wed, 27 Jul 2016 10:22:10 -0500 (CDT) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Wed, 27 Jul 2016 10:21:56 -0500 Message-Id: <1469632916-28595-1-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::242 Subject: [Qemu-devel] [PATCH] ipmi: Remove hotplug from IPMI BMCs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , minyard@acm.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard No hotplug support, make sure it doesn't happen. Signed-off-by: Corey Minyard Reviewed-by: Marc-André Lureau --- hw/ipmi/ipmi_bmc_extern.c | 1 + hw/ipmi/ipmi_bmc_sim.c | 1 + 2 files changed, 2 insertions(+) This is my proposed patch instead of "ipmi:free extern timer" send by Marc-Andre. diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 157879e..ebd0d8d 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -499,6 +499,7 @@ static void ipmi_bmc_extern_class_init(ObjectClass *oc, void *data) bk->handle_command = ipmi_bmc_extern_handle_command; bk->handle_reset = ipmi_bmc_extern_handle_reset; + dc->hotpluggable = false; dc->realize = ipmi_bmc_extern_realize; dc->props = ipmi_bmc_extern_properties; } diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index dc9c14c..190e169 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -1791,6 +1791,7 @@ static void ipmi_sim_class_init(ObjectClass *oc, void *data) DeviceClass *dc = DEVICE_CLASS(oc); IPMIBmcClass *bk = IPMI_BMC_CLASS(oc); + dc->hotpluggable = false; dc->realize = ipmi_sim_realize; bk->handle_command = ipmi_sim_handle_command; }