From patchwork Fri Jul 15 08:41:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 648714 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rrR0G2J3Zz9s65 for ; Fri, 15 Jul 2016 18:42:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=XaTTI+BH; dkim-atps=neutral Received: from localhost ([::1]:59184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNyhe-0003Zx-Fk for incoming@patchwork.ozlabs.org; Fri, 15 Jul 2016 04:42:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNyh2-0003HF-19 for qemu-devel@nongnu.org; Fri, 15 Jul 2016 04:41:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNygx-0000hG-UJ for qemu-devel@nongnu.org; Fri, 15 Jul 2016 04:41:55 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNygx-0000h8-Nq for qemu-devel@nongnu.org; Fri, 15 Jul 2016 04:41:51 -0400 Received: by mail-wm0-x243.google.com with SMTP id o80so1324254wme.0 for ; Fri, 15 Jul 2016 01:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=fdjhKcJXKjK6AKgZ86MGvF1f0cPi14JN4PcoRrsrNkw=; b=XaTTI+BH1FH+CgjpNsPUFxUtGZfoBvA+rzI8z4yV7boekgDOZa5kOKrrCri5BXdlzl 0xNaen9Gh/ugV+Mtz6Nfx1X5fNNeVEOgVNgv6na9WzWdJyutsjlk0w3eyO50H3FPOsGC 8UlNShW6k+mvBkB0VfsFAmuZqpiIJVzZr4BxR7Ij120JOf2IXtrjouJ4kpSsXblatI9l xW9EW6WlJMVvZN0eUe/Cz77IcFIP4P1+/SnYwUcYq8vVD9lIpxFpvPDHn/xYBtnq2ofJ ojgSocVQgtfMT20xKWf6dyTx+2sshlWSQhyytr/IpwdgN24oAmfxWoEy4LTb2ho8Ky6G +5Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=fdjhKcJXKjK6AKgZ86MGvF1f0cPi14JN4PcoRrsrNkw=; b=DOtC7qh01/Dpv+hdAF5r3ZqXkackPBdHOIFdrir1YGZ3Ysb78HneW1QwOChfjjSM8x Ym8e0pMrjn4wySuaTESsGI16dk5kSdTYq02yxFpojAtwQLWrSJ4SqITexCb3zwwjs9Rm /FRmC0rM4XMmSz9rxFXP4Un+gfye4fPvVFRuX1xvtFDckbSD9+f2OxJXNA5drz0oO6XV Uvm1FhMrzpcnNDNhD3ihzjrF1WutvnhLOuQKsyxPqfAPxUHX/QCMAMEKlkk2/og+MzQx pDVzrPQeQddW40O8c1eE/I7el3ogDanWTc5fxbbmE5+rFQUmUBlYD+mIWE2jlGs/rcJQ BqyQ== X-Gm-Message-State: ALyK8tJ/ZE6JlLUdJw1sxJroysmaYEqGBTSJQOdaiPuB9B2wDMHLhO6p3Ku7xW8LimjA3Q== X-Received: by 10.28.37.134 with SMTP id l128mr39690679wml.49.1468572110718; Fri, 15 Jul 2016 01:41:50 -0700 (PDT) Received: from donizetti.redhat.com (94-39-188-118.adsl-ull.clienti.tiscali.it. [94.39.188.118]) by smtp.gmail.com with ESMTPSA id g67sm4571160wme.5.2016.07.15.01.41.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 01:41:49 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 15 Jul 2016 10:41:47 +0200 Message-Id: <1468572107-23977-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PATCH] net: fix incorrect argument to iov_to_buf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Coverity reports a "suspicious sizeof" which is indeed wrong. Signed-off-by: Paolo Bonzini --- net/eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/eth.c b/net/eth.c index 95fe15c..0be59c2 100644 --- a/net/eth.c +++ b/net/eth.c @@ -418,7 +418,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags, bytes_read = iov_to_buf(pkt, pkt_frags, rthdr_offset + sizeof(*ext_hdr), - dst_addr, sizeof(dst_addr)); + dst_addr, sizeof(*dst_addr)); return bytes_read == sizeof(dst_addr); } @@ -467,7 +467,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags, bytes_read = iov_to_buf(pkt, pkt_frags, opt_offset + sizeof(opthdr), - src_addr, sizeof(src_addr)); + src_addr, sizeof(*src_addr)); return bytes_read == sizeof(src_addr); }