| Message ID | 1467274674-27705-1-git-send-email-imammedo@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote: > 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore > added -id suffix to property names but forgot to fix example in qmp-commands.hx > > Fix example to have 'core-id' instead of 'core' to match current code > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > --- > qmp-commands.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Oops; thanks for cleaning up after me. Reviewed-by: Peter Krempa <pkrempa@redhat.com>
On Thu, Jun 30, 2016 at 10:30:53AM +0200, Peter Krempa wrote: > On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote: > > 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore > > added -id suffix to property names but forgot to fix example in qmp-commands.hx > > > > Fix example to have 'core-id' instead of 'core' to match current code > > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > --- > > qmp-commands.hx | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Oops; thanks for cleaning up after me. > > Reviewed-by: Peter Krempa <pkrempa@redhat.com> Applied to ppc-for-2.7, thanks.
diff --git a/qmp-commands.hx b/qmp-commands.hx index b444c20..6937e83 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -4978,8 +4978,8 @@ Example for pseries machine type started with -> { "execute": "query-hotpluggable-cpus" } <- {"return": [ - { "props": { "core": 8 }, "type": "POWER8-spapr-cpu-core", + { "props": { "core-id": 8 }, "type": "POWER8-spapr-cpu-core", "vcpus-count": 1 }, - { "props": { "core": 0 }, "type": "POWER8-spapr-cpu-core", + { "props": { "core-id": 0 }, "type": "POWER8-spapr-cpu-core", "vcpus-count": 1, "qom-path": "/machine/unattached/device[0]"} ]}'
27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore added -id suffix to property names but forgot to fix example in qmp-commands.hx Fix example to have 'core-id' instead of 'core' to match current code Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- qmp-commands.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)