From patchwork Tue May 10 02:05:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gonglei (Arei)" X-Patchwork-Id: 620845 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3r4CbJ5G5kz9t45 for ; Wed, 11 May 2016 07:50:04 +1000 (AEST) Received: from localhost ([::1]:49343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0FXW-0001B0-Hr for incoming@patchwork.ozlabs.org; Tue, 10 May 2016 17:50:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0FXE-0000bw-Pv for qemu-devel@nongnu.org; Tue, 10 May 2016 17:49:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0FXB-0000Dd-H8 for qemu-devel@nongnu.org; Tue, 10 May 2016 17:49:44 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:2297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0FXA-0000CN-TN for qemu-devel@nongnu.org; Tue, 10 May 2016 17:49:41 -0400 Received: from 172.24.2.61 (EHLO szxga01-in.huawei.com) ([172.24.2.61]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id COI51980; Tue, 10 May 2016 04:52:51 +0000 (GMT) Received: from 172.24.1.36 (EHLO szxeml430-hub.china.huawei.com) ([172.24.1.36]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DKH47786; Tue, 10 May 2016 10:05:18 +0800 (CST) Received: from localhost (10.177.18.62) by szxeml430-hub.china.huawei.com (10.82.67.185) with Microsoft SMTP Server id 14.3.235.1; Tue, 10 May 2016 10:05:09 +0800 From: Gonglei To: Date: Tue, 10 May 2016 10:05:01 +0800 Message-ID: <1462845901-89716-4-git-send-email-arei.gonglei@huawei.com> X-Mailer: git-send-email 2.6.3.windows.1 In-Reply-To: <1462845901-89716-1-git-send-email-arei.gonglei@huawei.com> References: <1462845901-89716-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.177.18.62] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.573141E0.006A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 566d93afc50b981ad8b13e204b079ec4 X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.57316924.0054, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 452c2023dbc4781e13ab05844a766648 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 194.213.3.17 Subject: [Qemu-devel] [PATCH v2 3/3] memory: drop some wrappers that waste cpu cycle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Gonglei , famz@redhat.com, peter.huangpeng@huawei.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" For better performance, we can use RAMblock directly stored in memory_region at present. Signed-off-by: Gonglei --- exec.c | 33 ++------------------------------- hw/misc/ivshmem.c | 8 +++++--- hw/virtio/vhost-user.c | 13 ++++++++----- include/exec/ram_addr.h | 4 +--- memory.c | 2 +- 5 files changed, 17 insertions(+), 43 deletions(-) diff --git a/exec.c b/exec.c index 117c9a8..f8de928 100644 --- a/exec.c +++ b/exec.c @@ -1812,38 +1812,9 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t length) } #endif /* !_WIN32 */ -int qemu_get_ram_fd(ram_addr_t addr) +void *qemu_get_ram_block_host_ptr(RAMBlock *ram_block) { - RAMBlock *block; - int fd; - - rcu_read_lock(); - block = qemu_get_ram_block(addr); - fd = block->fd; - rcu_read_unlock(); - return fd; -} - -void qemu_set_ram_fd(ram_addr_t addr, int fd) -{ - RAMBlock *block; - - rcu_read_lock(); - block = qemu_get_ram_block(addr); - block->fd = fd; - rcu_read_unlock(); -} - -void *qemu_get_ram_block_host_ptr(ram_addr_t addr) -{ - RAMBlock *block; - void *ptr; - - rcu_read_lock(); - block = qemu_get_ram_block(addr); - ptr = ramblock_ptr(block, 0); - rcu_read_unlock(); - return ptr; + return ramblock_ptr(ram_block, 0); } /* Return a host pointer to ram allocated with qemu_ram_alloc. diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index e40f23b..1e930fa 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -533,7 +533,9 @@ static void process_msg_shmem(IVShmemState *s, int fd, Error **errp) } memory_region_init_ram_ptr(&s->server_bar2, OBJECT(s), "ivshmem.bar2", size, ptr); - qemu_set_ram_fd(memory_region_get_ram_addr(&s->server_bar2), fd); + assert(s->server_bar2.ram_block); + s->server_bar2.ram_block->fd = fd; + s->ivshmem_bar2 = &s->server_bar2; } @@ -939,8 +941,8 @@ static void ivshmem_exit(PCIDevice *dev) error_report("Failed to munmap shared memory %s", strerror(errno)); } - - fd = qemu_get_ram_fd(memory_region_get_ram_addr(s->ivshmem_bar2)); + assert(s->ivshmem_bar2->ram_block); + fd = s->ivshmem_bar2->ram_block->fd; close(fd); } diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 5914e85..5082e04 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -248,17 +248,18 @@ static int vhost_user_set_mem_table(struct vhost_dev *dev, for (i = 0; i < dev->mem->nregions; ++i) { struct vhost_memory_region *reg = dev->mem->regions + i; ram_addr_t ram_addr; + MemoryRegion *mr; assert((uintptr_t)reg->userspace_addr == reg->userspace_addr); - qemu_ram_addr_from_host((void *)(uintptr_t)reg->userspace_addr, + mr = qemu_ram_addr_from_host((void *)(uintptr_t)reg->userspace_addr, &ram_addr); - fd = qemu_get_ram_fd(ram_addr); + fd = mr->ram_block->fd; if (fd > 0) { msg.payload.memory.regions[fd_num].userspace_addr = reg->userspace_addr; msg.payload.memory.regions[fd_num].memory_size = reg->memory_size; msg.payload.memory.regions[fd_num].guest_phys_addr = reg->guest_phys_addr; msg.payload.memory.regions[fd_num].mmap_offset = reg->userspace_addr - - (uintptr_t) qemu_get_ram_block_host_ptr(ram_addr); + (uintptr_t) qemu_get_ram_block_host_ptr(mr->ram_block); assert(fd_num < VHOST_MEMORY_MAX_NREGIONS); fds[fd_num++] = fd; } @@ -622,11 +623,13 @@ static bool vhost_user_can_merge(struct vhost_dev *dev, mr = qemu_ram_addr_from_host((void *)(uintptr_t)start1, &ram_addr); assert(mr); - mfd = qemu_get_ram_fd(ram_addr); + assert(mr->ram_block); + mfd = mr->ram_block->fd; mr = qemu_ram_addr_from_host((void *)(uintptr_t)start2, &ram_addr); assert(mr); - rfd = qemu_get_ram_fd(ram_addr); + assert(mr->ram_block); + rfd = mr->ram_block->fd; return mfd == rfd; } diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 5b6e1b8..9a01d4a 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@ -105,9 +105,7 @@ RAMBlock *qemu_ram_alloc_resizeable(ram_addr_t size, ram_addr_t max_size, uint64_t length, void *host), MemoryRegion *mr, Error **errp); -int qemu_get_ram_fd(ram_addr_t addr); -void qemu_set_ram_fd(ram_addr_t addr, int fd); -void *qemu_get_ram_block_host_ptr(ram_addr_t addr); +void *qemu_get_ram_block_host_ptr(RAMBlock *ram_block); void qemu_ram_free(RAMBlock *block); int qemu_ram_resize(RAMBlock *block, ram_addr_t newsize, Error **errp); diff --git a/memory.c b/memory.c index 239e6da..9cff7e2 100644 --- a/memory.c +++ b/memory.c @@ -1641,7 +1641,7 @@ int memory_region_get_fd(MemoryRegion *mr) assert(mr->ram_block); - return qemu_get_ram_fd(memory_region_get_ram_addr(mr) & TARGET_PAGE_MASK); + return mr->ram_block->fd; } void *memory_region_get_ram_ptr(MemoryRegion *mr)