From patchwork Tue Apr 12 10:43:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Liu X-Patchwork-Id: 609336 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qkk5q3TMYz9t40 for ; Tue, 12 Apr 2016 20:42:23 +1000 (AEST) Received: from localhost ([::1]:46675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apvm1-0002N5-PB for incoming@patchwork.ozlabs.org; Tue, 12 Apr 2016 06:42:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apvlc-0001PN-Ds for qemu-devel@nongnu.org; Tue, 12 Apr 2016 06:41:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apvlX-00075o-Os for qemu-devel@nongnu.org; Tue, 12 Apr 2016 06:41:56 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:9166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apvlX-00075X-Kl for qemu-devel@nongnu.org; Tue, 12 Apr 2016 06:41:51 -0400 X-IronPort-AV: E=Sophos;i="5.24,473,1454976000"; d="scan'208";a="353150968" From: Wei Liu To: Date: Tue, 12 Apr 2016 11:43:16 +0100 Message-ID: <1460457796-1779-4-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1460457796-1779-1-git-send-email-wei.liu2@citrix.com> References: <1460457796-1779-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 Subject: [Qemu-devel] [PATCH v2 3/3] xenfb: remove out_cons in xenfb_handle_events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , Xen-devel , Stefano Stabellini , Wei Liu Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The variable out_cons was only used to temporarily hold the consumer index. Use cons directly to simplify code a bit. No functional change introduced. Signed-off-by: Wei Liu Acked-by: Stefano Stabellini --- Cc: Stefano Stabellini Cc: Anthony Perard --- hw/display/xenfb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 7f4fad7..7d50efb 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -770,16 +770,16 @@ static void xenfb_invalidate(void *opaque) static void xenfb_handle_events(struct XenFB *xenfb) { - uint32_t prod, cons, out_cons; + uint32_t prod, cons; struct xenfb_page *page = xenfb->c.page; prod = page->out_prod; - out_cons = page->out_cons; + cons = page->out_cons; xen_rmb(); - if (prod - out_cons > XENFB_OUT_RING_LEN) { + if (prod - cons > XENFB_OUT_RING_LEN) { return; } - for (cons = out_cons; cons != prod; cons++) { + for ( ; cons != prod; cons++) { union xenfb_out_event *event = &XENFB_OUT_RING_REF(page, cons); uint8_t type = event->type; int x, y, w, h;