From patchwork Thu Mar 24 10:39:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: sergey.fedorov@linaro.org X-Patchwork-Id: 601523 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qW2yW0jYDz9sCk for ; Thu, 24 Mar 2016 21:40:34 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=CDDZSzU8; dkim-atps=neutral Received: from localhost ([::1]:49147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj2gq-0002Lp-F3 for incoming@patchwork.ozlabs.org; Thu, 24 Mar 2016 06:40:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj2gF-0001Di-Fu for qemu-devel@nongnu.org; Thu, 24 Mar 2016 06:39:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj2gE-0007u9-KI for qemu-devel@nongnu.org; Thu, 24 Mar 2016 06:39:55 -0400 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:36654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj2gE-0007to-4o for qemu-devel@nongnu.org; Thu, 24 Mar 2016 06:39:54 -0400 Received: by mail-lb0-x22a.google.com with SMTP id qe11so27181946lbc.3 for ; Thu, 24 Mar 2016 03:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=r6RSE6efDJlEANI1szYhfhCEpfo+eKxwXX/5K8TN5EQ=; b=CDDZSzU8zcTQxp3FXgHRatPd3dk/eOBwB4mDSZFhtpkjnZLdaHndgP1PQ4Ptp0HA/K 48WwP3I5uPHfLIlitATk/IkiHauUGwAxh2Ug0x5G66vv0Y5z8w70k0EBeZU+biOiASct y49n/GJtz/37+FjGDdrR4MD9S3qA6B+MDAcyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r6RSE6efDJlEANI1szYhfhCEpfo+eKxwXX/5K8TN5EQ=; b=MG/cQrxrvODH6XMjfqLs4f9/K3EkbmsKdIMCvcR0pBregY2zZ8C5yIwaaGbsnJy0e6 /F71XOw988mJVNcKgRm1B7SKU47a8W+kZG6rHzdQdo/Jq60UODgQekZA00IKvfsfiKWH 0cuEGqRwwBji4DJVCQB/k0EZD7sVcZ2Nu+sbKThaB60RxlJv43PwnS/lDy8SbU8Bxe3p Yk8XtrTpPyCZPyur/PHr30uBK93nyaMJzn4dsOt9/s0lPpN81MxXDumsTpCsm+iDPrOP GnckByj1hMg9DCHy5Dy/PKFFesXAJ9/ul0qoeHdcl5P0m5MuoANBMvX+drMPuhgVfPrQ Td8w== X-Gm-Message-State: AD7BkJLML2+Otzx/KKAnTaYapw+CiwWKrq8jTlbBcMXdVv6WpIYFYDyO0yuVsTyERfDUegOQ X-Received: by 10.112.135.137 with SMTP id ps9mr2649878lbb.73.1458815993395; Thu, 24 Mar 2016 03:39:53 -0700 (PDT) Received: from localhost.localdomain ([195.91.132.170]) by smtp.gmail.com with ESMTPSA id jm10sm1069454lbc.34.2016.03.24.03.39.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Mar 2016 03:39:52 -0700 (PDT) From: sergey.fedorov@linaro.org To: qemu-devel@nongnu.org Date: Thu, 24 Mar 2016 13:39:19 +0300 Message-Id: <1458815961-31979-7-git-send-email-sergey.fedorov@linaro.org> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1458815961-31979-1-git-send-email-sergey.fedorov@linaro.org> References: <1458815961-31979-1-git-send-email-sergey.fedorov@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22a Cc: Sergey Fedorov , Peter Crosthwaite , Paolo Bonzini , Sergey Fedorov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Subject: [Qemu-devel] [PATCH 6/8] tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Sergey Fedorov tb_jmp_remove() was only used to remove the TB from a list of all TBs jumping to the same TB which is n-th jump destination of the given TB. Put a comment briefly describing the function behavior and rename it to better reflect its purpose. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée --- translate-all.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/translate-all.c b/translate-all.c index f68716e1819f..28154ed75888 100644 --- a/translate-all.c +++ b/translate-all.c @@ -922,7 +922,8 @@ static inline void tb_page_remove(TranslationBlock **ptb, TranslationBlock *tb) } } -static inline void tb_jmp_remove(TranslationBlock *tb, int n) +/* remove the TB from a list of TBs jumping to the n-th jump target of the TB */ +static inline void tb_remove_from_jmp_list(TranslationBlock *tb, int n) { TranslationBlock *tb1; uintptr_t *ptb; @@ -995,8 +996,8 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) } /* suppress this TB from the two jump lists */ - tb_jmp_remove(tb, 0); - tb_jmp_remove(tb, 1); + tb_remove_from_jmp_list(tb, 0); + tb_remove_from_jmp_list(tb, 1); /* suppress any remaining jumps to this TB */ tb1 = tb->jmp_list_first;