From patchwork Thu Mar 17 09:20:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhao xiao qiang X-Patchwork-Id: 598953 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qQjZ53DS6z9sBM for ; Thu, 17 Mar 2016 20:22:53 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b=o9vOgTTG; dkim-atps=neutral Received: from localhost ([::1]:33618 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agU8p-0006bY-FZ for incoming@patchwork.ozlabs.org; Thu, 17 Mar 2016 05:22:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agU8C-0005RE-T0 for qemu-devel@nongnu.org; Thu, 17 Mar 2016 05:22:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agU8A-0007Wl-2Y for qemu-devel@nongnu.org; Thu, 17 Mar 2016 05:22:12 -0400 Received: from m12-11.163.com ([220.181.12.11]:51231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agU88-0007W9-Jb for qemu-devel@nongnu.org; Thu, 17 Mar 2016 05:22:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=7oQNhjHJHUL4VxfATZ oGlCRZuff212sdf4ed5SQ8Jyk=; b=o9vOgTTGg9whA7Kpz2PtzfSbaPKR6sG92E hxq5OqdmXAy6+SEcyoX885S+3LiA3+E6c7wVckMNi92lMx69oitE8hEjeWAGjIep whmbtHmT2Ypu/bUZCiCOob7ike1TgvSZY1ZwAXjx3hnWS0MhZ/4AkHKmtImzj01O 894z7Kdm8= Received: from localhost.localdomain (unknown [118.187.28.42]) by smtp7 (Coremail) with SMTP id C8CowABHoWwpd+pWo3YaAw--.26085S6; Thu, 17 Mar 2016 17:21:55 +0800 (CST) From: xiaoqiang zhao To: qemu-devel@nongnu.org Date: Thu, 17 Mar 2016 17:20:28 +0800 Message-Id: <1458206430-21917-5-git-send-email-zxq_yx_007@163.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1458206430-21917-1-git-send-email-zxq_yx_007@163.com> References: <1458206430-21917-1-git-send-email-zxq_yx_007@163.com> X-CM-TRANSID: C8CowABHoWwpd+pWo3YaAw--.26085S6 X-Coremail-Antispam: 1Uf129KBjvJXoW7tw47AFWDXw1DGw1UZrWDurg_yoW8Aw17pF yDCFn8Crs5KF4DZr4xJF1UGFs5twn3Jrnrt34xJrsa9asrCryDtFn0k3yavFW2qaykCFyr Zay8JryxAa1UA3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jLEfOUUUUU= X-Originating-IP: [118.187.28.42] X-CM-SenderInfo: 520ts5t0bqili6rwjhhfrp/1tbiMxQvxlXlfI5EDgAAsG X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.11 Cc: cornelia.huck@de.ibm.com, pbonzini@redhat.com, michael@walle.cc, agraf@suse.de, edgar.iglesias@gmail.com Subject: [Qemu-devel] [PATCH 4/6] hw/char: QOM'ify lm32_uart.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/char/lm32_uart.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/char/lm32_uart.c b/hw/char/lm32_uart.c index 036813d..f29054b 100644 --- a/hw/char/lm32_uart.c +++ b/hw/char/lm32_uart.c @@ -249,13 +249,14 @@ static void uart_reset(DeviceState *d) s->regs[R_LSR] = LSR_THRE | LSR_TEMT; } -static int lm32_uart_init(SysBusDevice *dev) +static void lm32_uart_init(Object *obj) { - LM32UartState *s = LM32_UART(dev); + LM32UartState *s = LM32_UART(obj); + SysBusDevice *dev = SYS_BUS_DEVICE(obj); sysbus_init_irq(dev, &s->irq); - memory_region_init_io(&s->iomem, OBJECT(s), &uart_ops, s, + memory_region_init_io(&s->iomem, obj, &uart_ops, s, "uart", R_MAX * 4); sysbus_init_mmio(dev, &s->iomem); @@ -264,8 +265,6 @@ static int lm32_uart_init(SysBusDevice *dev) if (s->chr) { qemu_chr_add_handlers(s->chr, uart_can_rx, uart_rx, uart_event, s); } - - return 0; } static const VMStateDescription vmstate_lm32_uart = { @@ -281,9 +280,7 @@ static const VMStateDescription vmstate_lm32_uart = { static void lm32_uart_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass); - k->init = lm32_uart_init; dc->reset = uart_reset; dc->vmsd = &vmstate_lm32_uart; /* Reason: init() method uses qemu_char_get_next_serial() */ @@ -294,6 +291,7 @@ static const TypeInfo lm32_uart_info = { .name = TYPE_LM32_UART, .parent = TYPE_SYS_BUS_DEVICE, .instance_size = sizeof(LM32UartState), + .instance_init = lm32_uart_init, .class_init = lm32_uart_class_init, };