| Message ID | 1455470231-5223-5-git-send-email-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Sun, 14 Feb 2016 18:17:07 +0100 Paolo Bonzini <pbonzini@redhat.com> wrote: > Virtio dataplane needs to trigger the irq manually through the > guest notifier. Export virtio_should_notify so that it can be > used around event_notifier_set. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/virtio/virtio.c | 4 ++-- > include/hw/virtio/virtio.h | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > The name is better as well :) Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
On Sun, 02/14 18:17, Paolo Bonzini wrote: > Virtio dataplane needs to trigger the irq manually through the > guest notifier. Export virtio_should_notify so that it can be > used around event_notifier_set. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/virtio/virtio.c | 4 ++-- > include/hw/virtio/virtio.h | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 3a5cca4..abb97f4 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -1162,7 +1162,7 @@ void virtio_irq(VirtQueue *vq) > virtio_notify_vector(vq->vdev, vq->vector); > } > > -static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq) > +bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq) > { > uint16_t old, new; > bool v; > @@ -1187,7 +1187,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq) > > void virtio_notify(VirtIODevice *vdev, VirtQueue *vq) > { > - if (!vring_notify(vdev, vq)) { > + if (!virtio_should_notify(vdev, vq)) { > return; > } > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index 4ce01a1..5884228 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -162,6 +162,7 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes, > unsigned int *out_bytes, > unsigned max_in_bytes, unsigned max_out_bytes); > > +bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq); > void virtio_notify(VirtIODevice *vdev, VirtQueue *vq); > > void virtio_save(VirtIODevice *vdev, QEMUFile *f); > -- > 1.8.3.1 > > > Reviewed-by: Fam Zheng <famz@redhat.com>
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 3a5cca4..abb97f4 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -1162,7 +1162,7 @@ void virtio_irq(VirtQueue *vq) virtio_notify_vector(vq->vdev, vq->vector); } -static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq) +bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq) { uint16_t old, new; bool v; @@ -1187,7 +1187,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq) void virtio_notify(VirtIODevice *vdev, VirtQueue *vq) { - if (!vring_notify(vdev, vq)) { + if (!virtio_should_notify(vdev, vq)) { return; } diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 4ce01a1..5884228 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -162,6 +162,7 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes, unsigned int *out_bytes, unsigned max_in_bytes, unsigned max_out_bytes); +bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq); void virtio_notify(VirtIODevice *vdev, VirtQueue *vq); void virtio_save(VirtIODevice *vdev, QEMUFile *f);
Virtio dataplane needs to trigger the irq manually through the guest notifier. Export virtio_should_notify so that it can be used around event_notifier_set. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/virtio/virtio.c | 4 ++-- include/hw/virtio/virtio.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)