| Message ID | 1455306542-15043-1-git-send-email-marcel@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 02/12/16 20:49, Marcel Apfelbaum wrote: > Eduardo and me will maintain it. I suggest "Eduardo and I". Eric? :) Laszlo > > Signed-off-by: Marcel Apfelbaum <marcel@redhat.com> > Acked-by: Andreas Färber <afaerber@suse.de> > --- > > v1 -> v2: > Modified description to "Machine core" (Eduardo) > > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2d6ee17..0590342 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1200,6 +1200,13 @@ F: docs/*qmp-* > F: scripts/qmp/ > T: git git://repo.or.cz/qemu/armbru.git qapi-next > > +Machine core > +M: Eduardo Habkost <ehabkost@redhat.com> > +M: Marcel Apfelbaum <marcel@redhat.com> > +S: Supported > +F: hw/core/machine.c > +F: include/hw/boards.h > + > SLIRP > M: Jan Kiszka <jan.kiszka@siemens.com> > S: Maintained >
On 02/13/2016 01:10 AM, Laszlo Ersek wrote: > On 02/12/16 20:49, Marcel Apfelbaum wrote: >> Eduardo and me will maintain it. > > I suggest "Eduardo and I". > > Eric? :) Correct. In English, if you are including yourself in a list, it's good form to list the first-person pronoun last; then the next rule to remember is to use the same pronoun that you would use in isolation without the list. Since that would be "I will maintain", it turns into "Eduardo and I will maintain". Conversely, "give maintainer duties to me" would become "give maintainer duties to Eduardo and me". Unfortunately, even among native English speakers, it is a rather common mistake to hear "something and me" used where "I" would have been correct. [Looks like I've made a name for myself in trying to paraphrase native English rules...]
On 02/13/2016 07:39 PM, Eric Blake wrote: > On 02/13/2016 01:10 AM, Laszlo Ersek wrote: >> On 02/12/16 20:49, Marcel Apfelbaum wrote: >>> Eduardo and me will maintain it. >> >> I suggest "Eduardo and I". >> >> Eric? :) > > Correct. In English, if you are including yourself in a list, it's good > form to list the first-person pronoun last; then the next rule to > remember is to use the same pronoun that you would use in isolation > without the list. Since that would be "I will maintain", it turns into > "Eduardo and I will maintain". Conversely, "give maintainer duties to > me" would become "give maintainer duties to Eduardo and me". > > Unfortunately, even among native English speakers, it is a rather common > mistake to hear "something and me" used where "I" would have been correct. > > [Looks like I've made a name for myself in trying to paraphrase native > English rules...] > Thanks for yet another English lesson :) Maybe the maintainer can tweak it before taking it. Thanks, Marcel
diff --git a/MAINTAINERS b/MAINTAINERS index 2d6ee17..0590342 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1200,6 +1200,13 @@ F: docs/*qmp-* F: scripts/qmp/ T: git git://repo.or.cz/qemu/armbru.git qapi-next +Machine core +M: Eduardo Habkost <ehabkost@redhat.com> +M: Marcel Apfelbaum <marcel@redhat.com> +S: Supported +F: hw/core/machine.c +F: include/hw/boards.h + SLIRP M: Jan Kiszka <jan.kiszka@siemens.com> S: Maintained