| Message ID | 1452676712-24239-5-git-send-email-xiecl.fnst@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Jan 13, 2016 at 05:18:28PM +0800, Changlong Xie wrote: > From: Wen Congyang <wency@cn.fujitsu.com> > > When opening BDS, we need to create backup jobs for > image-fleecing. > > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > Reviewed-by: Jeff Cody <jcody@redhat.com> > --- > block/Makefile.objs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/Makefile.objs b/block/Makefile.objs > index 58ef2ef..fa05f37 100644 > --- a/block/Makefile.objs > +++ b/block/Makefile.objs > @@ -22,10 +22,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o > block-obj-$(CONFIG_LIBSSH2) += ssh.o > block-obj-y += accounting.o > block-obj-y += write-threshold.o > +block-obj-y += backup.o > > common-obj-y += stream.o > common-obj-y += commit.o > -common-obj-y += backup.o > > iscsi.o-cflags := $(LIBISCSI_CFLAGS) > iscsi.o-libs := $(LIBISCSI_LIBS) The commit message and description seem outdated. I guess the purpose of this patch is to link the backup block job into all programs that use the block layer because you want to add a dependency on the it from core code.
On 01/27/2016 10:04 PM, Stefan Hajnoczi wrote: > On Wed, Jan 13, 2016 at 05:18:28PM +0800, Changlong Xie wrote: >> From: Wen Congyang <wency@cn.fujitsu.com> >> >> When opening BDS, we need to create backup jobs for >> image-fleecing. >> >> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> >> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> >> Signed-off-by: Gonglei <arei.gonglei@huawei.com> >> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com> >> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> >> Reviewed-by: Jeff Cody <jcody@redhat.com> >> --- >> block/Makefile.objs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/Makefile.objs b/block/Makefile.objs >> index 58ef2ef..fa05f37 100644 >> --- a/block/Makefile.objs >> +++ b/block/Makefile.objs >> @@ -22,10 +22,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o >> block-obj-$(CONFIG_LIBSSH2) += ssh.o >> block-obj-y += accounting.o >> block-obj-y += write-threshold.o >> +block-obj-y += backup.o >> >> common-obj-y += stream.o >> common-obj-y += commit.o >> -common-obj-y += backup.o >> >> iscsi.o-cflags := $(LIBISCSI_CFLAGS) >> iscsi.o-libs := $(LIBISCSI_LIBS) > > The commit message and description seem outdated. I guess the purpose > of this patch is to link the backup block job into all programs that use > the block layer because you want to add a dependency on the it from core > code. > Will update it in next version. Thanks -Xie
diff --git a/block/Makefile.objs b/block/Makefile.objs index 58ef2ef..fa05f37 100644 --- a/block/Makefile.objs +++ b/block/Makefile.objs @@ -22,10 +22,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o block-obj-$(CONFIG_LIBSSH2) += ssh.o block-obj-y += accounting.o block-obj-y += write-threshold.o +block-obj-y += backup.o common-obj-y += stream.o common-obj-y += commit.o -common-obj-y += backup.o iscsi.o-cflags := $(LIBISCSI_CFLAGS) iscsi.o-libs := $(LIBISCSI_LIBS)