| Message ID | 1452519152-6500-2-git-send-email-minyard@acm.org |
|---|---|
| State | New |
| Headers | show |
On Mon, Jan 11, 2016 at 07:32:31AM -0600, minyard@acm.org wrote: > From: Corey Minyard <cminyard@mvista.com> > > Found by Paolo. > > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: Shannon Zhao <zhaoshenglong@huawei.com> > Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com> > Cc: Stefan Hajnoczi <stefanha@redhat.com> > Signed-off-by: Corey Minyard <cminyard@mvista.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > --- > hw/ipmi/ipmi_bmc_sim.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index 0a59e53..3ecf02e 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -546,7 +546,7 @@ static void ipmi_init_sensors_from_sdrs(IPMIBmcSim *s) > static int ipmi_register_netfn(IPMIBmcSim *s, unsigned int netfn, > const IPMINetfn *netfnd) > { > - if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) { > + if ((netfn & 1) || (netfn >= MAX_NETFNS) || (s->netfns[netfn / 2])) { > return -1; > } > s->netfns[netfn / 2] = netfnd; > -- > 2.5.0
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 0a59e53..3ecf02e 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -546,7 +546,7 @@ static void ipmi_init_sensors_from_sdrs(IPMIBmcSim *s) static int ipmi_register_netfn(IPMIBmcSim *s, unsigned int netfn, const IPMINetfn *netfnd) { - if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) { + if ((netfn & 1) || (netfn >= MAX_NETFNS) || (s->netfns[netfn / 2])) { return -1; } s->netfns[netfn / 2] = netfnd;