diff mbox

virtio serial port: fix to incomplete QOMify

Message ID 1452068575-21543-1-git-send-email-caoj.fnst@cn.fujitsu.com
State New
Headers show

Commit Message

Cao jin Jan. 6, 2016, 8:22 a.m. UTC 
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 hw/char/virtio-serial-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kurz Jan. 6, 2016, 8:33 a.m. UTC | #1 
On Wed, 6 Jan 2016 16:22:55 +0800
Cao jin <caoj.fnst@cn.fujitsu.com> wrote:

> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---

Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>

>  hw/char/virtio-serial-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 497b0af..2d2a659 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
> 
>  static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
>  {
> -    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
> +    VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
> 
>      monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
>                     indent, "", port->id,
Amit Shah Jan. 7, 2016, 9:57 a.m. UTC | #2 
On (Wed) 06 Jan 2016 [16:22:55], Cao jin wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  hw/char/virtio-serial-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 497b0af..2d2a659 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
>  
>  static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
>  {
> -    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
> +    VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
>  
>      monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
>                     indent, "", port->id,

Reviewed-by: Amit Shah <amit.shah@redhat.com>

Applied to my tree, thanks.

		Amit
diff mbox

Patch

diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index 497b0af..2d2a659 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -798,7 +798,7 @@  static const TypeInfo virtser_bus_info = {
 
 static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
 {
-    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
+    VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
 
     monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
                    indent, "", port->id,