| Message ID | 1452020761-24457-4-git-send-email-wei.liu2@citrix.com |
|---|---|
| State | New |
| Headers | show |
Wrong subject line: you are renaming virtio-9p-local.c On Tue, 5 Jan 2016, Wei Liu wrote: > This file is not virtio specific. Rename it to use generic name. > > Fix comment and remove unneeded inclusion of virtio.h. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > --- > hw/9pfs/{virtio-9p-local.c => 9p-local.c} | 3 +-- > hw/9pfs/Makefile.objs | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > rename hw/9pfs/{virtio-9p-local.c => 9p-local.c} (99%) > > diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/9p-local.c > similarity index 99% > rename from hw/9pfs/virtio-9p-local.c > rename to hw/9pfs/9p-local.c > index f1f2e25..877ad86 100644 > --- a/hw/9pfs/virtio-9p-local.c > +++ b/hw/9pfs/9p-local.c > @@ -1,5 +1,5 @@ > /* > - * Virtio 9p Posix callback > + * 9p Posix callback > * > * Copyright IBM, Corp. 2010 > * > @@ -11,7 +11,6 @@ > * > */ > > -#include "hw/virtio/virtio.h" > #include "virtio-9p.h" > #include "virtio-9p-xattr.h" > #include "fsdev/qemu-fsdev.h" /* local_ops */ > diff --git a/hw/9pfs/Makefile.objs b/hw/9pfs/Makefile.objs > index 9fdd8a4..5059681 100644 > --- a/hw/9pfs/Makefile.objs > +++ b/hw/9pfs/Makefile.objs > @@ -1,5 +1,5 @@ > common-obj-y = virtio-9p.o > -common-obj-y += virtio-9p-local.o virtio-9p-xattr.o > +common-obj-y += 9p-local.o virtio-9p-xattr.o > common-obj-y += virtio-9p-xattr-user.o virtio-9p-posix-acl.o > common-obj-y += coth.o cofs.o codir.o cofile.o > common-obj-y += coxattr.o virtio-9p-synth.o > -- > 2.1.4 > >
On Wed, Jan 06, 2016 at 11:22:51AM +0000, Stefano Stabellini wrote: > Wrong subject line: you are renaming virtio-9p-local.c > Oops, yes. I will fix this. Wei.
diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/9p-local.c similarity index 99% rename from hw/9pfs/virtio-9p-local.c rename to hw/9pfs/9p-local.c index f1f2e25..877ad86 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/9p-local.c @@ -1,5 +1,5 @@ /* - * Virtio 9p Posix callback + * 9p Posix callback * * Copyright IBM, Corp. 2010 * @@ -11,7 +11,6 @@ * */ -#include "hw/virtio/virtio.h" #include "virtio-9p.h" #include "virtio-9p-xattr.h" #include "fsdev/qemu-fsdev.h" /* local_ops */ diff --git a/hw/9pfs/Makefile.objs b/hw/9pfs/Makefile.objs index 9fdd8a4..5059681 100644 --- a/hw/9pfs/Makefile.objs +++ b/hw/9pfs/Makefile.objs @@ -1,5 +1,5 @@ common-obj-y = virtio-9p.o -common-obj-y += virtio-9p-local.o virtio-9p-xattr.o +common-obj-y += 9p-local.o virtio-9p-xattr.o common-obj-y += virtio-9p-xattr-user.o virtio-9p-posix-acl.o common-obj-y += coth.o cofs.o codir.o cofile.o common-obj-y += coxattr.o virtio-9p-synth.o
This file is not virtio specific. Rename it to use generic name. Fix comment and remove unneeded inclusion of virtio.h. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- hw/9pfs/{virtio-9p-local.c => 9p-local.c} | 3 +-- hw/9pfs/Makefile.objs | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) rename hw/9pfs/{virtio-9p-local.c => 9p-local.c} (99%)