From patchwork Tue Dec 22 06:59:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Denis V. Lunev" X-Patchwork-Id: 559884 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AE0EF140BB4 for ; Tue, 22 Dec 2015 18:00:11 +1100 (AEDT) Received: from localhost ([::1]:49024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBGvZ-0001r3-Ms for incoming@patchwork.ozlabs.org; Tue, 22 Dec 2015 02:00:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBGvL-0001Y6-B1 for qemu-devel@nongnu.org; Tue, 22 Dec 2015 01:59:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBGvH-0007Ao-BT for qemu-devel@nongnu.org; Tue, 22 Dec 2015 01:59:55 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:10937 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBGvG-00078l-UF for qemu-devel@nongnu.org; Tue, 22 Dec 2015 01:59:51 -0500 Received: from hades.sw.ru ([10.30.8.132]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id tBM6xkUu002949; Tue, 22 Dec 2015 09:59:48 +0300 (MSK) From: "Denis V. Lunev" To: Date: Tue, 22 Dec 2015 09:59:46 +0300 Message-Id: <1450767586-28794-1-git-send-email-den@openvz.org> X-Mailer: git-send-email 2.5.0 X-detected-operating-system: by eggs.gnu.org: OpenBSD 3.x X-Received-From: 195.214.232.25 Cc: Kevin Wolf , "Denis V. Lunev" , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org error: Failed to start domain rhel7 error: internal error: process exited while connecting to monitor: 2015-12-22T06:55:18.812637Z qemu-system-x86_64: -drive file=/var/lib/libvirt/images/rhel7.qcow2,if=none, id=drive-scsi0-0-0-0,format=qcow2,cache=none,aio=native: aio=native was specified, but it requires cache.direct=on, which was not specified. cache=none option was specified as seen above while the VM is unable to start. The patch properly passed BDRV_O_NOCACHE to underlying layer. The problem is revealed with commit d657c0c289e944fc22289f5c318f48da87d79dcb Author: Kevin Wolf Date: Tue Dec 15 11:35:36 2015 +0100 raw-posix: Make aio=native option binding Signed-off-by: Denis V. Lunev CC: Kevin Wolf Acked-by: Christian Borntraeger --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index 411edbf..fe0fbbc 100644 --- a/block.c +++ b/block.c @@ -990,6 +990,7 @@ static int bdrv_open_common(BlockDriverState *bs, BdrvChild *file, bs->opaque = g_malloc0(drv->instance_size); /* Apply cache mode options */ + update_flags_from_options(&open_flags, opts); update_flags_from_options(&bs->open_flags, opts); bdrv_set_enable_write_cache(bs, bs->open_flags & BDRV_O_CACHE_WB);