| Message ID | 1447419494-10670-1-git-send-email-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 11/13/2015 05:58 AM, Paolo Bonzini wrote: > Ensure that the error is printed with the proper timestamp. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > net/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/net/dump.c b/net/dump.c > index dd0555f..ab71ffc 100644 > --- a/net/dump.c > +++ b/net/dump.c > @@ -84,7 +84,7 @@ static ssize_t dump_receive_iov(DumpState *s, const struct iovec *iov, int cnt) > cnt = iov_copy(&dumpiov[1], cnt, iov, cnt, 0, caplen); > > if (writev(s->fd, dumpiov, cnt + 1) != sizeof(hdr) + caplen) { > - qemu_log("-net dump write error - stop dump\n"); > + error_report("-net dump write error - stop dump"); > close(s->fd); > s->fd = -1; > } >
On 13/11/15 13:58, Paolo Bonzini wrote: > Ensure that the error is printed with the proper timestamp. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > net/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/dump.c b/net/dump.c > index dd0555f..ab71ffc 100644 > --- a/net/dump.c > +++ b/net/dump.c > @@ -84,7 +84,7 @@ static ssize_t dump_receive_iov(DumpState *s, const struct iovec *iov, int cnt) > cnt = iov_copy(&dumpiov[1], cnt, iov, cnt, 0, caplen); > > if (writev(s->fd, dumpiov, cnt + 1) != sizeof(hdr) + caplen) { > - qemu_log("-net dump write error - stop dump\n"); > + error_report("-net dump write error - stop dump"); > close(s->fd); > s->fd = -1; > } We should maybe also reword that text a little bit, since this code is now used by the netdev dumping filter, too, so "-net dump" is not the only user anymore. Anyway, that can also be done with a later patch, so if you don't want to do this now: Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/net/dump.c b/net/dump.c index dd0555f..ab71ffc 100644 --- a/net/dump.c +++ b/net/dump.c @@ -84,7 +84,7 @@ static ssize_t dump_receive_iov(DumpState *s, const struct iovec *iov, int cnt) cnt = iov_copy(&dumpiov[1], cnt, iov, cnt, 0, caplen); if (writev(s->fd, dumpiov, cnt + 1) != sizeof(hdr) + caplen) { - qemu_log("-net dump write error - stop dump\n"); + error_report("-net dump write error - stop dump"); close(s->fd); s->fd = -1; }
Ensure that the error is printed with the proper timestamp. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- net/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)