| Message ID | 1447368949-15312-3-git-send-email-bsd@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 11/12/2015 03:55 PM, Bandan Das wrote: > There's no indication of any sort that i440fx doesn't support > "iommu=on"" > > Signed-off-by: Bandan Das <bsd@redhat.com> > --- > hw/pci-host/piix.c | 5 +++++ > 1 file changed, 5 insertions(+) > > @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) > static void i440fx_realize(PCIDevice *dev, Error **errp) > { > dev->config[I440FX_SMRAM] = 0x02; > + > + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { > + error_report("warning: i440fx doesn't support emulated iommu\n"); No trailing \n with error_report(). With that fixed (and perhaps maintainer can do it), Reviewed-by: Eric Blake <eblake@redhat.com>
Eric Blake <eblake@redhat.com> writes: > On 11/12/2015 03:55 PM, Bandan Das wrote: >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das <bsd@redhat.com> >> --- >> hw/pci-host/piix.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> > >> @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) >> static void i440fx_realize(PCIDevice *dev, Error **errp) >> { >> dev->config[I440FX_SMRAM] = 0x02; >> + >> + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { >> + error_report("warning: i440fx doesn't support emulated iommu\n"); > > No trailing \n with error_report(). > > With that fixed (and perhaps maintainer can do it), No problem, I sent out an updated version. Thanks for the review! Bandan > Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..ffcb846 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -34,6 +34,7 @@ #include "sysemu/sysemu.h" #include "hw/i386/ioapic.h" #include "qapi/visitor.h" +#include "qemu/error-report.h" /* * I440FX chipset data sheet. @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) static void i440fx_realize(PCIDevice *dev, Error **errp) { dev->config[I440FX_SMRAM] = 0x02; + + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { + error_report("warning: i440fx doesn't support emulated iommu\n"); + } } PCIBus *i440fx_init(const char *host_type, const char *pci_type,
There's no indication of any sort that i440fx doesn't support "iommu=on"" Signed-off-by: Bandan Das <bsd@redhat.com> --- hw/pci-host/piix.c | 5 +++++ 1 file changed, 5 insertions(+)