From patchwork Mon Nov 2 09:13:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Guangrong X-Patchwork-Id: 538917 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0EFB8140311 for ; Mon, 2 Nov 2015 20:30:48 +1100 (AEDT) Received: from localhost ([::1]:40932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtBRt-0000SU-N7 for incoming@patchwork.ozlabs.org; Mon, 02 Nov 2015 04:30:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtBHm-0007yO-6t for qemu-devel@nongnu.org; Mon, 02 Nov 2015 04:20:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtBHj-0003yT-Bz for qemu-devel@nongnu.org; Mon, 02 Nov 2015 04:20:18 -0500 Received: from mga02.intel.com ([134.134.136.20]:9345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtBHj-0003xj-6n for qemu-devel@nongnu.org; Mon, 02 Nov 2015 04:20:15 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 02 Nov 2015 01:20:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="840963245" Received: from xiaoreal1.sh.intel.com (HELO xiaoreal1.sh.intel.com.sh.intel.com) ([10.239.48.79]) by fmsmga002.fm.intel.com with ESMTP; 02 Nov 2015 01:19:58 -0800 From: Xiao Guangrong To: pbonzini@redhat.com, imammedo@redhat.com Date: Mon, 2 Nov 2015 17:13:24 +0800 Message-Id: <1446455617-129562-23-git-send-email-guangrong.xiao@linux.intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com> References: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.20 Cc: vsementsov@virtuozzo.com, Xiao Guangrong , ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net Subject: [Qemu-devel] [PATCH v7 22/35] dimm: introduce realize callback X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org nvdimm need check if the backend memory is large enough to contain label data and init its memory region when the device is realized, so introduce realize callback which is called after common dimm has been realize Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Xiao Guangrong --- hw/mem/dimm.c | 5 +++++ include/hw/mem/dimm.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/mem/dimm.c b/hw/mem/dimm.c index 44447d1..0ae23ce 100644 --- a/hw/mem/dimm.c +++ b/hw/mem/dimm.c @@ -426,6 +426,7 @@ static void dimm_init(Object *obj) static void dimm_realize(DeviceState *dev, Error **errp) { DIMMDevice *dimm = DIMM(dev); + DIMMDeviceClass *ddc = DIMM_GET_CLASS(dimm); if (!dimm->hostmem) { error_setg(errp, "'" DIMM_MEMDEV_PROP "' property is not set"); @@ -438,6 +439,10 @@ static void dimm_realize(DeviceState *dev, Error **errp) dimm->node, nb_numa_nodes ? nb_numa_nodes : 1); return; } + + if (ddc->realize) { + ddc->realize(dimm, errp); + } } static void dimm_class_init(ObjectClass *oc, void *data) diff --git a/include/hw/mem/dimm.h b/include/hw/mem/dimm.h index 50f768a..72ec24c 100644 --- a/include/hw/mem/dimm.h +++ b/include/hw/mem/dimm.h @@ -65,6 +65,7 @@ typedef struct DIMMDeviceClass { DeviceClass parent_class; /* public */ + void (*realize)(DIMMDevice *dimm, Error **errp); MemoryRegion *(*get_memory_region)(DIMMDevice *dimm); } DIMMDeviceClass;